Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of the PR #15242 - Content Filters string isn't translated in brave://settings/shields/filters page #26062

Closed
GeetaSarvadnya opened this issue Oct 17, 2022 · 2 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 17, 2022

Description

Follow up of the PR #brave/brave-core#15242
Content Filters string isn't translated in brave://settings/shields/filters page

Steps to Reproduce

  1. Set OS locale to Germany/France/Polish
  2. Clean profile 1.46.63
  3. Follow the steps from the issue Few strings are not translated in content filtering screen #24004
  4. Content Filters string isn't translated in brave://settings/shields/filters page

Actual result:

Content Filters string isn't translated in brave://settings/shields/filters page

Germany
image

Expected result:

Content Filters string should be translated in other locales

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.46.63 Chromium: 107.0.5304.36 (Offizieller Build) nightly (64-Bit)
Überarbeitung 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
Betriebssystem Windows 10 Version 21H2 (Build 19044.2130)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @nullhook

@rebron
Copy link
Collaborator

rebron commented Oct 21, 2022

@GeetaSarvadnya Needs a re-check after translations land for 1.45.x

@GeetaSarvadnya
Copy link
Author

Verified the issue against the build 1.45.113 on the OS Windows 10 x64 and ensured Content Filters text in brave://settings/shields/filters page is translated in other locales like Germany, France and Polish. Hence closing the issue. Thanks @rebron !

Germany France Polish
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants