Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few strings are not translated in content filtering screen #24004

Closed
GeetaSarvadnya opened this issue Jul 12, 2022 · 3 comments · Fixed by brave/brave-core#15242
Closed

Few strings are not translated in content filtering screen #24004

GeetaSarvadnya opened this issue Jul 12, 2022 · 3 comments · Fixed by brave/brave-core#15242

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #23914

Few strings are not translated in content filtering screens

Steps to Reproduce

  1. Set OS locales to Kannada/Germany/Hindi/France
  2. Open brave://settings/shields/filters
  3. Few strings Filter lists, Content filters, and Show full list are not translated in other locales

Actual result:

Germany

image

Expected result:

Strings should be translated

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.41.96 Chromium: 103.0.5060.114 (Offizieller Build) (64-Bit)
Überarbeitung a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
Betriebssystem Windows 10 Version 21H2 (Build 19044.1806)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? NA

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @mkarolin @rebron @brave/qa-team

@mkarolin
Copy link
Contributor

cc: @nullhook

@kjozwiak
Copy link
Member

The above requires 1.45.104 or higher for 1.45.x verification 👍

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 17, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Oct 18, 2022

Verified with

Brave | 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (x86_64)
-- | --
Revision | fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS | macOS Version 12.6 (Build 21G115)
Polish French Spanish Japanese
Polish French Spanish Japanese

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants