Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing strings to adblock page (uplift to 1.45.x) #15456

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Added missing strings to adblock page (uplift to 1.45.x) #15456

merged 1 commit into from
Oct 17, 2022

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented Oct 13, 2022 •
edited by kjozwiak
Loading

Uplift of #15242
Resolves brave/brave-browser#25458
Resolves brave/brave-browser#24004

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@nullhook nullhook requested a review from a team as a code owner October 13, 2022 17:48
@kjozwiak kjozwiak added this to the 1.45.x - Beta milestone Oct 17, 2022
kjozwiak
kjozwiak approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.45.x approved 👍 QA has verified the PR on Nightly as per #15242 (comment).

@kjozwiak kjozwiak merged commit 8c8b1af into 1.45.x Oct 17, 2022
@kjozwiak kjozwiak deleted the adblock_missing_string-1.45.x branch October 17, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@nullhook nullhook

Labels
None yet
Projects
None yet
Milestone
1.45.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@nullhook @kjozwiak