Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update show bookmarks setting #26072

Closed
rebron opened this issue Oct 17, 2022 · 4 comments · Fixed by brave/brave-core#15577
Closed

Update show bookmarks setting #26072

rebron opened this issue Oct 17, 2022 · 4 comments · Fixed by brave/brave-core#15577
Assignees
@spylogsster
Labels
feature/new-tab feature/settings OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 17, 2022 •
edited
Loading

Description

The Show bookmarks setting and Always show bookmarks on the new tab page are related and work together as there are four states (with one broken state). Users don't know that they do work together and often want to hide bookmarks completely and yet still see the bookmarks bar on the new tab page when they've explicitly wanted to hide bookmarks. Further, these two settings are not placed close together and therefore don't look to be related.

Current settings

  1. Default. Show bookmarks [off], Always show bookmarks on the new tab [on]. Matches Chrome default.
  2. Show bookmarks [on]. Always show bookmarks on the new tab [on]. Bookmarks bar on for all tab pages
  3. Show bookmarks [off]. Always show bookmarks on the new tab [off]. Bookmarks bar all off for all tab pages.
  4. Show bookmarks [on]. Always show bookmarks on the new tab [off]. Broken setting but wontfix.

Updated Show bookmarks setting will delete Always show bookmarks on the new tab page setting and make Show bookmarks a drop down choice of three options:

  1. Always (default)
  2. Never
  3. Only on the new tab page

New users should have Only on the new tab page as their default.

Existing users will carry their setting from previous versions which in most cases will be Show bookmarks [off] and Always show bookmarks on the new tab page [on].

To be discussed
Note that on macOS with the View menu, the options Always show bookmarks is a checkbox. We will keep that checkbox to be Always and Never. Users will need to go into Settings to change to Only in the new tab page and. If users select Only in the new tab page in settings, the View menu will be reflected as Always.

Expected Design

image

Currently in release for reference

Screenshot 2022-10-17 at 7 53 39 AM

Brave version (brave://version info)

Targeted for 1.47

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Related issue: #25834
@spylogsster spylogsster mentioned this issue Oct 20, 2022
Merged
25 tasks
@spylogsster spylogsster added this to the 1.47.x - Nightly milestone Oct 20, 2022
@rebron rebron removed this from the 1.47.x - Beta milestone Nov 28, 2022
@spylogsster spylogsster added this to the 1.49.x - Nightly milestone Jan 17, 2023
@LaurenWags
Copy link
Member

@brave/qa-team when verifying this issue please be thorough with upgrade cases to ensure that all upgrade scenarios/permutations are covered (can reference #26072 (comment) to help determine this)

@stephendonner
Copy link

stephendonner commented Feb 16, 2023 •
edited
Loading

Verification PASSED using

Brave 1.49.100 Chromium: 110.0.5481.100 (Official Build) beta (x86_64)
Revision 4be7a36f7cb943af6118e449bbab494b43dcaddd-refs/branch-heads/5481_77@{#14}
OS macOS Version 11.7.4 (Build 20G1120)

Upgrade - PASSED

Shared Steps:

  1. installed 1.48.164
  2. launched Brave
  3. opened chrome://settings/appearance
  4. ensured bookmark-related prefs were On/Off per each upgrade scenario
  5. installed 1.49.100
  6. renamed Brave-Browser profile to Brave-Browser-Beta
  7. launched Brave
  8. checked the state of Show bookmarks, post-upgrade

Case 1 (default): Show Bookmarks set to Off, Always show bookmarks on new tab page set to On - PASSED

1.48.164 1.49.100 Bookmarks Bar
Screen Shot 2023-02-16 at 11 17 35 AM Screen Shot 2023-02-16 at 1 22 23 PM Screen Shot 2023-02-16 at 2 20 05 PM

Confirmed Show bookmarks is set to Only on the new tab page

Confirmed the brave://settings/appearance window did NOT have the Bookmarks Bar

Confirmed this default, when migrated, is the same as the default for the New profile case

Confirmed a new-tab page/window had the Bookmarks Bar

Case 2: Show Bookmarks set to On, Always show bookmarks on new tab page set to On - PASSED

1.48.164 1.49.100
Screen Shot 2023-02-16 at 11 20 59 AM Screen Shot 2023-02-16 at 11 23 05 AM

Confirmed Show bookmarks is set to Always

Confirmed the brave://settings/appearance window had the Bookmarks Bar

Case 3: Show Bookmarks set to Off, Always show bookmarks on new tab page set to Off - PASSED

1.48.164 1.49.100
Screen Shot 2023-02-16 at 11 30 28 AM Screen Shot 2023-02-16 at 11 37 38 AM

Confirmed Show bookmarks is set to Never

Confirmed the brave://settings/appearance window did NOT have the Bookmarks Bar

Case 4: Show Bookmarks set to On, Always show bookmarks on new tab page set to Off- PASSED

1.48.164 1.49.100
Screen Shot 2023-02-16 at 11 39 51 AM Screen Shot 2023-02-16 at 11 42 29 AM

Confirmed Show bookmarks is set to Always

New profile - PASSED

Shared Steps:

  1. installed 1.49.100
  2. launched Brave
  3. opened brave://settings/appearance
  4. ensured Show bookmarks pref values were set as per cases below

Case 1 (default): Show bookmarks set to Only on the new tab page - PASSED

opened a new-tab page/window

example example
Screen Shot 2023-02-16 at 1 49 24 PM Screen Shot 2023-02-16 at 1 49 35 PM

Confirmed brave://settings/appearance did NOT have the Bookmarks Bar

Confirmed a new tab page/window had the Bookmarks Bar

Case 2: Show bookmarks set to Never - PASSED

(continued from `Shared Steps`)

opened a new-tab page/window

example example
Screen Shot 2023-02-16 at 1 59 39 PM Screen Shot 2023-02-16 at 2 07 01 PM

Confirmed brave://settings/appearance did NOT have the Bookmarks Bar

Confirmed a new tab page/window did NOT have the Bookmarks Bar

Case 3: Show bookmarks set to Always - PASSED

example example
Screen Shot 2023-02-16 at 2 08 50 PM Screen Shot 2023-02-16 at 2 09 26 PM

Confirmed brave://settings/appearance showed the Bookmarks Bar

Confirmed new tab pages/windows had the Bookmarks Bar

Note:

Also noting the idiosyncrasy on macOS, where the View -> Show bookmarks toggle, when set to Enabled / On changes the value of Show bookmarks in brave://settings/appearance from Only on the new tab page to Always.

Only on new tab pages Always
Screen Shot 2023-02-17 at 10 42 59 AM Screen Shot 2023-02-17 at 10 43 10 AM

The only way to restore the value Only on the new tab page is to set it manually, again, on brave://settings/appearance.

Logged:

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 16, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 22, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.49.106 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
-- | --
Revision | 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS | Windows 11 Version 21H2 (Build 22000.1574)

New Install

Case 1: Default option set Only on the new tab page when no bookmarks imported via brave://welcome- PASSED

  1. installed 1.49.106
  2. launched Brave
  3. Skip >> Skip >> Finish
  4. opened brave://settings/appearance in a new tab page
  5. opened a new tab page, New window, Private Window and Tor Window & Guest window
  • Confirmed Show bookmarks setting has three options Only on the new tab, Never and Always in the brave://settings/appearance
  • Confirmed Only on the new tab is shown as default in the drop down menu for Show bookmarks setting
  • Confirmed Always show bookmarks on new tab page setting is no longer available.
  • Confirmed the brave://settings/appearance page did NOT have the bookmarks bar
  • Confirmed bookmarks bar is visible for new tab page, New window, Private Window and Tor Window.
  • Verified Guest window will not have the bookmarks bar as the behavior is expected
  • Confirmed Always show bookmarks on the new tab page setting will be removed
step 5 New tab page New window Private window Tor window Guest window
image image image image image image

Case 2: Always option was set when bookmarks imported via brave://welcome - PASSED

  1. new profile
  2. launched Brave
  3. click Set Brave as default browser
  4. select Chrome >> Import
  5. select Chrome Person 1 >> Import profiles
  6. opened brave://settings/appearance in a new tab page
  • Confirmed Show bookmarks setting is set to Always in the brave://settings/appearance and it is expected behavior.
  • Confirmed bookmarks bar is visible with imported bookmarks shown on a new tab page
  • Confirmed the bookmarks bar is shown in the brave://settings/appearance page
step 4 step 5 step 8 result
image image image image

Case 3: Never option selected via Context menu - PASSED

  1. new profile
  2. Skip >> Skip >> Finish
  3. verified bookmarks bar is visible in the new tab page
  4. open context menu in the bookmarks bar
  5. click Show bookmarks flyout menu and only new tab page option is selected as expected
  6. select Never
  7. open a new tab page
  • Confirmed Show bookmarks bar in the context menu shows all 3 options Always, Never, Only on the new tab page.
  • Confirmed Never option was selected in the context menu and correct option is shown in brave://settings/appearance
  • Confirmed Bookbar is not visible in the new tab page
  • Confirmed the brave://settings/appearance page did NOT have the bookmarks bar
step 5 result result
image image image

Case 4: Only on the new tab page option selected via Hamburger menu - PASSED

  1. continued from Case 3
    • Bookmarks bar is not shown and Never was selected in the Show bookmarks setting
  2. clicked Hamburger menu >> Bookmarks >> Show bookmarks flyout menu
  3. selected Only on the new tab page
  4. open a new tab page
  • Confirmed Show bookmarks bar flyout menu shows all 3 options Always, Never, Only on the new tab page
  • Confirmed Only on the new tab page is selected in the Hamburger menu and is shown in brave://settings/appearance
  • Confirmed the brave://settings/appearance page did NOT have the bookmarks bar
step 1 step 2-3 result result
image image image image

Case 5: Select Never via brave://settings/appearance and import bookmarks via brave://settings/importData - PASSED

  1. new profile
  2. launched Brave
  3. Skip >> Skip >> Finish
  4. opened brave://settings/appearance on a new tab page
  5. select Never option in the Show bookmarks drop down menu
  6. opened brave://settings/importData in a new tab page
  7. selected Microsoft Edge Profile 2 >> Import
  8. verified Show bookmarks setting is enabled
  9. click Done
  10. opened a new tab page
  • Confirmed bookmarks bar is visible with bookmarks shown. Overriding setting from brave://settings/appearance which is the expected behavior.
step 4 - 5 step 6 -7 step 8 - 9 result
image image image image

Upgrade

Case 1: Default - Show bookmarks [Off], Always show bookmarks on new tab page [On] and when no bookmarks imported before upgrade - PASSED

  1. installed 1.48.171
  2. launched Brave
  3. Skip >> Skip >> Finish
  4. opened brave://settings/appearance in a new tab page
  5. leave the default option Show bookmarks setting to Off
  6. leave the default option Always show bookmarks on new tab page setting to On
  7. open a new tab page
  8. installed 1.49.107
  9. renamed Brave-Browser profile to Brave-Browser-Beta
  10. re launched Brave
  11. opened a new tab page, New window, Private Window and Tor Window, Guest window
  • Confirmed Show bookmarks setting has a drop down menu with three options Only on the new tab, Never and Always in the brave://settings/appearance
  • Confirmed Always show bookmarks on new tab page setting is no longer available.
  • Confirmed bookmarks bar is shown on the new tab page
  • Confirmed Only on the new tab is shown as default in the dropdown menu for Show bookmarks setting
  • Confirmed the brave://settings/appearance page did NOT have the bookmarks bar
  • Confirmed bookmarks bar is visible for New window, Private Window and Tor Window.
  • Verified Guest window will not have the bookmarks bar as the behavior is expected
step 1 step 4-6(1.48.171) step 7 result (1.49.107) result New Window Private window Tor window Guest window
image image image image image image image image image

Case 2: Show bookmarks [Off], Always show bookmarks on new tab page [On] and when bookmarks are imported before upgrade - PASSED

  1. installed 1.48.171
  2. launched Brave
  3. click Set Brave as default browser
  4. select Chrome >> Import
  5. select Chrome Person 1 >> Import profiles >> Finish
  6. opened brave://settings/appearance in a new tab page
  7. toggle Off Show bookmarks setting from existing On setting
  8. leave the default option Always show bookmarks on new tab page setting to On
  9. open a new tab page
  10. installed 1.49.107
  11. renamed Brave-Browser profile to Brave-Browser-Beta
  12. re-launched Brave
  • Confirmed Show bookmarks setting has a dropdown menu with three options Only on the new tab, Never and Always in the brave://settings/appearance
  • Confirmed Always show bookmarks on new tab page setting is no longer available.
  • Confirmed bookmarks bar is NOT shown on the new tab page
  • Confirmed Only on the new tab page is shown as default in the dropdown menu for Show bookmarks setting
step 4 step 5 step 6 result result result
image image image image image image

Case 3: Show bookmarks [On], Always show bookmarks on the new tab [On] when bookmarks are imported before upgrade

  1. installed 1.48.171
  2. launched Brave
  3. click Set Brave as default browser
  4. select Chrome Canary >> Import
  5. select Chrome Canary Person 1 & Chrome Canary Person 2 >> Import profiles >> Finish
  6. opened brave://settings/appearance in a new tab page
    7 Show bookmarks setting is set to On
  7. leave the default option Always show bookmarks on new tab page setting to On
  8. imported bookmarks are shown on all pages as expected
  9. open a new tab page
  10. installed 1.49.107
  11. renamed Brave-Browser profile to Brave-Browser-Beta
  12. re-launched Brave
  • Confirmed Show bookmarks setting is set to Always via context menu in the bookmarks bar
  • Confirmed brave://bookmarks page shows the bookmarks bar and all the tab pages
  • Confirmed bookmarks bar is shown on the new tab page same as before upgrade
step 1 step 5 step 7-8 step 8 result result result
image image image image image image image

Case 4: Show bookmarks [Off], Always show bookmarks on the new tab [Off] and when bookmarks are imported before upgrade

  1. installed 1.48.171
  2. launched Brave
  3. click Set Brave as default browser
  4. select Opera >> Import >> Finish
  5. bookmarks are shown on the bookmarks bar as expected
  6. opened brave://settings/appearance in a new tab page
  7. Set Show bookmarks setting to Off
  8. Set Always show bookmarks on new tab page' setting to Off`
  9. open a new tab page and no bookmarks shown as expected
  10. installed 1.49.107
  11. renamed Brave-Browser profile to Brave-Browser-Beta
  12. re-launched Brave
  • Confirmed Show bookmarks setting is set to Never via hamburger menu >> Bookmarks
  • Confirmed bookmarks bar is NOT shown on the new tab page and all the other tab pages
step 1 step 5 step 7-8 step 9 result result
image image image image image image

Case 5: Show bookmarks [On], Always show bookmarks on the new tab [off], when no bookmarks imported before upgrade - PASSED

  1. installed 1.48.171
  2. launched Brave
  3. Skip >> Skip >> Finish
  4. opened brave://settings/appearance in a new tab page
  5. Set Show bookmarks setting to On
  6. leave Always show bookmarks on new tab page' setting to Off`
  7. open a new tab page
  8. renamed Brave-Browser profile to Brave-Browser-Beta
  9. installed 1.49.118
  10. re-launched Brave
  • Confirmed bookmarks bar is shown on the new tab page
  • Confirmed Show bookmarks setting is set to Always in the brave://settings/appearance
  • Confirmed the brave://settings/appearance page shows the bookmarks bar
step 1 step 5-6 result result
image image image image

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 22, 2023
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Feb 27, 2023
Closed
@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 27, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 4, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
-- | --
Revision | 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS | Linux

New Install

Case 1: Default option set Only on the new tab page when no bookmarks imported via brave://welcome - PASSED

  1. installed 1.49.106
  2. launched Brave
  3. Skip >> Skip >> Finish
  4. opened brave://settings/appearance in a new tab page
  5. opened a new tab page, New window, Private Window and Tor Window & Guest window
  • Confirmed Show bookmarks setting has three options Only on the new tab, Never and Always in the brave://settings/appearance
  • Confirmed Only on the new tab is shown as default in the drop down menu for Show bookmarks setting
  • Confirmed Always show bookmarks on new tab page setting is no longer available.
  • Confirmed the brave://settings/appearance page did NOT have the bookmarks bar
  • Confirmed bookmarks bar is visible for new tab page, New window, Private Window and Tor Window.
  • Verified Guest window will not have the bookmarks bar as the behavior is expected
  • Confirmed Always show bookmarks on the new tab page setting will be removed
step 5 Default New tab page New window Private window Tor window Guest window
image image image image image image image

Case 2: Always option was set when bookmarks imported via brave://welcome - PASSED

  1. new profile
  2. launched Brave
  3. click Set Brave as default browser
  4. select Vivaldi >> Import
  5. click Finish
  6. opened brave://settings/appearance in a new tab page
  • Confirmed Show bookmarks setting is set to Always in the brave://settings/appearance and it is expected behavior.
  • Confirmed bookmarks bar is visible with imported bookmarks shown on a new tab page
  • Confirmed the bookmarks bar is shown in the brave://settings/appearance page
step 4 result result
image image image

Case 3: Never option selected via Context menu - PASSED

  1. new profile
  2. Skip >> Skip >> Finish
  3. verified bookmarks bar is visible in the new tab page
  4. open context menu in the bookmarks bar
  5. click Show bookmarks flyout menu to confirm only new tab page option is selected as expected
  6. select Never
  7. open a new tab page
  • Confirmed Show bookmarks bar in the context menu shows all 3 options Always, Never, Only on the new tab page.
  • Confirmed Never option was selected in the context menu and correct option is shown in brave://settings/appearance
  • Confirmed Bookbar is not visible in the new tab page
  • Confirmed the brave://settings/appearance page did NOT have the bookmarks bar
step 5 result result
image image image

Case 4: Only on the new tab page option selected via Hamburger menu - PASSED

  1. continued from Case 3
    • Bookmarks bar is not shown and Never was selected in the Show bookmarks setting
  2. clicked Hamburger menu >> Bookmarks >> Show bookmarks flyout menu
  3. selected Only on the new tab page
  4. open a new tab page
  • Confirmed Show bookmarks bar flyout menu shows all 3 options Always, Never, Only on the new tab page
  • Confirmed Only on the new tab page is selected in the Hamburger menu and is shown in brave://settings/appearance
  • Confirmed the brave://settings/appearance page did NOT have the bookmarks bar
step 1 result result result
image image image

Case 5: Select Never via brave://settings/appearance and import bookmarks via brave://settings/importData - PASSED

  1. new profile
  2. launched Brave
  3. Skip >> Skip >> Finish
  4. opened brave://settings/appearance on a new tab page
  5. select Never option in the Show bookmarks drop down menu
  6. opened brave://settings/importData in a new tab page
  7. selected Yandex User 1 - Apple >>Import`
  8. verified Show bookmarks setting is enabled
  9. click Done
  10. opened a new tab page
  • Confirmed bookmarks bar is visible with bookmarks shown. Overriding setting from brave://settings/appearance which is the expected behavior.
step 4 - 5 step 6 -7 step 8 - 9 result
image image image image

Upgrade

Case 1: Default - Show bookmarks [Off], Always show bookmarks on new tab page [On] and when no bookmarks imported before upgrade - PASSED

  1. installed 1.48.171
  2. launched Brave
  3. Skip >> Skip >> Finish
  4. opened brave://settings/appearance in a new tab page
  5. leave the default option Show bookmarks setting to Off
  6. leave the default option Always show bookmarks on new tab page setting to On
  7. open a new tab page
  8. installed 1.49.118
  9. renamed Brave-Browser profile to Brave-Browser-Beta
  10. re launched Brave
  11. opened a new tab page, New window, Private Window and Tor Window, Guest window
  • Confirmed Show bookmarks setting has a drop down menu with three options Only on the new tab, Never and Always in the brave://settings/appearance
  • Confirmed Always show bookmarks on new tab page setting is no longer available.
  • Confirmed bookmarks bar is shown on the new tab page
  • Confirmed Only on the new tab is shown as default in the drop down menu for Show bookmarks setting
  • Confirmed the brave://settings/appearance page did NOT have the bookmarks bar
  • Confirmed bookmarks bar is visible for New window, Private Window and Tor Window.
  • Verified Guest window will not have the bookmarks bar as the behavior is expected
step 1 step 3-4(1.48.171) step 6 result (1.49.107) result New Window Private window Tor window Guest window
image image image image image image image image image

Case 2: Show bookmarks [Off], Always show bookmarks on new tab page [On] and when bookmarks are imported before upgrade - PASSED

  1. installed 1.48.171
  2. launched Brave
  3. click Set Brave as default browser
  4. select Vivaldi >> Import >> Finish
  5. opened brave://settings/appearance in a new tab page
  6. toggle off Show bookmarks setting from On
  7. leave the default option Always show bookmarks on new tab page setting to On
  8. open a new tab page
  9. installed 1.49.118
  10. renamed Brave-Browser profile to Brave-Browser-Beta
  11. re-launched Brave
  • Confirmed Show bookmarks setting has a dropdown menu with three options Only on the new tab, Never and Always in the brave://settings/appearance
  • Confirmed Only on the new tab is shown as default in the dropdown menu for Show bookmarks setting
  • Confirmed bookmarks bar is shown on the new tab page
  • Confirmed Always show bookmarks on new tab page setting is no longer available.
  • Confirmed the bookmarks bar is NOT shown in the brave://settings/appearance page
step 4 step 6-7 result result result
image image image image image

Case 3: Show bookmarks [On], Always show bookmarks on the new tab [On] when bookmarks are imported before upgrade

  1. installed 1.48.171
  2. launched Brave
  3. click Set Brave as default browser
  4. select Vivaldi >> Import >> Finish
  5. opened brave://settings/appearance in a new tab page
    6 Show bookmarks setting is set to On
  6. leave the default option Always show bookmarks on new tab page setting to On
  7. imported bookmarks are shown on all pages as expected
  8. open a new tab page
  9. installed 1.49.118
  10. renamed Brave-Browser profile to Brave-Browser-Beta
  11. re-launched Brave
  • Confirmed Show bookmarks setting is set to Always via context menu in the bookmarks bar
  • Confirmed brave://bookmarks page shows the bookmarks bar and all the tab pages
  • Confirmed bookmarks bar is shown on the new tab page same as before upgrade
step 4 step 6-7 step 8 result result result
image image image image image image

Case 4: Show bookmarks [Off], Always show bookmarks on the new tab [Off] and when bookmarks are imported before upgrade

  1. installed 1.48.171
  2. launched Brave
  3. click Set Brave as default browser
  4. select Vivaldi >> Import >> Finish
  5. bookmarks are shown on the bookmarks bar as expected
  6. opened brave://settings/appearance in a new tab page
  7. Set Show bookmarks setting to Off
  8. Set Always show bookmarks on new tab page' setting to Off`
  9. open a new tab page and no bookmarks shown as expected
  10. installed 1.49.118
  11. renamed Brave-Browser profile to Brave-Browser-Beta
  12. re-launched Brave
  • Confirmed Show bookmarks setting is set to Never via hamburger menu >> Bookmarks
  • Confirmed bookmarks bar is NOT shown on the new tab page and all the other tab pages
step 4 step 5 step 7-8 result result
image image image image image

Case 5: Show bookmarks [On], Always show bookmarks on the new tab [off], when no bookmarks imported before upgrade - PASSED

  1. installed 1.48.171
  2. launched Brave
  3. Skip >> Skip >> Finish
  4. opened brave://settings/appearance in a new tab page
  5. Set Show bookmarks setting to On
  6. leave Always show bookmarks on new tab page' setting to Off`
  7. open a new tab page
  8. installed 1.49.118
  9. renamed Brave-Browser profile to Brave-Browser-Beta
  10. re-launched Brave
  • Confirmed bookmarks bar is shown on the new tab page
  • Confirmed Show bookmarks setting is set to Always in the brave://settings/appearance
  • Confirmed the brave://settings/appearance page shows the bookmarks bar
step 4 step 5-6 step 7 result result
image image image image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 6, 2023
@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
@dgealow dgealow mentioned this issue May 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/new-tab feature/settings OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

Update show bookmarks setting brave/brave-core
5 participants
@stephendonner @spylogsster @rebron @LaurenWags @MadhaviSeelam