Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR 107 - Remove chrome icon in autofill suggest #26089

Closed
rebron opened this issue Oct 18, 2022 · 4 comments · Fixed by brave/brave-core#15526
Closed

CR 107 - Remove chrome icon in autofill suggest #26089

rebron opened this issue Oct 18, 2022 · 4 comments · Fixed by brave/brave-core#15526

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 18, 2022

Description

Autofill for passwords shows Chrome icon. This is coming from Chromium 107 update. There should be no icon here.

Screenshot 2022-10-17 at 6 18 08 PM

Steps to Reproduce

  1. Go to a site that has a password that will autofill and invoke autofill dropdown.
  2. Notice Chrome icon.

Actual result:

See description.

Expected result:

No icon.

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Brave 1.46.64 Chromium: 107.0.5304.36 (Official Build) nightly (arm64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 13.0 (Build 22A5342f)
JavaScript V8 10.7.193.13
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36
  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron added OS/Desktop feature/autofill branding QA/Yes release-notes/exclude priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 18, 2022
@GeetaSarvadnya
Copy link

Reproduce the issue in Windows 10 x64 - 1.46.64 - @rebron Good catch
image

@kjozwiak
Copy link
Member

The above requires 1.45.108 or higher for 1.45.x verification 👍

@stephendonner
Copy link

Verified PASSED using

Brave 1.45.108 Chromium: 107.0.5304.36 (Official Build) (x86_64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 11.7 (Build 20G817)

Steps:

  1. installed 1.45.108
  2. launched Brave
  3. loaded facebook.com
  4. entered username and password information
  5. clicked on Save
  6. relaunched Brave
  7. loaded facebook.com

Confirmed the "gears" icon has replaced the Chrome/Chromium icon

Screen Shot 2022-10-20 at 9 24 21 AM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 20, 2022

Verification PASSED using

Brave | 1.45.108 Chromium: 107.0.5304.36 (Official Build) (64-bit)
-- | --
Revision | 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS | Windows 11 Version 21H2 (Build 22000.1098)

Verified using original STR from description

Confirmed chrome icon longer displayed and gear icon is replaced.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants