Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dialog for blocking cookie consent banners #26203

Closed
rebron opened this issue Oct 24, 2022 · 5 comments
Closed

Show dialog for blocking cookie consent banners #26203

rebron opened this issue Oct 24, 2022 · 5 comments
Labels
feature/cookies OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 24, 2022

Description

Show dialog for blocking cookie consent banners.
Follow-up to #10433
Managed by BraveAdblockCookieListOptInStudy:Enabled, griffin variation study.

Expected result:

Use 1.45.111 and higher. For new users, users will see the dialog on second launch of Brave. For existing users, they will see the dialog upon upgrade to 1.45.x

Brave version (brave://version info)

1.45.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. feature/cookies OS/Desktop QA/Yes release-notes/include labels Oct 24, 2022
@rebron rebron added this to the 1.45.x - Release milestone Oct 24, 2022
@LaurenWags LaurenWags added QA/No and removed QA/Yes labels Oct 24, 2022
@LaurenWags
Copy link
Member

Changing to QA/No as this was verified by @kjozwiak extensively when checking griffin study.

@LaurenWags
Copy link
Member

closed per discussion with @kjozwiak @rebron

@StrangePeanut
Copy link

Just upgraded Version 1.45.113 Chromium: 107.0.5304.62 (Official Build) (64-bit) and not seeing any dialogue. There also doesn't seem to be any option for it in the settings. How to enable this feature?

@StrangePeanut
Copy link

Found Easylist-Cookie List - Filter Obtrusive Cookie Notices on brave://settings/shields/filters but unsure if this is the same thing?

@LaurenWags
Copy link
Member

Hi @StrangePeanut,

This dialog has a phased release, so it's being rolled out to all users over the next week or so via our variations service, Griffin.

If you're keen to try it right away, yes, you can enable "Easylist-Cookie List - Filter Obtrusive Cookie Notices" under brave://settings/shields/filters now. The dialog just enables this filter list for you if you opt-in. I believe if you enable this filter manually you won't get the dialog asking to enable when it is rolled out - so you should be good right away.

If you'd rather wait, it should only be about a week or so until this feature is rolled out 100%, but you could get it sooner. See the Griffin link above for more information.

Thanks for asking about this!

cc @rebron @kjozwiak for any information I might have missed/additional clarifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/cookies OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
None yet
Development

No branches or pull requests

3 participants