Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dialog to surface the setting for blocking cookie consent banners #10433

Closed
fmarier opened this issue Jun 23, 2020 · 4 comments · Fixed by brave/brave-core#14148
Closed

Add dialog to surface the setting for blocking cookie consent banners #10433

fmarier opened this issue Jun 23, 2020 · 4 comments · Fixed by brave/brave-core#14148
Assignees
@zenparsing
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.44.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Jun 23, 2020 •
edited by rebron
Loading

Description

We have received complaints from users about having to click through cookie consent banners related to real-time bidding. We should offer a global setting (default OFF) in Shields which would:

  1. Automatically deny all data sharing (like the option that's available in the Cliqz browser and can be verified using the re:consent extension) in first-party consent manager platforms which follow the IAB protocol.
  2. Hide banners using the Easylist-Cookie cosmetic filters.

We could surface that setting the first time a user encounters a cookie banner via a notification.

Alternatively, instead of a new global setting, we could tie this feature to the existing "aggressive mode" blocking option.

Design

Figma link: https://www.figma.com/file/cL22PpqneTYxJePORxUBKz/Cookie-consent-blocker?node-id=61%3A16268
@pes10k pes10k added the priority/P4 Planned work. We expect to get to it "soon". label Jul 21, 2020
@Brave-Matt Brave-Matt mentioned this issue Jul 26, 2021
Open
@Tonev Tonev mentioned this issue Sep 3, 2021
Closed
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 9, 2021
@pes10k pes10k mentioned this issue Jun 1, 2022
Closed
@zenparsing zenparsing mentioned this issue Jul 13, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 5, 2022
@zenparsing zenparsing mentioned this issue Aug 12, 2022
Closed
7 tasks
@rebron rebron changed the title Add a setting to block cookie banners Add dialog to surface the setting for blocking cookie consent banners Aug 25, 2022
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 1, 2022
@stephendonner
Copy link

stephendonner commented Sep 1, 2022 •
edited
Loading

Verification PASSED using

Brave 1.44.71 Chromium: 105.0.5195.68 (Official Build) dev (x86_64)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS macOS Version 13.0 (Build 22A5331f)

Steps:

Case One: New profiles - PASSED

  1. Start browser with a new profile.
  2. Enable the flag "Show an opt-in bubble for the 'Easylist-Cookie List' filter".
  3. Restart the browser.
  4. Wait for first page load.
  5. Verify that the "cookie list opt-in" bubble is displayed.
  6. Click the "enable" button.
  7. Verify that the bubble is closed after the animation completes.
  8. Navigate to brave://adblock.
  9. Expand the list of filters, and verify that the "Cookie List" filter has been enabled.
  10. Visit another page and verify that the opt-in bubble is not displayed again.
  11. Restart the browser and verify that the opt-in bubble is not displayed again.
step 2 step 5 steps 6-7 step 9 step 10 step 11
Screenshot 2022-09-01 at 2 41 20 PM Screenshot 2022-09-01 at 2 41 11 PM Screenshot 2022-09-01 at 2 41 20 PM Screenshot 2022-09-01 at 2 46 12 PM Screenshot 2022-09-01 at 2 47 21 PM Screenshot 2022-09-01 at 2 48 08 PM

Case Two: Clicking the X - PASSED

  1. Start browser with a new profile.
  2. Enable the flag "Show an opt-in bubble for the 'Easylist-Cookie List' filter".
  3. Restart the browser.
  4. Wait for first page load.
  5. Click the "X" button to close the bubble.
  6. Visit another page and verify that the opt-in bubble is not displayed again.
  7. Restart the browser and verify that the opt-in bubble is not displayed again.
step 2 step 5 steps 6 step 7
Screenshot 2022-09-01 at 2 59 08 PM Screenshot 2022-09-01 at 2 59 02 PM Screenshot 2022-09-01 at 3 21 07 PM Screenshot 2022-09-01 at 3 21 20 PM

Case Three: Closing the bubble - PASSED

  1. Start browser with a new profile.
  2. Enable the flag "Show an opt-in bubble for the 'Easylist-Cookie List' filter".
  3. Restart the browser.
  4. Wait for first page load.
  5. Click outside of the bubble to close the bubble.
  6. Visit another page and verify that the opt-in bubble is not displayed again.
  7. Restart the browser and verify that the opt-in bubble is not displayed again.
step 2 step 5 step 6 step 7
Screenshot 2022-09-01 at 3 35 33 PM Screenshot 2022-09-01 at 3 33 34 PM Screenshot 2022-09-01 at 3 33 50 PM Screenshot 2022-09-01 at 3 34 05 PM

Case Four: No thanks - PASSED

  1. Start browser with a new profile.
  2. Enable the flag "Show an opt-in bubble for the 'Easylist-Cookie List' filter".
  3. Restart the browser.
  4. Wait for first page load.
  5. Click on No thanks
  6. Confirm the dialog dismisses
  7. Visit another page and verify that the opt-in bubble is not displayed again.
  8. Restart the browser and verify that the opt-in bubble is not displayed again.
step 2 step 5 step 6 step 7 step 8
Screenshot 2022-09-01 at 3 24 13 PM Screenshot 2022-09-01 at 3 26 49 PM Screenshot 2022-09-01 at 3 26 58 PM Screenshot 2022-09-01 at 3 30 06 PM Screenshot 2022-09-01 at 3 30 56 PM

@stephendonner stephendonner added QA Pass-macOS QA/Test-Plan-Specified and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 1, 2022
@MadhaviSeelam
Copy link

Verification PASSED with

Brave | 1.44.79 Chromium: 105.0.5195.102 (Official Build) beta (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.856)

Steps:

Case One: New profiles - PASSED

  1. Start browser with a new profile.
  2. Enable the flag "Show an opt-in bubble for the 'Easylist-Cookie List' filter".
  3. Restart the browser.
  4. Wait for first page load.
  5. Verify that the "cookie list opt-in" bubble is displayed.
  6. Click the "enable" button.
  7. Verify that the bubble is closed after the animation completes.
  8. Navigate to brave://adblock.
  9. Expand the list of filters, and verify that the "Cookie List" filter has been enabled.
  10. Visit another page (digikey.com) and verify that the opt-in bubble is not displayed again.
  11. Confirmed cookie consent banner is blocked
  12. Restart the browser and verify that the opt-in bubble is not displayed again.
step 2 step 5-6 steps 7 step 8-9 step 10 step 11 step 12
image image image image image image image

Case Two: Clicking the X - PASSED

  1. Start browser with a new profile.
  2. Enable the flag "Show an opt-in bubble for the 'Easylist-Cookie List' filter".
  3. Restart the browser.
  4. Wait for first page load.
  5. Click the "X" button to close the bubble.
  6. Visit another page (lemonde.fr) and verify that the opt-in bubble is not displayed again.
  7. Cookie consent banner is not blocked
  8. Restart the browser and verify that the opt-in bubble is not displayed again.
step 2 step 5 steps 6-7 step 8
image image image image

Case Three: Closing the bubble - PASSED

  1. Start browser with a new profile.
  2. Enable the flag "Show an opt-in bubble for the 'Easylist-Cookie List' filter".
  3. Restart the browser.
  4. Wait for first page load.
  5. Click outside of the bubble to close the bubble.
  6. Cookie List" filter has not been enabled in brave://adblock
  7. Visit a site (gulfnews.com) and verify that the opt-in bubble is not displayed again.
  8. Cookie consent banner is not blocked
  9. Restart the browser and verify that the opt-in bubble is not displayed again.
step 2 step 5 step 6 step 7-8 step 9
image image image image image

Case Four: No thanks - PASSED

  1. Start browser with a new profile.
  2. Enable the flag "Show an opt-in bubble for the 'Easylist-Cookie List' filter".
  3. Restart the browser.
  4. Wait for first page load.
  5. Click on No thanks
  6. Confirm the dialog dismisses
  7. Visit another page and verify that the opt-in bubble is not displayed again.
  8. Cookie List" filter has not been enabled in brave://adblock
  9. Restart the browser and verify that the opt-in bubble is not displayed again.
step 2 step 5 step 6-7 step 8 step 9
image image image image image

Case Five : Upgrade - PASSED

  1. installed 1.43.89
  2. launch Brave
  3. visit lemonde.fr, which has cookie consent banner displayed, and close the browser
  4. rename the profile folder to Beta
  5. install 1.44.79
  6. launch Brave
  7. Enable the flag "Show an opt-in bubble for the 'Easylist-Cookie List' filter".
  8. Restart the browser.
  9. Wait for first page load.
  10. Verify that the "cookie list opt-in" bubble is displayed.
  11. Click the "enable" button.
  12. Verify that the bubble is closed after the animation completes.
  13. Navigate to brave://adblock.
  14. Expand the list of filters, and verify that the "Cookie List" filter has been enabled.
  15. return to another page (lemonde.fr) and verify that the opt-in bubble is not displayed again.
  16. Confirmed cookie consent banner is blocked
  17. Restart the browser and verify that the opt-in bubble is not displayed again.
step1-2 step 3 step 7 step10 step 12 step13-14 step15-16 step 17
image image image image image image image image

@stephendonner
Copy link

stephendonner commented Sep 16, 2022 •
edited
Loading

Verification PASSED using

Brave 1.44.88 Chromium: 105.0.5195.136 (Official Build) beta (64-bit)
Revision 872774b783d0e674186a3adcd2f92e7aa22a219c-refs/branch-heads/5195_124@{#4}
OS Linux

Steps:

Case One: New profiles - PASSED

  1. Start browser with a new profile.
  2. Enable the flag Show an opt-in bubble for the "Easylist-Cookie List" filter.
  3. Restart the browser.
  4. Wait for first page load.
  5. Verify that the "cookie list opt-in" bubble is displayed.
  6. Click on Yes, block cookie consent notices
  7. Verify that the bubble is closed after the animation completes.
  8. Navigate to brave://adblock.
  9. Expand the list of filters, and verify that the Cookie List filter has been enabled.
  10. Visit another page and verify that the opt-in bubble is not displayed again.
  11. Restart the browser and verify that the opt-in bubble is not displayed again.
steps 2-5 steps 6-7 step 9 step 10 step 11
Screen Shot 2022-09-16 at 2 53 15 PM Screen Shot 2022-09-16 at 2 46 15 PM Screen Shot 2022-09-16 at 2 50 13 PM Screen Shot 2022-09-16 at 2 50 27 PM Screen Shot 2022-09-16 at 2 51 00 PM

Case Two: Clicking the X - PASSED

  1. Start browser with a new profile.
  2. Enable the flag Show an opt-in bubble for the "Easylist-Cookie List" filter.
  3. Restart the browser.
  4. Wait for first page load.
  5. Click the "X" button to close the bubble.
  6. Visit another page and verify that the opt-in bubble is not displayed again.
  7. Restart the browser and verify that the opt-in bubble is not displayed again.
step 2 step 5 steps 6 step 7
Screen Shot 2022-09-16 at 2 53 15 PM Screen Shot 2022-09-16 at 2 57 46 PM Screen Shot 2022-09-16 at 2 58 05 PM Screen Shot 2022-09-16 at 2 58 23 PM

Case Three: Closing the bubble - PASSED

  1. Start browser with a new profile.
  2. Enable the flag Show an opt-in bubble for the "Easylist-Cookie List" filter.
  3. Restart the browser.
  4. Wait for first page load.
  5. Click outside of the bubble to close the bubble.
  6. Visit another page and verify that the opt-in bubble is not displayed again.
  7. Restart the browser and verify that the opt-in bubble is not displayed again.
step 2 step 5 step 6 step 7
Screen Shot 2022-09-16 at 2 58 12 PM Screen Shot 2022-09-16 at 3 01 17 PM Screen Shot 2022-09-16 at 3 01 35 PM Screen Shot 2022-09-16 at 3 01 46 PM

Case Four: No thanks - PASSED

  1. Start browser with a new profile.
  2. Enable the flag Show an opt-in bubble for the "Easylist-Cookie List" filter.
  3. Restart the browser.
  4. Wait for first page load.
  5. Click on No thanks
  6. Confirm the dialog dismisses
  7. Visit another page and verify that the opt-in bubble is not displayed again.
  8. Restart the browser and verify that the opt-in bubble is not displayed again.
step 2 step 5 step 6 step 7 step 8
Screen Shot 2022-09-16 at 3 04 28 PM Screen Shot 2022-09-16 at 3 04 20 PM Screen Shot 2022-09-16 at 3 06 18 PM Screen Shot 2022-09-16 at 3 04 41 PM Screen Shot 2022-09-16 at 3 05 07 PM

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 16, 2022
@stephendonner stephendonner added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 16, 2022
This was referenced Sep 27, 2022
Closed
Merged
@LaurenWags
Copy link
Member

Changing to release-notes/exclude per discussion with @kjozwiak and @rebron .

@kjozwiak kjozwiak mentioned this issue Sep 29, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Oct 21, 2022
Merged
@rebron rebron mentioned this issue Oct 24, 2022
Closed
@rebron rebron mentioned this issue Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

Add bubble for enabling cookie consent blocking brave/brave-core
8 participants
@pes10k @fmarier @stephendonner @rebron @zenparsing @LaurenWags @brave-builds @MadhaviSeelam