Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bubble for enabling cookie consent blocking (uplift to 1.43.x) #14602

Closed
wants to merge 2 commits into from

Conversation

zenparsing
Copy link
Collaborator

Manual uplift of #14148
Fixes brave/brave-browser#10433

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@zenparsing zenparsing added this to the 1.43.x - Beta milestone Aug 12, 2022
@zenparsing zenparsing requested a review from a team as a code owner August 12, 2022 12:57
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Aug 12, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak
Copy link
Member

Closing as per the discussion with @rebron in the b-b meeting. We'll leave this in 1.44.x and enable it on Nightly via Griffin so we can start getting some bake time/feedback from 1.44.x. @zenparsing will create the Griffin issue to enable it 100% on Nightly.

@kjozwiak kjozwiak closed this Aug 16, 2022
@kjozwiak kjozwiak deleted the cookielist-optin-1.43.x branch August 16, 2022 18:20
@kjozwiak kjozwiak removed the request for review from a team August 16, 2022 18:20
@kjozwiak kjozwiak removed this from the 1.43.x - Beta milestone Aug 16, 2022
@kjozwiak kjozwiak removed potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false CI/storybook-url Deploy storybook and provide a unique URL for each build labels Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants