Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android to BraveAdblockCookieListOptInStudy on main #377

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm self-assigned this Sep 26, 2022
@antonok-edm antonok-edm requested a review from a team as a code owner September 26, 2022 18:28
@kjozwiak kjozwiak merged commit 2997c4f into main Sep 26, 2022
@kjozwiak kjozwiak deleted the cookielist-opt-android-main branch September 26, 2022 18:33
@kjozwiak
Copy link
Member

kjozwiak commented Sep 27, 2022

Used #329 (comment) as the template for the below verification on Desktop & Android. QA also verified the Cookie Consent modal via brave/brave-browser#10433 (comment), brave/brave-browser#10433 (comment) and brave/brave-browser#10433 (comment) on 1.44.x.

@kjozwiak
Copy link
Member

kjozwiak commented Sep 27, 2022

Desktop verifications

Nightly channel

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.46.14 Chromium: 106.0.5249.61 (Official Build) nightly (64-bit)
-- | --
Revision | 511755355844955cd3e264779baf0dd38212a4d0-refs/branch-heads/5249@{#569}
OS | Windows 11 Version 22H2 (Build 22621.521)
  • launched 1.46.14 Chromium: 106.0.5249.61 using the following switches via the terminal/CLI:
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • restarted the browser using once again using the above switches
  • ensured that BraveAdblockCookieListOptInStudy:Enabled via brave://version
  • ensured that the cookie consent modal/bubble appears without any issues
  • ensured that clicking on either No Thanks or X doesn't enable the Easylist-Cookie List filter
    • checked via brave://settings/shields/filters to ensure that the filter was disabled
  • ensured that clicking on Yes, block cookie consent notices enables Easylist-Cookie List
    • ensured that an animation occurs and verified it doesn't cause any obvious issues
    • checked via brave://settings/shields/filters to ensure that the filter was enabled
  • ensured that a cookie consent message isn't being displayed via https://www.bild.de when filter has been enabled
Example Example Example
studyEnabled modalVisible filterEnabled

BETA channel

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.45.74 Chromium: 106.0.5249.55 (Official Build) beta (64-bit)
-- | --
Revision | 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS | Windows 11 Version 22H2 (Build 22621.521)
  • launched 1.45.74 Chromium: 106.0.5249.55 using the following switches via the terminal/CLI:
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • restarted the browser using once again using the above switches
  • ensured that BraveAdblockCookieListOptInStudy doesn't appear via brave://version
  • ensured that the cookie consent modal isn't being displayed once the browser is restarted twice

image

Release channel

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.43.93 Chromium: 105.0.5195.127 (Official Build) (64-bit)
-- | --
Revision | 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS | Windows 11 Version 22H2 (Build 22621.521)
  • launched 1.43.93 Chromium: 105.0.5195.127 using the following switches via the terminal/CLI:
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • restarted the browser using once again using the above switches
  • ensured that BraveAdblockCookieListOptInStudy doesn't appear via brave://version
  • ensured that the cookie consent modal isn't being displayed once the browser is restarted twice

image

@kjozwiak
Copy link
Member

Android verifications

Nightly channel

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.46.15 Chromium: 106.0.5249.65 (Official Build) canary (32-bit)
--- | ---
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Android 13; Build/T1B1.220819.006

Using brave/brave-core#10408 (comment) to enable/use the Griffin staging server on Android, went through the following verifications:

image

  • launched 1.46.15 Chromium: 106.0.5249.65
  • restarted the browser using once again using the above switches
  • ensured that BraveAdblockCookieListOptInStudy:Enabled via brave://version
  • ensured that the cookie consent modal/bubble appears without any issues after visiting five websites
    • refreshed the same one 5 times to speed things up (ensured that the modal is appearing on the 6th load)
  • ensured that clicking on either No Thanks doesn't enable the Easylist-Cookie List filter
    • checked via brave://adblock to ensure that the filter was disabled
  • ensured that clicking on Block cookie notices enables Easylist-Cookie List
    • checked via brave://adblock to ensure that the filter was enabled

Enabling via Block cookie notices

Example Example Example Example
Screenshot_20220927-125823 Screenshot_20220927-125843 Screenshot_20220927-125904 Screenshot_20220927-133118

Declining via No thanks

Example Example Example Example
Screenshot_20220927-132224 Screenshot_20220927-132434 Screenshot_20220927-132323 Screenshot_20220927-132942

BETA channel

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (32-bit)
--- | ---
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Android 13; Build/T1B1.220819.006
  • launched 1.45.75 Chromium: 106.0.5249.65
  • restarted the browser using once again using the above switches
  • ensured that BraveAdblockCookieListOptInStudy doesn't appear via brave://version
  • ensured that the cookie consent modal isn't being displayed once a website has been refreshed 5 times
Example Example
Screenshot_20220927-133558 Screenshot_20220927-133610

Release channel

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.44.101 Chromium: 106.0.5249.65 (Official Build) (32-bit)
--- | ---
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Android 13; Build/T1B1.220819.006
  • launched `1.44.101 Chromium: 106.0.5249.65
  • restarted the browser using once again using the above switches
  • ensured that BraveAdblockCookieListOptInStudy doesn't appear via brave://version
  • ensured that the cookie consent modal isn't being displayed once a website has been refreshed 5 times
Example Example
Screenshot_20220927-134034 Screenshot_20220927-134050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants