Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Cookie-List opt-in bubble to Nightly #329

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Conversation

zenparsing
Copy link
Contributor

Enables the "Cookie List" opt-in bubble on Nightly, which invites the user to enable the "Cookie List" adblock filter to hide cookie consent notices.

@zenparsing zenparsing requested a review from a team as a code owner August 17, 2022 21:55
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 4a6d3ee into main Aug 18, 2022
@bsclifton bsclifton deleted the ksmith-cookielist-nightly branch August 18, 2022 06:53
@kjozwiak
Copy link
Member

Verification FAILED on Win 11 x64 using the following build(s):

Brave | 1.44.53 Chromium: 104.0.5112.102 (Official Build) nightly (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Windows 11 Version 21H2 (Build 22000.856)
  • launch Brave (new profile) using the following command:
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • re-launched browser and ensured that BraveAdblockCookieListOptInStudy:Enabled via brave://version

Once the above was done, I wanted to make sure that the Easylist-Cookie List wasn't enabled via brave://settings/shields/filters. However, it looks it gets enabled and the modal/bubble never appears.

Examples Examples
versionEnabled1 versionEnabled2

@kjozwiak
Copy link
Member

kjozwiak commented Aug 20, 2022

Desktop Cases/Verifications

Nightly channel

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.44.53 Chromium: 104.0.5112.102 (Official Build) nightly (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Windows 11 Version 21H2 (Build 22000.856)
  • launched 1.44.53 Chromium: 104.0.5112.102 using the following switches via the terminal/CLI:
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • restarted the browser using once again using the above switches
  • ensured that BraveAdblockCookieListOptInStudy:Enabled via brave://version
  • ensured that the cookie consent modal/bubble appears without any issues
  • ensured that clicking on either No Thanks or X doesn't enable the Easylist-Cookie List filter
    • checked via brave://settings/shields/filters to ensure that the filter was disabled
  • ensured that clicking on Yes, block cookie consent notices enables Easylist-Cookie List
    • ensured that an animation occurs and verified it doesn't cause any obvious issues
    • checked via brave://settings/shields/filters to ensure that the filter was enabled
  • ensured that a cookie consent message is being displayed via https://www.bild.de

Video example of the feature

Welcome.to.Brave.-.Brave.2022-08-20.01-56-23.mp4
Example Example
cookieModal1 cookieModal2

BETA channel

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.43.76 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Windows 11 Version 21H2 (Build 22000.856)
  • launched 1.43.76 Chromium: 104.0.5112.102 using the following switches via the terminal/CLI:
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • restarted the browser using once again using the above switches
  • ensured that BraveAdblockCookieListOptInStudy doesn't appear via brave://version
  • ensured that the cookie consent modal isn't being displayed once the browser is restarted twice

betaCookie

Release channel

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.42.97 Chromium: 104.0.5112.102 (Official Build) (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Windows 11 Version 21H2 (Build 22000.856)
  • launched 1.42.97 Chromium: 104.0.5112.102 using the following switches via the terminal/CLI:
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • restarted the browser using once again using the above switches
  • ensured that BraveAdblockCookieListOptInStudy doesn't appear via brave://version
  • ensured that the cookie consent modal isn't being displayed once the browser is restarted twice

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants