Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News feed auto-discovery within search appears broken #26550

Closed
stephendonner opened this issue Nov 4, 2022 · 3 comments · Fixed by brave/brave-core#15775
Closed

Brave News feed auto-discovery within search appears broken #26550

stephendonner opened this issue Nov 4, 2022 · 3 comments · Fixed by brave/brave-core#15775

Comments

@stephendonner
Copy link

Description

Brave News feed auto-discovery within search appears broken

Steps to Reproduce

  1. install 1.47.42
  2. launch Brave
  3. set brave://flags/#brave-news-v2 and brave://flags/#brave-news-subscribe-button to Enabled
  4. click Relaunch
  5. open a new-tab page
  6. click on Customize
  7. click on Brave News
  8. click on Turn on Brave News
  9. under Discover, enter https://www.pravda.com.ua/eng/
  10. when Sources pops up with Get feeds from... click it
  11. wait

Actual result:

No feeds found at https://www.pravda.com.ua/eng/

Screen Shot 2022-11-04 at 11 25 32 AM

Expected result:

I'd think it should show the 8 feeds which show up in the URL bar, when you loaded https://www.pravda.com.ua/eng/

example example
Screen Shot 2022-11-04 at 11 30 16 AM Screen Shot 2022-11-04 at 11 31 13 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.47.42 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

/cc @mattmcalister @fallaciousreasoning @petemill

@kjozwiak
Copy link
Member

kjozwiak commented Nov 9, 2022

The above requires 1.46.102 or higher for 1.46.x verification 👍

@stephendonner
Copy link
Author

stephendonner commented Nov 10, 2022

NOTE: I spun the original issue here off into #26676, as search auto-discovery was broken even for planet.mozilla.org, with which it now works 👍 That issue can cover the multiple-feed sources scenario which seems to be why it's broken for pravda.com.ua.

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.46.103 Chromium: 107.0.5304.110 (Official Build) beta (x86_64)
Revision 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS macOS Version 13.1 (Build 22C5044e)

Steps:

  1. install 1.46.103
  2. launch Brave
  3. set brave://flags/#brave-news-v2 and brave://flags/#brave-news-subscribe-button to Enabled
  4. click Relaunch
  5. open a new-tab page
  6. click on Customize
  7. click on Brave News
  8. click on Turn on Brave News
  9. under Discover, enter planet.mozilla.org
  10. when Sources pops up with Get feeds from... click it

Confirmed I can search for, find, follow, and see articles from the Planet Mozilla feed

example example example example example
Screenshot 2022-11-10 at 15 42 23 Screenshot 2022-11-10 at 15 42 30 Screenshot 2022-11-10 at 15 42 44 Screenshot 2022-11-10 at 15 42 52 Screenshot 2022-11-10 at 15 43 47

cc @MadhaviSeelam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment