Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shield icon is disabled when browser is newly launched #1202

Closed
simonhong opened this issue Sep 20, 2018 · 3 comments · Fixed by brave/brave-extension#64
Closed

Shield icon is disabled when browser is newly launched #1202

simonhong opened this issue Sep 20, 2018 · 3 comments · Fixed by brave/brave-extension#64
Assignees
@simonhong
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@simonhong
Copy link
Member

Description

Shield icon is disabled when browser is newly launched

Steps to Reproduce

  1. Launch browser and create only one tab with www.google.com
  2. Change On startup setting to Continue where you left off
  3. Close browser
  4. Launch browser

Actual result:

Shield icon is in disabled state

Expected result:

Shield icon is in enabled state

Reproduces how often:

100% on MacOS

Brave version (chrome://version info)

0.55.2 Chromium: 70.0.3538.16 (Developer Build) (64-bit)

Reproducible on current release:

Yes, tested on MacOS

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information
@simonhong simonhong self-assigned this Sep 20, 2018
@simonhong simonhong mentioned this issue Sep 20, 2018
Merged
@srirambv
Copy link
Contributor

Same as #505?

@simonhong
Copy link
Member Author

@srirambv Oh, this seems same scenario as #505 (comment) describes

@petemill petemill added this to the Releasable builds 0.55.x milestone Sep 20, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 22, 2018 •
edited by LaurenWags
Loading

Verification PASSED on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verified passed with:

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added the QA/Yes label Sep 27, 2018
This was referenced Nov 10, 2022
Closed
Closed
Closed
Closed
@MadhaviSeelam MadhaviSeelam mentioned this issue Nov 11, 2022
Closed
This was referenced Nov 11, 2022
Closed
Open
Closed
@Andres3d Andres3d mentioned this issue Nov 13, 2022
Open
@tocic tocic mentioned this issue Nov 14, 2022
Closed
This was referenced Nov 14, 2022
Closed
Closed
@btlechowski btlechowski mentioned this issue Nov 15, 2022
Closed
49 tasks
@AlmightyLks AlmightyLks mentioned this issue Nov 16, 2022
Open
@Nihal-Raj Nihal-Raj mentioned this issue Nov 16, 2022
Open
@differentiaI differentiaI mentioned this issue Nov 17, 2022
Open
@btlechowski btlechowski mentioned this issue Nov 17, 2022
Closed
@btlechowski btlechowski mentioned this issue Nov 22, 2022
Closed
27 tasks
@btlechowski btlechowski mentioned this issue Nov 29, 2022
Closed
@saintmalik saintmalik mentioned this issue Dec 30, 2022
Closed
@mcaay mcaay mentioned this issue Jan 5, 2023
Open
This was referenced Mar 22, 2023
Closed
Closed
Closed
Closed
@stephendonner stephendonner mentioned this issue Mar 22, 2023
Closed
@ichiKD ichiKD mentioned this issue Mar 24, 2023
Closed
@alexventuraio alexventuraio mentioned this issue Mar 25, 2023
Open
@6d7a 6d7a mentioned this issue Mar 27, 2023
Closed
@btlechowski btlechowski mentioned this issue Mar 28, 2023
Closed
@franzhcs franzhcs mentioned this issue Mar 30, 2023
Open
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Apr 4, 2023
Open
This was referenced May 17, 2023
Closed
Closed
Closed
This was referenced May 17, 2023
Closed
Closed
@srirambv srirambv mentioned this issue May 18, 2023
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue May 19, 2023
Open
This was referenced May 19, 2023
Closed
Closed
@robot514 robot514 mentioned this issue May 20, 2023
Closed
@Xcczs Xcczs mentioned this issue May 23, 2023
Open
@eMadman eMadman mentioned this issue May 24, 2023
Closed
@Miyayes Miyayes mentioned this issue May 26, 2023
Closed
@kimbirkelund kimbirkelund mentioned this issue May 26, 2023
Open
@pilsnerbeer pilsnerbeer mentioned this issue Jun 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fix shields icon is in disabled state when browser launches
6 participants
@petemill @bbondy @simonhong @srirambv @LaurenWags @GeetaSarvadnya