Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to #29313: Clicking Reminder Notification yields no action #30281

Closed
btlechowski opened this issue May 11, 2023 · 4 comments · Fixed by brave/brave-core#18463
Closed

Comments

@btlechowski
Copy link

Follow up to #29313

Steps to Reproduce

  1. Clean profile
  2. Run Brave with
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --variations-server-url=https://test --enable-features=Reminder:remind_user_if_clicking_the_same_ad_after/1 --rewards=staging=true --use-dev-goupdater-url
  1. Enable rewards and ads
  2. View a notification ad
  3. Click the notification ad
  4. Click the Reminder Notification

Actual result:

Clicking Reminder Notification yields no action

Expected result:

Clicking Reminder Notification opens https://support.brave.com/hc/en-us/articles/14648356808845

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.52.93 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)
Revision b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS Ubuntu 18.04 LTS

cc @tmancey @Miyayes @emerick

@kjozwiak
Copy link
Member

The above requires 1.52.100 or higher for 1.52.x verification 👍

@stephendonner
Copy link

Verification PASSED using

Brave 1.52.103 Chromium: 113.0.5672.126 (Official Build) beta (x86_64)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS macOS Version 13.4 (Build 22F66)

Steps:

  1. installed 1.52.103
  2. launched Brave using
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --variations-server-url=https://test --enable-features=Reminder:remind_user_if_clicking_the_same_ad_after/1 --rewards=staging=true --use-dev-goupdater-url
  1. enabled Rewards and Ads
  2. viewed a notification ad
  3. clicked the notification ad

Confirmed:

  • clicking on the 1st ad notification yielded You earn when a Brave ads notifi... notification
  • clicking on the above notification opens https://support.brave.com/hc/en-us/articles/14648356808845 in a new tab
example example example example example
Screenshot 2023-05-19 at 11 04 06 AM Screenshot 2023-05-19 at 11 04 10 AM Screenshot 2023-05-19 at 11 04 20 AM Screenshot 2023-05-19 at 11 04 49 AM Screenshot 2023-05-19 at 11 04 57 AM

@stephendonner
Copy link

stephendonner commented May 23, 2023

Verification PASSED using

Brave 1.52.109 Chromium: 114.0.5735.26 (Official Build) beta (64-bit)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS Windows 10 Version 22H2 (Build 19045.2965)

Steps:

1 installed 1.52.109
2. launched Brave using

--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --variations-server-url=https://test --enable-features=Reminder:remind_user_if_clicking_the_same_ad_after/1 --rewards=staging=true --use-dev-goupdater-url
  1. enabled Rewards/Ads
  2. viewed a notification ad
  3. clicked the notification ad

Confirmed:

  • clicking on the 1st notification yielded You earn when a Brave ads notifi... notification
  • clicking on the above notification opens https://support.brave.com/hc/en-us/articles/14648356808845
example example example
image image (1) image (2)

@stephendonner stephendonner added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 23, 2023
@btlechowski
Copy link
Author

Verification passed on

Brave 1.52.109 Chromium: 114.0.5735.26 (Official Build) beta (64-bit)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS Ubuntu 18.04 LTS

Verified test plan from the description

Verified clicking on the reminder notification opens https://support.brave.com/hc/en-us/articles/14648356808845
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants