Support building with different channels w/ different branding

[bbondy]

You can find icon resources here:
https://github.com/brave/muon/tree/master/app/resources

Anthony started things here, and apparently it works for macOS.
https://github.com/brave/brave-browser/tree/multi-channel
https://github.com/brave/brave-core/tree/multi-channel

So still remaining is Linux and Windows.

You can see where we have different profile directories for each OS here:
brave/brave-core#46
brave/brave-core#59
This doc might be helpful:
https://chromium.googlesource.com/chromium/src/+/master/docs/user_data_dir.md

We want to support 4 channels:
release, beta, developer, and canary

User directory

For official build

• ~/Library/Application Support/BraveSoftware/Brave-Browser-Dev/Default for dev channel
• ~/Library/Application Support/BraveSoftware/Brave-Browser-Beta/Default for beta channel
• ~/Library/Application Support/BraveSoftware/Brave-Browser-Canary/Default for canary channel
• ~/Library/Application Support/BraveSoftware/Brave-Browser/Default for release channel

For unofficial build

• ~/Library/Application Support/BraveSoftware/Brave-Browser-Development/Default for all channel

TODOs

• channel option for build command (brave-browser)
• user dir support (brave-core)
  • MacOS
  • Windows
  • Linux
• install dir
  • MacOS
  • Windows
  • Linux
• app icon (brave-core)
  • MacOS
  • Windows
  • Linux

[simonhong]

Started to study Anthony's branch.

[simonhong]

User directory

For official build

• ~/Library/Application Support/BraveSoftware/Brave-Browser-Dev/Default for dev channel
• ~/Library/Application Support/BraveSoftware/Brave-Browser-Beta/Default for beta channel
• ~/Library/Application Support/BraveSoftware/Brave-Browser-Nightly/Default for canary channel
• ~/Library/Application Support/BraveSoftware/Brave-Browser/Default for release channel

For unofficial build

• ~/Library/Application Support/BraveSoftware/Brave-Browser-Development/Default for all channel

[bbondy]

I think that's correct, but @darkdh to confirm.

[darkdh]

that's correct and use different dir for development (official_build=false)
we can either use dev or developer channel and leave development for official_build=false

[bbondy]

~/Library/Application Support/Brave-Browser-Dev/Default for dev channel
~/Library/Application Support/Brave-Browser-Development/Default for official_build=false builds.

[simonhong]

Below 5 commands needs channel info.

• init and sync commands needs to use different tag/branch
• build, cibuild and createDist commands need channel to set args.gn

After init, same channel should be used.
When we want to change working channel, re-run init with different channel.

Based on above, there are three ways to handle chrome's multiple tags
(I assume that different version might be used across four channels)

1. Use one master brave-browser branch
   1.a Make package_config contains all chromium tags of four channels
   1.b Use internal server to get each channel's chromium tag
2. Use 4 different branch of brave-browser for each channel. In this case, package_config only contains one chromium tag as-is.

IMO, option 1.a is better than others.

WDYT? @bbondy @darkdh @bridiver

[simonhong]

On windows, channel info is fetched from executables path.

void InitializeProductDetailsForPrimaryModule() {
  InstallDetails::SetForProcess(MakeProductDetails(GetCurrentProcessExePath()));
}

In the startup progress of beta, Beta is fetched from
"C:\Program Files (x86)\Google\Chrome Beta\Application\chrome.exe" and appropriate InstallConstants is set as a global variable. Then, this variable is used to get various channel information on runtime.

Need to check GetDefaultUserDataDirectory() in chrome_paths_win.cc

We have copied chromium_install_modes.[h|cc] version, however, upstream version is still compiled together.
install_static_util target is including upstream version and is build as a separate library.
I need to fix this first.