Apply channel name to mac app name #208
Conversation
simonhong
force-pushed
the
apply_channel_to_mac_app_name
branch
from
3802368 to
5ddc23f
Compare
|
When I install various dmg by using this PR, only one app is visible in launchpad. |
simonhong
changed the title
simonhong
force-pushed
the
apply_channel_to_mac_app_name
branch
from
5ddc23f to
6ec78a8
Compare
simonhong
changed the title
|
I removed WIP label because above two problems are not related with this PR. |
build/mac/BUILD.gn
Outdated
| @@ -8,6 +8,16 @@ declare_args() { | |||
| _packaging_dir = "$root_out_dir/$brave_product_name Packaging" | |||
| keychain_db = getenv("HOME") + "/Library/Keychains/login.${mac_signing_keychain}-db" | |||
|
|
|||
| _target_app_name = "Brave-Browser" | |||
There was a problem hiding this comment.
does it make sense to create vars for "Brave-Browser" and "-Beta", etc.. in a gni file so it can be shared across platforms and stay consistent? I think the linux one I just reviewed could be combined as well
There was a problem hiding this comment.
even if they use slightly different names/capitalization I think it would be good to have the logic for building the name in the same place
There was a problem hiding this comment.
maybe that same gni file should create defines that we can use in the c++ code?
There was a problem hiding this comment.
Deleted and logic in //brave/build/config.gni is used. PTAL.
Ex, beta channel -> Brave-Browser-Beta.app
Ex)Brave-Browser-Dev.dmg for dev channel dist build.
And use it in //brave/build/mac/BUILD.gn for applying channel to app and dmg name.
simonhong
force-pushed
the
apply_channel_to_mac_app_name
branch
from
6ec78a8 to
4787658
Compare
App name is changed to use different install dir for different channel.
Ex, beta channel -> Brave-Browser-Beta.app
Issue: brave/brave-browser#396, brave/brave-browser#10
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Execute Brave.dmg and check app name
Reviewer Checklist: