Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher only shows one kind of channel app on MacOS #469

Closed
simonhong opened this issue Jul 2, 2018 · 9 comments
Closed

Launcher only shows one kind of channel app on MacOS #469

simonhong opened this issue Jul 2, 2018 · 9 comments

Comments

@simonhong
Copy link
Member

simonhong commented Jul 2, 2018

When different channel's apps are installed, only one brave app is visible in launcher.
But, all apps are visible in application folder.
I tested this with my pending PR - brave/brave-core#208.

@simonhong simonhong self-assigned this Jul 2, 2018
@simonhong
Copy link
Member Author

Do we want to install different channel apps simultaneously? @bbondy @darkdh
Also i'm not an expert about mac app.
So, I'm not sure this is possible or not. need help from macos expert.

@bbondy
Copy link
Member

bbondy commented Jul 2, 2018

Yes we want to install different channels simultaneously. We just have to make sure each app is named differently though.

@darkdh
Copy link
Member

darkdh commented Jul 3, 2018

yeah per @bbondy said and don't forget to set unique CrProductDirName in Info.list, it is required for unique user data dir.

@simonhong simonhong mentioned this issue Jul 4, 2018
12 tasks
@simonhong
Copy link
Member Author

dmg from latest trunk has different app name(Brave-Browser-Dev.app, Brave-Browser-Nightly.app) and each have different CrProductDirName.
But, still launcher shows only one app that installed at first.
Did some test by changing some elements in Plist.info such as identifier, bundle name to make different on different app. but same result.

Need to investigate..

@simonhong
Copy link
Member Author

simonhong commented Jul 7, 2018

To create proper app/dmg, #153 should be resolved first.
Each channel needs different BRANDING files to get different app and id.

@simonhong simonhong added this to the Releasable builds milestone Jul 8, 2018
@simonhong
Copy link
Member Author

simonhong commented Jul 9, 2018

Before starting #153 , I tried with below BRANDING file in chrome/app/theme/brave/ for dev channel with this working branch

COMPANY_FULLNAME=Brave Software, Inc.
COMPANY_SHORTNAME=Brave Software
PRODUCT_FULLNAME=Brave-Browser-Dev
PRODUCT_SHORTNAME=Brave-Browser-Dev
PRODUCT_INSTALLER_FULLNAME=Brave Installer
PRODUCT_INSTALLER_SHORTNAME=Brave Installer
COPYRIGHT=Copyright 2016 The Brave Authors. All rights reserved.
MAC_BUNDLE_ID=org.brave.Brave.dev
MAC_CREATOR_CODE=Cr24

yarn build Release --channel=dev --no_branding_update is completed.
One strange thing is src/out/Release/Brave-Browser-Dev.app is seen as Brave not Brave-Browser-Dev in finder. In console, there is no Brave.app folder in out/Release.
(This is because of localized InfoPlist.strings. They are created by infoplist_strings_util.mm)
I checked Info.plist doesn't have any Brave value in any key.
Running is failed with below error.

simon-home:src simonhong$ ./out/Release/Brave-Browser-Dev.app/Contents/MacOS/Brave-Browser-Dev
[0709/111111.524532:ERROR:icu_util.cc(114)] icudtl.dat not found in bundle
[0709/111111.525656:ERROR:icu_util.cc(133)] Invalid file descriptor to ICU data received.
Trace/BPT trap: 5
simon-home:brave-browser simonhong$ open ./src/out/Release/Brave-Browser-Dev.app
LSOpenURLsWithRole() failed with error -10810 for the file /Volumes/SSD/brave/brave-browser/src/out/Release/Brave-Browser-Dev.app.

yarn create_dist Release --channel=dev --no_branding_update is failed during signing.

There are two problems when app name and id is changed.

  • Can't execute app
    • It seems app can't refer proper framework bundle
  • Signing fail

@RyanJarv
Copy link
Contributor

RyanJarv commented Jul 25, 2018

So glancing through this I suspect this is related to the identifier not changing between releases.

  <key>CFBundleIdentifier</key>
  <string>org.brave.Brave</string>

Then for reference chromium uses the following:

com.google.Chrome
com.google.Chrome.beta
com.google.Chrome.dev
com.google.Chrome.canary

Unsure of the source but faintly recalling something along the lines of 'bad things happen' on this not being updated correctly.

@kjozwiak
Copy link
Member

kjozwiak commented Oct 2, 2018

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X
Brave 0.56.1 Chromium: 70.0.3538.22 (Official Build) dev (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X
  • ensured that Brave BETA is being installed under /Applications/Brave\ Browser\ Beta.app/
  • ensured that Brave Dev is being installed under /Applications/Brave\ Browser\ Dev.app/
  • ensured that Brave BETA profiles are being saved under ~/Library/Application\ Support/BraveSoftware/Brave-Browser-Beta/
  • ensured that Brave Dev profiles are being used under ~/Library/Application\ Support/BraveSoftware/Brave-Browser-Dev
  • ensured that Brave BETA launches and uses the correct icon from Applications
  • ensured that Brave Dev launches and uses the correct icon from Applications
  • ensured that Brave BETA launches and uses the correct icon via Spotlight Search
  • ensured that Brave Dev launches and uses the correct icon via Spotlight Search
  • ensured that Brave BETA launches and uses the correct icon via a dock shortcut
  • ensured that Brave Dev launches and uses the correct icon via a dock shortcut
  • ensured that Brave BETA launches and uses the correct icon via Launch Pad
  • ensured that Brave Dev launches and uses the correct icon via Launch Pad
  • ensured that Brave Dev & Brave BETA are named correctly

@simonhong please let me know if the above is sufficient enough for verification.

@simonhong
Copy link
Member Author

@kjozwiak Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants