-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launcher only shows one kind of channel app on MacOS #469
Comments
Yes we want to install different channels simultaneously. We just have to make sure each app is named differently though. |
yeah per @bbondy said and don't forget to set unique |
dmg from latest trunk has different app name( Need to investigate.. |
To create proper app/dmg, #153 should be resolved first. |
Before starting #153 , I tried with below BRANDING file in
There are two problems when app name and id is changed.
|
So glancing through this I suspect this is related to the identifier not changing between releases.
Then for reference chromium uses the following:
Unsure of the source but faintly recalling something along the lines of 'bad things happen' on this not being updated correctly. |
Went through verification using the following build under
@simonhong please let me know if the above is sufficient enough for verification. |
@kjozwiak Perfect! |
When different channel's apps are installed, only one brave app is visible in launcher.
But, all apps are visible in application folder.
I tested this with my pending PR - brave/brave-core#208.
The text was updated successfully, but these errors were encountered: