Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFBundleIdentifier should be unique for each channel on OSX #642

Closed
RyanJarv opened this issue Jul 25, 2018 · 1 comment
Closed

CFBundleIdentifier should be unique for each channel on OSX #642

RyanJarv opened this issue Jul 25, 2018 · 1 comment

Comments

@RyanJarv
Copy link
Contributor

Description

From what I recall (will follow up with sources) problematic issues can come up if two apps have the same CFBundleIdentifier value.

Steps to Reproduce

  1. Install the dev build
  2. Install the beta build (unavailable currently)

Actual result:

CFBundleIdentifier is set to org.brave.Brave for both dev/beta builds

I suspect it may also be causing this issue:

Expected result:

CFBundleIdentifier is different for the dev and beta builds

Brave version (about:brave info)

master branch

Additional Information

Needs updating:

@RyanJarv RyanJarv self-assigned this Jul 25, 2018
@bbondy bbondy added this to the Releasable builds milestone Jul 26, 2018
@simonhong
Copy link
Member

I think I fixed this by brave/brave-core@94b4894

@RyanJarv RyanJarv closed this as completed Aug 6, 2018
@bbondy bbondy added the QA/No label Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants