-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Brave VPN by default #29612
Labels
feature/vpn
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/macOS
OS/Windows
QA Pass - Android ARM
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
bsclifton
added
OS/Android
Fixes related to Android browser functionality
OS/Desktop
labels
Apr 11, 2023
25 tasks
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
Apr 12, 2023
spylogsster
pushed a commit
to brave/brave-core
that referenced
this issue
Apr 17, 2023
spylogsster
pushed a commit
to brave/brave-core
that referenced
this issue
Apr 18, 2023
7 tasks
Verification
|
Brave | 1.52.85 Chromium: 113.0.5672.63 (Official Build) beta (x86_64) |
---|---|
Revision | 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912} |
OS | macOS Version 11.7.6 (Build 20G1231) |
Steps:
- installed
1.52.85
- launched Brave
- confirmed
VPN
button on the toolbar - clicked to confirm
Buy
/Already purchased VPN?
dialog - opened
brave://flags
- confirmed
brave://flags/#brave-vpn
is set toDefault
Brave VPN dialog |
brave://flags |
---|---|
Verified
|
Brave | 1.52.92 Chromium: 113.0.5672.92 (Official Build) beta (64-bit) |
---|---|
Revision | b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10} |
OS | Windows 10 Version 22H2 (Build 19045.2913) |
Steps:
- installed
1.52.92
- launched Brave
- confirmed
VPN
button on the toolbar - clicked to confirm
Buy
/Already purchased VPN?
dialog - opened
brave://flags
- confirmed
brave://flags/#brave-vpn
is set toDefault
Brave VPN dialog |
brave://flags |
---|---|
@MadhaviSeelam mind verifying on Windows 11, and slapping on |
The above requires |
Uni-verse
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
May 16, 2023
Verified
|
Brave | 1.51.117 Chromium: 113.0.5672.92 (Official Build) (x86_64) |
---|---|
Revision | b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10} |
OS | macOS Version 11.7.6 (Build 20G1231) |
Steps:
- installed
1.51.117
- launched Brave
- confirmed
VPN
button on the toolbar - clicked to confirm
Buy
/Already purchased VPN....?
dialog - opened
brave://flags
- confirmed
brave://flags/#brave-vpn
is set toDefault
Brave VPN dialog |
brave://flags |
---|---|
Verified
|
Brave | 1.51.117 Chromium: 113.0.5672.92 (Official Build) (64-bit) |
---|---|
Revision | b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10} |
OS | Windows 10 Version 22H2 (Build 19045.2965) |
Steps:
- installed
1.51.117
- launched Brave
- confirmed
VPN
button in the toolbar - clicked to confirm
Buy
/Already purchased...?
dialog - opened
brave://flags
- confirmed
brave://flags/#brave-vpn
is set toDefault
Brave VPN dialog |
brave://flags |
---|---|
Verified on
Using Test Plan in brave/brave-core#15602 (comment)
|
Uni-verse
added
QA Pass - Android ARM
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/vpn
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/macOS
OS/Windows
QA Pass - Android ARM
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Test plan
See brave/brave-core#17989
Description
VPN is enabled now via a Griffin experiment
CrossPlatformVPNStudy
which enable the following features:These features are enabled for all channels (Nightly, Beta, Release) and percentage is at 100%. We should enable this by default so that we can remove the Griffin experiment.
The text was updated successfully, but these errors were encountered: