Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Brave VPN by default #29612

Closed
bsclifton opened this issue Apr 11, 2023 · 8 comments · Fixed by brave/brave-core#17989
Closed

Enable Brave VPN by default #29612

bsclifton opened this issue Apr 11, 2023 · 8 comments · Fixed by brave/brave-core#17989

Comments

@bsclifton
Copy link
Member

bsclifton commented Apr 11, 2023

Test plan

See brave/brave-core#17989

Description

VPN is enabled now via a Griffin experiment CrossPlatformVPNStudy which enable the following features:

  • BraveVPN
  • BraveVPNLinkSubscriptionAndroidUI

These features are enabled for all channels (Nightly, Beta, Release) and percentage is at 100%. We should enable this by default so that we can remove the Griffin experiment.

@stephendonner
Copy link

Verification PASSED using

Brave 1.52.85 Chromium: 113.0.5672.63 (Official Build) beta (x86_64)
Revision 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS macOS Version 11.7.6 (Build 20G1231)

Steps:

  1. installed 1.52.85
  2. launched Brave
  3. confirmed VPN button on the toolbar
  4. clicked to confirmBuy/Already purchased VPN? dialog
  5. opened brave://flags
  6. confirmed brave://flags/#brave-vpn is set to Default
Brave VPN dialog brave://flags
Screen Shot 2023-05-03 at 4 02 30 PM Screen Shot 2023-05-03 at 4 04 07 PM

@stephendonner
Copy link

stephendonner commented May 9, 2023

Verified PASSED using

Brave 1.52.92 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)
Revision b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS Windows 10 Version 22H2 (Build 19045.2913)

Steps:

  1. installed 1.52.92
  2. launched Brave
  3. confirmed VPN button on the toolbar
  4. clicked to confirm Buy / Already purchased VPN? dialog
  5. opened brave://flags
  6. confirmed brave://flags/#brave-vpn is set to Default
Brave VPN dialog brave://flags
image image

@stephendonner
Copy link

stephendonner commented May 9, 2023

@MadhaviSeelam mind verifying on Windows 11, and slapping on QA Pass/Win64, when you do? Thanks!

@kjozwiak
Copy link
Member

The above requires 1.51.116 or higher for 1.51.x verification. Going to remove the QA Pass labels as we'll need to retest on 1.51.x once we get the RC builds.

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 16, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.51.117 Chromium: 113.0.5672.92 (Official Build) (64-bit)
-- | --
Revision | b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS | Windows 11 Version 22H2 (Build 22621.1702)
  1. installed 1.51.117
  2. launched Brave
  3. confirmed VPN button on the toolbar
  4. clicked to confirm Buy / Already purchased VPN? dialog
  5. confirmed successfully logged into VPN with existing prod credentials
  6. opened brave://flags
  7. confirmed brave://flags/#brave-vpn is set to Default
step 3-4 step 5 step 6-7
image !image image

@stephendonner
Copy link

Verified PASSED using

Brave 1.51.117 Chromium: 113.0.5672.92 (Official Build) (x86_64)
Revision b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS macOS Version 11.7.6 (Build 20G1231)

Steps:

  1. installed 1.51.117
  2. launched Brave
  3. confirmed VPN button on the toolbar
  4. clicked to confirm Buy/Already purchased VPN....? dialog
  5. opened brave://flags
  6. confirmed brave://flags/#brave-vpn is set to Default
Brave VPN dialog brave://flags
Screen Shot 2023-05-16 at 9 50 04 AM Screen Shot 2023-05-16 at 9 50 15 AM

@stephendonner
Copy link

stephendonner commented May 16, 2023

Verified PASSED using

Brave 1.51.117 Chromium: 113.0.5672.92 (Official Build) (64-bit)
Revision b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS Windows 10 Version 22H2 (Build 19045.2965)

Steps:

  1. installed 1.51.117
  2. launched Brave
  3. confirmed VPN button in the toolbar
  4. clicked to confirm Buy/Already purchased...? dialog
  5. opened brave://flags
  6. confirmed brave://flags/#brave-vpn is set to Default
Brave VPN dialog brave://flags
image image

@Uni-verse
Copy link
Contributor

Uni-verse commented May 17, 2023

Verified on Samsung Galaxy S21 5G using the following version(s):

Brave	1.51.118 Chromium: 113.0.5672.126 (Official Build) (64-bit) 
Revision	c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS	Android 13; Build/TP1A.220624.014; 33; REL

Using Test Plan in brave/brave-core#15602 (comment)

  1. Install 1.51.118
  2. Open menu, tap on VPN
  3. Purchase using IAP
  4. Install VPN profile
  5. Open VPN settings and confirm subscription
  6. Confirm Link Subscription option is available in the VPN settings
  7. Confirm tapping on Link Subscription will open account.brave.com with intent params
  8. Open app switcher and close brave app
  9. Relaunch brave, confirm VPN link subscription callout is shown
  • Confirmed Brave VPN is shown in the menu by default on fresh install.
  • Confirmed VPN connection is enabled after installing profile.
  • Confirmed Link purchase to your Brave account option is shown in settings and callout is presented to user.
Example Example Example Example
screenshot-1684333090305 screenshot-1684333977235 screenshot-1684334942009 screenshot-1684334956979

@Uni-verse Uni-verse added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment