Incognito window doesn't open from shortcut when a search extension is installed

[sammacbeth]

Description

When launching the browser directly into incognito mode via a Windows desktop shortcut, the browser fails to launch when search extensions are installed and enabled. This is the case even if these extensions are not set to run in incognito mode.

I've reproduced this issue with the DuckDuckGo Privacy Essentials extension (which was reported on reddit, and Ecosia extension, which makes me assume this is related to extensions that use chrome_settings_overrides to override the search provider.

Steps to Reproduce

1. Create an incognito mode desktop shortcut: Right click on the desktop -> chose new: Shortcut -> Specify the target as "C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe" -incognito.
2. Install the DuckDuckGo or Ecosia extensions from the Chrome Web Store.
3. Close all Brave windows.
4. Double click on the shortcut.

Actual result:

Brave does not launch.

Expected result:

Brave launches a new incognito window.

Reproduces how often:

Easily reproduced. This happens every time after the extension is installed. Relaunching the browser in a normal window and disabling the extension fixes it.

Brave version (brave://version info)

1.51.114 Chromium: 113.0.5672.92 (Official Build) (64-bit)
Revision: b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS: Windows 11 Version 22H2 (Build 22621.1555)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? No
• Does the issue resolve itself when disabling Brave Rewards? No
• Is the issue reproducible on the latest version of Chrome? No

[simonhong]

@sammacbeth Thanks for reporting!
It seems brave is crashed immediately. Looking.

[MadhaviSeelam]

Verification PASSED using

Brave | 1.53.75 Chromium: 114.0.5735.58 (Official Build) beta (64-bit)
-- | --
Revision | ef012197ab4bc867d7b1dd80a001d0be7da8a714-refs/branch-heads/5735_52@{#7}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Reproduced this issue in 1.51.x . Private window doesn't launch when double clicked on Brave icon on the taskbar

ex|ex|ex --- | --- |--- ||

Steps:

Case 1: Fresh install DuckDuckGo extension - PASSED

1. Installed 1.53.75
2. launched Brave
3. visited chrome.google.com/webstore in a new tab
4. searched for DuckDuckGo and selected DuckDuckGo Privacy Essentials
5. clicked Add to Brave >> Add extension
6. verified DDG success page shown after extension added
7. confirmed DDG extension is added in brave://extensions
8. opened brave://settings/search
9. verified DuckDuckGo was selected and greyed out for Normal window entry
10. opened a new tab and typed travel in the URL bar
11. clicked Keep it button in the dialog
12. closed Brave
13. launched Brave via --incognito cmdline switch to launch private window only

• Confirmed normal window is set to DuckDuckGo as a default provider.
• Confirmed search results show DDG as a search engine
• Confirmed private window is launched without crashes
• Confirmed search results show DDG as a search engine

step 4 | step 5 | step 6 | step 7 | step 9 | step 11| step 13 ---- | ----- | ----- | ----- | ----- | ----- | ---- ||||||

Normal window w/search results	Private window	PW with search results

Case 2: Upgrade with `Ecosia` extension - `PASSED`

1. Installed 1.52.117
2. launched Brave
3. visited chrome.google.com/webstore in a new tab
4. searched for Ecosia and selected Ecosia - The search engine that plants trees
5. clicked Add to Brave >> Add extension
6. verified Ecosia first run page is shown after extension added
7. clicked a new tab and clicked Keep it on the dialog
8. verified Ecosia extension is added in brave://extensions
9. opened brave://settings/search
10. verified Ecosia was selected and greyed out for Normal window entry
11. opened a new tab and typed travel in the URL bar
12. closed Brave
13. renamed the profile Brave-Browser-Beta
14. followed below steps to launch Private window
    • right clicked on the Brave Beta icon in the taskbar (or on the desktop) to open context menu
    • right clicked Brave Beta
    • selected Properties in the context menu
    • specified the target as "C:\Program Files\BraveSoftware\Brave-Browser-Beta\Application\brave.exe" -incognito.
15. double clicked the shortcut to launch Private window
16. enter travel in the URL bar in the Private window

• Confirmed normal window is set to Ecosia as a default provider.
• Confirmed search results show Ecosia as a search engine
• Confirmed private window is launched without crashes
• Confirmed search results show Ecosia as a search engine

step 1 | step 4 | step 5 | step 6 | step 7 | step 8 | step 10 | step 14a-c | step 14d ---- | --- | --- | --- | --- | --- | ---- | --- | ---- ||||||||

Normal window w/search results	Private window	PW with search results