Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't show Manage Subscriptions button in URL bar until after opt-in #26705

Closed
stephendonner opened this issue Nov 11, 2022 · 1 comment
Closed

Comments

@stephendonner
Copy link

stephendonner commented Nov 11, 2022

Description

Shouldn't show Manage Subscriptions button in URL bar until after opt-in

Steps to Reproduce

  1. install 1.47.65
  2. launch Brave
  3. open brave://flags
  4. set brave://flags/#brave-news-subscribe-button to Enabled
  5. click Relaunch
  6. dismiss the cookie-consent dialog
  7. open a new-tab page
  8. scroll
  9. confirm you are not opted-in to Brave News
  10. load planet.mozilla.org
  11. wait
  12. click on the Manage Subscriptions icon in the URL bar
  13. click Follow
  14. click Manage Feeds
  15. click Turn on Brave News
  16. examine the dialog, under Following

Actual result:

Planet Mozilla shows as Followed, after opting in

example example example example example
Screen Shot 2022-11-11 at 12 21 08 PM Screen Shot 2022-11-11 at 12 21 17 PM Screen Shot 2022-11-11 at 12 21 24 PM Screen Shot 2022-11-11 at 12 24 37 PM Screen Shot 2022-11-11 at 12 30 34 PM

Expected result:

In step 12, since we haven't-yet opted-in to Brave News, we should probably take the user to the Customize dialog, first, to opt-in?

Or maybe just not show the button until opted-in?

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.47.65 Chromium: 107.0.5304.110 (Official Build) nightly (x86_64)
Revision 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS macOS Version 11.7.1 (Build 20G918)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @petemill @fallaciousreasoning @mattmcalister @LaurenWags @MadhaviSeelam

@fallaciousreasoning
Copy link

I can't repro this in 1.47.186 Chromium: 109.0.5414.119 (Official Build) (64-bit) (which is the latest stable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants