Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Randomize USB serial numbers per device #30041

Closed
pilgrim-brave opened this issue Apr 27, 2023 · 5 comments · Fixed by brave/brave-core#18284
Closed

Randomize USB serial numbers per device #30041

pilgrim-brave opened this issue Apr 27, 2023 · 5 comments · Fixed by brave/brave-core#18284

Comments

@pilgrim-brave
Copy link

pilgrim-brave commented Apr 27, 2023

Current implementation brave/brave-core#17470 may end up with duplicate serial numbers if multiple USB devices are connected.

Test Cases/Examples

@kjozwiak
Copy link
Member

The above requires 1.51.117 or higher for 1.51.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented May 16, 2023

Verified with

Brave | 1.51.117 Chromium: 113.0.5672.92 (Official Build) (x86_64)
-- | --
Revision | b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS | macOS Version 13.3.1 (a) (Build 22E772610a)

Using the STR/Cases outlined via https://dev-pages.brave.software/fingerprinting/devices.html, went through the following:

Ensured that there's multiple USB devices connected to the machine as per the following:

Screenshot 2023-05-16 at 11 02 57 AM

Allow Fingerprinting

Example Example Example
1 2 3

Block Fingerprinting

Example Example Example
4 5 6

Aggressive Fingerprinting

Example Example Example
7 8 9

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 16, 2023
@MadhaviSeelam
Copy link

Verification `PASSED using

Brave | 1.51.117 Chromium: 113.0.5672.92 (Official Build) (64-bit)
-- | --
Revision | b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Using the STR/Cases outlined via https://dev-pages.brave.software/fingerprinting/devices.html, went through the following:

Ensured that there's multiple USB devices connected to the machine as per the following:

image

Allow Fingerprinting

Example Example
image image

Block Fingerprinting

Example Example
image image

Aggressively block Fingerprinting

Example Example
image image

@btlechowski
Copy link

Verification passed on

Brave 1.51.118 Chromium: 113.0.5672.126 (Official Build) (64-bit)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS Ubuntu 18.04 LTS

Allow Fingerprinting

Example Example
image image

Block Fingerprinting

Example Example
image image

Aggressively block Fingerprinting

Example Example
image image

@hffvld
Copy link
Contributor

hffvld commented May 17, 2023

Verified on Google Pixel 7 and Galaxy Tab S8 using version(s):

Device/OS: 
- Google Pixel 7 [panther_beta-user 14 UPB1.230309.017 release-keys]
- SM-X700 Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.51.118
Chromium: 113.0.5672.126 (Official Build) (64-bit)
Revision: c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}

STEPS:

  1. Connect multiple USB devices
  2. Open to https://dev-pages.brave.software/fingerprinting/devices.html
  3. Go through the flow
  4. Now open https://dev-pages.bravesoftware.com/fingerprinting/devices.html
  5. Go through the flow

ACTUAL RESULTS:

  • Verified when multiple USB devices are connected, no duplicate serial numbers are shown
Phone - PASS

Allow all fingerprinting

1 2 3 4
1 2 3 4

Fingerprinting blocked (standard)

1 2 3 4
1 2 3 4

Fingerprinting blocked (strict, may break sites)

1 2 3 4
1 2 3 4
Tablet - PASS

Allow all fingerprinting

1 2 3
1 2 3

Fingerprinting blocked (standard)

1 2 3
1 2 3

Fingerprinting blocked (strict, may break sites)

1 2 3
1 2 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment