Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement per-device WebUSB serial farbling #18284

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Apr 27, 2023

Resolves brave/brave-browser#30041

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

As per @pes10k, the STR/Cases for QA can be found via https://dev-pages.brave.software/fingerprinting/devices.html.

@pilgrim-brave pilgrim-brave requested a review from a team as a code owner April 27, 2023 20:45
@pilgrim-brave pilgrim-brave self-assigned this Apr 27, 2023
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pilgrim-brave pilgrim-brave enabled auto-merge (squash) April 28, 2023 16:53
@pilgrim-brave pilgrim-brave merged commit eeca4b4 into master Apr 28, 2023
@pilgrim-brave pilgrim-brave deleted the mpilgrim_farble_usb_more branch April 28, 2023 17:36
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone Apr 28, 2023
brave-builds added a commit that referenced this pull request Apr 28, 2023
brave-builds added a commit that referenced this pull request Apr 28, 2023
@kjozwiak
Copy link
Member

kjozwiak commented May 15, 2023

Verification PASSED on Win x64 using the following build(s):

Brave | 1.53.41 Chromium: 113.0.5672.92 (Official Build) nightly (64-bit)
-- | --
Revision | b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Using the STR/Cases outlined via https://dev-pages.brave.software/fingerprinting/devices.html, went through the following:

Ensured that there's multiple USB devices connected to the machine as per the following:

image

Allow Fingerprinting

Example Example Example
AllowEnabled0 AllowEnabled1 AllowEnabled2

Block Fingerprinting

Example Example Example
BlockEnabled0 BlockEnabled1 BlockEnabled2

Aggressive Fingerprinting

Example Example Example
aggressiveEnabled0 aggressiveEnabled1 aggressiveEnabled2

kjozwiak pushed a commit that referenced this pull request May 15, 2023
kjozwiak pushed a commit that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Randomize USB serial numbers per device
3 participants