Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound Option Should Use Brave Colors #26809

Open
Nihal-Raj opened this issue Nov 16, 2022 · 1 comment
Open

Sound Option Should Use Brave Colors #26809

Nihal-Raj opened this issue Nov 16, 2022 · 1 comment
Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@Nihal-Raj
Copy link

Description

The sound option on the padlock should use Brave colors, instead of Chromium's.

Steps to Reproduce

  1. Visit YouTube
  2. Click on any video
  3. Click on the padlock in the address bar

Actual result:

image

Expected result:

Using Brave's branding colors.

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.45.127 Chromium: 107.0.5304.110 (Official Build) (64-bit)
Revision 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS Windows 10 Version 22H2 (Build 19045.2311)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? N.A.
  • Can you reproduce this issue with the nightly channel? N.A.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". design A design change, especially one which needs input from the design team QA/Yes labels Nov 18, 2022
@meeddhhaa
Copy link

Hey guys @Nihal-Raj @rebron could you give some more context on how to go about doing this?
I'm new to open source and would love to work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
Status: P4 backlog
Development

No branches or pull requests

3 participants