Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regions support and command-line switch to change region for testing geo targeted Ads #2661

Closed
tmancey opened this issue Dec 19, 2018 · 1 comment · Fixed by brave/brave-core#1477
Closed

Add regions support and command-line switch to change region for testing geo targeted Ads #2661

tmancey opened this issue Dec 19, 2018 · 1 comment · Fixed by brave/brave-core#1477
Assignees
@tmancey
Labels
feature/ads QA/No release-notes/exclude
Milestone
0.62.x - Release ...

Comments

@tmancey
Copy link
Contributor

tmancey commented Dec 19, 2018 •
edited
Loading

Add regions support and command-line switch to change region for testing geo targeted Ads, i.e. passing en_US, en_US.UTF-8 etc.
@tmancey tmancey added this to the 1.x Backlog milestone Dec 19, 2018
@tmancey tmancey self-assigned this Dec 19, 2018
@tmancey tmancey changed the title Add command-line switch to change region for testing Brave Ads Add command-line switch to change region for testing GeoTargets in Brave Ads Dec 19, 2018
@tmancey tmancey changed the title Add command-line switch to change region for testing GeoTargets in Brave Ads Add command-line switch to change region for testing geo targeted Ads in Brave Ads Dec 20, 2018
@tmancey tmancey changed the title Add command-line switch to change region for testing geo targeted Ads in Brave Ads Add command-line switch to change region for testing geo targeted Ads Jan 15, 2019
@mrose17 mrose17 assigned tmancey and unassigned tmancey Jan 17, 2019
@tmancey tmancey changed the title Add command-line switch to change region for testing geo targeted Ads Add regions support and command-line switch to change region for testing geo targeted Ads Jan 18, 2019
@tmancey tmancey mentioned this issue Jan 22, 2019
Closed
18 tasks
@tmancey tmancey added the QA/Yes label Jan 22, 2019
@tmancey tmancey modified the milestones: 1.x Backlog, 0.59.x - Beta, 0.61.x - Nightly Jan 22, 2019
@tmancey tmancey mentioned this issue Jan 28, 2019
Merged
18 tasks
tmancey added a commit to brave/brave-core that referenced this issue Jan 29, 2019
@tmancey
Add regions support and command-line switch to change region for test…
3ed6503 
…ing geo targeted Ads

fixes brave/brave-browser#2661
This was referenced Mar 21, 2019
Closed
Closed
Closed
@GeetaSarvadnya
Copy link

Ads are disabled in 0.62.x hence moving the milestone to 0.63.x

@kjozwiak kjozwiak added the QA/No label Apr 1, 2019
@kjozwiak kjozwiak removed the QA/Yes label Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads QA/No release-notes/exclude
Projects
None yet
Milestone
0.62.x - Release (Release Channel)
5 participants
@tmancey @kjozwiak @rebron @NejcZdovc @GeetaSarvadnya