Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Redirect to brave://rewards settings page when user presses "Brave Rewards" button in native browser settings menu , and make sure brave://rewards page is fully reset after Rewards profile reset #26902

Closed
3 tasks
Miyayes opened this issue Nov 21, 2022 · 3 comments · Fixed by brave/brave-core#18844
Assignees
Labels
feature/rewards feature/settings OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Nov 21, 2022

Description

Redirect to brave://rewards/ when users press on “Rewards” section in native browser settings.

The brave://rewards/ is now at parity thanks to #24570.

  • Move the "Show Ads when Brave is not in use" toggle into the general notifications section of browser settings
  • Make sure Manage > Reset Rewards section on brave://rewards is visible and works on Android (which will replace the "Reset Brave Rewards" button)
  • Ensure that after reset, brave://rewards page is in fresh state that shows user the "Start using Brave Rewards" screen. This button should pop open the Rewards panel when pressed.


Related: #20894

@anthonypkeane @timchilds

@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality labels Nov 21, 2022
@Miyayes Miyayes added feature/settings priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes labels Nov 21, 2022
@Miyayes Miyayes changed the title [Android] Redirect to brave://rewards settings page when user presses Brave Rewards in native browser settings [Android] Redirect to brave://rewards settings page when user presses "Brave Rewards" button in native browser settings menu Nov 22, 2022
@Miyayes Miyayes changed the title [Android] Redirect to brave://rewards settings page when user presses "Brave Rewards" button in native browser settings menu [Android] Redirect to brave://rewards settings page when user presses "Brave Rewards" button in native browser settings menu , and make sure brave://rewards page is fully reset after Rewards profile reset Jan 30, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 16, 2023
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 26, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 26, 2023

Verification PASSED on Vivo x70 Pro version 12 running Bravemonoarmx64.apk_1.57.19

  • Logged User can reset rewards even though the rewards is not enabled #31914
  • Confirmed that the Reset gear icon is shown on the brave://rewards page when user enable the rewards
  • Confirmed that user can reset the rewards
  • Click on Brave Rewards opens up the brave://rewards page
  • Confirmed that the "Show Ads when Brave is not in use" toggle is shown under appearance settings
Example Example Example Example
Screenshot_20230727_175936 Screenshot_20230727_175945 Screenshot_20230727_175507 Screenshot_20230727_175347

Reset Rewards

Example Example Example Example Example
Screenshot_20230727_165213 Screenshot_20230727_165432 Screenshot_20230727_165445 Screenshot_20230727_165507 Screenshot_20230727_165658

@GeetaSarvadnya
Copy link

Move the "Show Ads when Brave is not in use" toggle into the general notifications section of browser settings

@deeppandya I don't see "Show Ads when Brave is not in use" toggle in notifications section of browser settings, could you please let me know where this setting is been moved to. Thanks!

cc: @Miyayes

@deeppandya
Copy link

Move the "Show Ads when Brave is not in use" toggle into the general notifications section of browser settings

@deeppandya I don't see "Show Ads when Brave is not in use" toggle in notifications section of browser settings, could you please let me know where this setting is been moved to. Thanks!

cc: @Miyayes

Sorry @GeetaSarvadnya need to update the issue. That setting option is part of appearance now with title Brave rewards icon

@GeetaSarvadnya GeetaSarvadnya added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards feature/settings OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
5 participants