Rewards reset profile android #18844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
zenparsing
reviewed
Jun 9, 2023
| @@ -297,7 +297,6 @@ export function Settings () { | |||
| <BatIcon />{getString('braveRewards')} | |||
| </style.title> | |||
| { | |||
| !isAndroid && | |||
| <style.manageAction> | |||
There was a problem hiding this comment.
Is it possible to remove the enclosing brackets now?
...
</style.title>
<style.manageAction>
...
</style.manageAction>
...
emerick
approved these changes
Jun 9, 2023
| <message name="IDS_SHOW_ADS_WHEN_BRAVE_IS_NOT_IN_USE" desc="Title for Show Ads when Brave is not in use option in Brave rewards settings."> | ||
| Show Ads when Brave is not in use | ||
| <message name="IDS_SHOW_ADS_WHEN_BRAVE_IS_NOT_IN_USE_TITLE" desc="Title for Show Ads when Brave is not in use option in Brave rewards settings."> | ||
| Brave Notification Ads |
There was a problem hiding this comment.
Nit: Is that the correct terminology now? The "notification" part seems superfluous/technical.
|
A Storybook has been deployed to preview UI for the latest push |
deeppandya
force-pushed
the
rewards_reset_profile_android
branch
from
a3f8c2a
to
ddbe59c
Compare
zenparsing
approved these changes
Jun 15, 2023
| { | ||
| !isAndroid && | ||
| <style.manageAction> | ||
| <style.manageAction> | ||
| <button |
There was a problem hiding this comment.
Nit: looks like the indenting is off here (through </style.manageAction>)?
Reset rewards prefs on onCompleteReset
Remove brave rewards preference Refactor rewards prefernce changes
Resolve presubmit check Rebase and Address PR comments Resolve indentation issue
deeppandya
force-pushed
the
rewards_reset_profile_android
branch
from
ddbe59c
to
39655ff
Compare
|
A Storybook has been deployed to preview UI for the latest push |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#26902
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: