Add import from Whale browser

[rebron]

Description

Add Whale browser to brave://settings/importData list

Test plan
(taken from brave/brave-core#16441)
Install Whale browser and check that History, Bookmarks and Extensions can be imported.

Expected result:

1. Have Whale browser installed
2. Install a new fresh version of Brave. When visiting brave://welcome, Whale should be a listed browser.
3. Alternatively skip brave://welcome onboarding and visit brave://settings/getStarted. Selecting brave://settings/importData should show Whale as a listed browser.

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? n/a
• Can you reproduce this issue with the beta channel? n/a
• Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

related issue: #27301

[rebron]

cc: @spylogsster @simonhong

[jenn-rhim]

Whale logo:

[MadhaviSeelam]

Verification PASSED using

Brave | 1.49.99 Chromium: 110.0.5481.100 (Official Build) beta (64-bit)
-- | --
Revision | 4be7a36f7cb943af6118e449bbab494b43dcaddd-refs/branch-heads/5481_77@{#14}
OS | Windows 11 Version 21H2 (Build 22000.1574)

Pre requisites:

Download Whale browser and create 2 Profiles with data - bookmarks, history, extensions and passwords

Profile 1	Profile 2

Case 1: Import from Single profile via onboarding - brave://welcome - PASSED

1. Install 1.49.99
2. launch Brave
3. click `Set Brave as default browser
4. select Whale
5. click import
6. click Finish

Confirmed Whale card is shown in Import Settings screen

Confirmed importing from only one source profile, i.e. Whale Profile 1, no new Brave profile is created

Confirmed bookmarks, history, extensions are imported into default profile

Confirmed bookmarks are shown on the bookmarks bar and bookmarks sidepanel in a new-tab

Confirmed extensions added via Chrome Web Store are imported and no extensions imported from Whale Store

Note: Passwords are not imported as mentioned in the brave/brave-core#16576 (comment)

step 3	step 4	step 6	new-tab	bookmarks	extensions	history

Case 2: Import from multiple profiles via onboarding - brave://welcome - PASSED

1. new profile
2. launch Brave
3. click Set Brave as default browser
4. select Whale
5. click import
6. select Whale Person 1, & 2
7. click Import Profiles
8. click Finish
9. click on Profile icon in the new-tab page next to hamburger menu

Confirmed two newly created profiles with randomly assigned Avatars are shown in the profile manager

Confirmed data correctly imported into separate profiles Whale Person 1, Whale Person 2

Confirmed bookmarks, history, extensions imported from both profiles

Confirmed Brave Profile 1 is created and shown as expected

Confirmed extensions added via Chrome Web Store are imported and no extensions imported from Whale Store

step 3	step 4	step 6	step 8	new-tab	Profile 1	Profile 2

Case 3: Import via brave://settings/ImportData - PASSED

1. installed 1.49.99
2. launched Brave
3. clicked Skip -> Skip -> Finish
4. opened brave://settings/importData in the new-tab page
5. verified Whale Person 1 & Whale Person 2 options are displayed in the Import bookmarks and settings dropdown
6. selected Whale Person 1
7. kept default selections of Browsing history, Favorites/Bookmarks and Extensions
8. clicked Import
9. clicked Done

Confirmed bookmarks are shown on the bookmarks bar and bookmarks sidepanel in a new-tab

Confirmed bookmarks, history, extensions are imported into default profile

Confirmed importing from only one source profile, i.e. Whale Profile 1, no new Brave profile is created

Confirmed extensions added via Chrome Web Store are imported and no extensions imported from Whale Store

step 3	step 5	step 6	step 9	new-tab	bookmarks	extensions	history

Case 4: Import via Import bookmarks now... link on the bookmarks bar - PASSED

1. new profile
2. launched Brave
3. clicked Skip -> Skip -> Finish
4. clicked Import bookmarks now... in the bookmarks bar in the new-tab page
5. verified Whale option displayed in the Import bookmarks and settings modal dropdown
6. selected Whale Person 2
7. deselected default selections and selected Favorites/Bookmarks
8. clicked Import
9. clicked Done

Confirmed bookmarks are shown in the bookmarks bar , bookmarks side panel and in brave://bookmarks

step 3	step 4	step 5	step 8	step 9	new-tab page	bookmarks

Case 5: Bookmarks imported from Whale should Sync between devices - PASSED

device 1

1. new profile
2. launch Brave
3. clicked Skip
4. select Whale>> Import
5. click Select All >> Import profiles
6. click Finish
7. click Profile 1 and confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions in respective profiles
8. select Whale Person 1 from profile manager
9. visit brave://sync
10. click on Start using sync ---> Start a new Sync Chain
11. click Computer
12. copy the code words
13. under Sync Settings, click on the Sync everything radio button

step 4	step 5	step 6	new-tab	Whale Person 1	Whale Person 2	step 8	step 13

device 2

1. go to device 2
2. click on the "hamburger" menu, and then Sync
3. click I have a Sync Code
4. enter/paste the code words from device 1
5. click Confirm
6. click OK
7. under Sync Settings, click on the Sync everything toggle

Confirmed Favorites/Bookmarks, Extensions from Whale Person 1 synced successfully

Note: Browsing history not synced. Only URLs of the sites that were visited in the session are synced

step 6	bookmarks	extensions	history

Case 6: Upgrade - brave://welcome screen - PASSED

1. Install 1.48.164
2. launch Brave
3. Do not click on Set Brave as default browser button and close the browser
4. Rename the profile to Beta
5. launch with 1.49.100
6. click Set Brave as default browser
7. confirmed Whale icon/card is shown on Import Settings screen
8. select Whale >> Import
9. select Whale Person 2 >> Import profiles
10. click Finish

Confirmed Whale icon/card is shown on Import Settings screen

Confirmed bookmarks are imported and are shown bookmarks bar, brave://bookmarks, and bookmarks sidepanel

step 1	step 3	step 5	step 6	step 7	step 8	step 9	step 10	bookmarks	history	extensions

Case 7: Upgrade - brave://settings/importData screen - PASSED

1. installed 1.48.164
2. launched Brave
3. Skip>>Skip>>Finish
4. clicked Import bookmarks now... link in the bookmarks bar
5. selected Chrome Beta Person 1 in the Import bookmarks and settings modal dialog
6. kept default selections of Browsing history, Favorites/Bookmarks, Extensions and Passwords and finished the import
7. confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions into Brave
8. closed the browser
9. installed 1.49.199
10. renamed the profile to Beta and relaunched Brave
11. Browsing history, Favorites/Bookmarks, Extensions are retained from Chrome Beta Person 1 import
12. went to Hamburger menu >>Bookmarks >> Import bookmarks and settings
13. confirmed Whale Person 1 & Whale Person 2 is listed in the dropdown menu of Import bookmarks and settings modal
14. selected Whale Person 1 and kept default selections of Browsing history, Favorites/Bookmarks, Extensions
15. completed import
16. Confirmed successfully imported Browsing history, Favorites/Bookmarks, and Extensions from Whale

step 1	step 3	step 5	step 9	step 13	step 14	bookmarks	history	extensions

[stephendonner]

Verification PASSED using

Brave	1.49.97 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision	65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS	macOS Version 11.7.3 (Build 20G1116)

Prerequisite: Whale browser profile, populated with bookmarks, history, passwords, and extensions

Case 1: Import from brave://settings/importData - PASSED (*)

1. installed 1.49.79
2. launched Brave
3. clicked Skip -> Skip -> Finish
4. opened brave://settings/importData in the new-tab page
5. verified Whale Person 1 option is displayed in the Import bookmarks and settings dropdown
6. selected Whale Person 1
7. kept default selections of Browsing history, Passwords, Favorites/Bookmarks and Extensions
8. clicked Import
9. clicked Done
10. entered macOS password and clicked Always Allow at the Brave Browser Beta Helper dialog
11. opened brave://history
12. opened brave://settings/passwords
13. opened brave://bookmarks
14. opened brave://extensions

steps 4-5	steps 7-9	step 10	history	passwords	bookmarks	extensions

Confirmed bookmarks are shown in the bookmarks bar & brave://bookmarks

Confirmed history is shown in brave://history

(*)Could NOT confirm extensions import from Naver Whale Store (however, Google Chrome Store import works, see Case 5: Upgrade)

Case 2: Import from Import Bookmarks Now... - PASSED

1. new profile
2. launched Brave
3. clicked Import bookmarks now... in the bookmarks bar
4. verified Whale option displayed in the Import bookmarks and settings modal dropdown
5. selected Whale Person 1
6. deselected default selections and selected Favorites/Bookmarks
7. clicked Import
8. clicked Done
9. opened brave://bookmarks

Confirmed bookmarks are shown in the bookmarks bar and in brave://bookmarks

step 4	steps 5-7	step 8	brave://bookmarks

Case 3: Import from multiple profiles - PASSED (*)

Profiles

Whale Person 1

extensions	bookmarks	history

Whale Person 2 (cloud)

extensions	bookmarks	history

Import

example	example	example	example	example	example

Imported Whale Person 1

extensions (*)	bookmarks	history

(*) LastPass failed to import - will investigate separately

Imported Whale Person 2

extensions	bookmarks	history

Case 4: Bookmarks imported from Whale should sync between devices - PASSED

device 1

1. new profile
2. launch Brave
3. click Import bookmarks now... in the bookmarks bar
4. select Whale Person 1 from Import bookmarks and settings modal
5. keep default selections of Browsing history, Favorites/Bookmarks, Passwords, Extensions and complete import
6. confirmed successful import of Browsing history, Favorites/Bookmarks, Passwords, Extensions
7. visit brave://sync
8. click on Start using sync ---> Start a new Sync Chain
9. click Computer
10. copy the code words
11. under Sync Settings, click on the Sync everything radio button

Whale Person 1	imported	Sync code words	Sync everything

device 2

1. go to device 2
2. click on the "hamburger" menu, and then Sync
3. click I have a Sync Code
4. enter/paste the code words from device 1
5. click Confirm
6. click OK
7. under Sync Settings, click on the Sync everything toggle

Confirmed Favorites/Bookmarks, Extensions synced successfully

Note:Browsing history not synced. Only URLs of the sites that were visited in the session are synced

brave://settings/braveSync/setup	brave://bookmarks	brave://extensions

Case 5: Upgrade - PASSED

1. installed 1.48.164
2. launched Brave
3. clicked Import bookmarks now... link in the bookmarks bar
4. selected Chrome Canary Person 1 in the Import bookmarks and settings modal dialog
5. kept default selections of Browsing history, Favorites/Bookmarks, Extensions and finished the import
6. confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions into Brave
7. closed the browser
8. installed 1.49.197
9. relaunched Brave
10. Browsing history, Favorites/Bookmarks, Extensions are retained from Chrome Canary Person 1 import
11. went to Hamburger menu >>Bookmarks >> Import bookmarks and settings
12. confirmed Whale Person 1 is listed in the dropdown menu of Import bookmarks and settings modal
13. selected Whale Person 1 and kept default selections of Browsing history, Favorites/Bookmarks, Extensions
14. completed import

Confirmed successfully imported Browsing history, Favorites/Bookmarks, and Extensions from Whale

1.48.64	Import Bookmarks and Settings...	bookmarks	extensions	history

1.49.97, Whale Person 1	successful import	bookmarks	extensions	history

[btlechowski]

Verification passed on

Brave	1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision	39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS	Ubuntu 18.04 LTS

Prerequisite: Whale browser profile, populated with bookmarks, history, passwords, and extensions

Case 1: Import from brave://settings/importData - PASSED (*)

1. installed 1.49.x
2. launched Brave
3. clicked Skip -> Skip -> Finish
4. opened brave://settings/importData in the new-tab page
5. verified Whale Person 1 option is displayed in the Import bookmarks and settings dropdown
6. selected Whale Person 1
7. kept default selections of Browsing history, Passwords, Favorites/Bookmarks and Extensions
8. clicked Import
9. clicked Done
10. entered macOS password and clicked Always Allow at the Brave Browser Beta Helper dialog
11. opened brave://history
12. opened brave://settings/passwords
13. opened brave://bookmarks
14. opened brave://extensions

steps 4-5	steps 7-9	history	passwords	bookmarks	extensions

Password import is not supported on Linux

Confirmed bookmarks are shown in the bookmarks bar & brave://bookmarks

Confirmed history is shown in brave://history

(*)Could NOT confirm extensions import from Naver Whale Store (however, Google Chrome Store import works, see Case 5: Upgrade)

Case 2: Import from Import Bookmarks Now... - PASSED

1. new profile
2. launched Brave
3. clicked Import bookmarks now... in the bookmarks bar
4. verified Whale option displayed in the Import bookmarks and settings modal dropdown
5. selected Whale Person 1
6. deselected default selections and selected Favorites/Bookmarks
7. clicked Import
8. clicked Done
9. opened brave://bookmarks

Confirmed bookmarks are shown in the bookmarks bar and in brave://bookmarks

step 4	steps 5-7	brave://bookmarks

Case 3: Import via onboarding - PASSED

Case 4: Bookmarks imported from Whale should sync between devices - PASSED

Created sync:

Imported data from Whale on Browser 1

Verified bookmarks and extensions were synced

Case 5: Upgrade - PASSED

1. installed 1.48.164
2. launched Brave
3. clicked Import bookmarks now... link in the bookmarks bar
4. selected Chrome Canary Person 1 in the Import bookmarks and settings modal dialog
5. kept default selections of Browsing history, Favorites/Bookmarks, Extensions and finished the import
6. confirmed successful import of Browsing history, Favorites/Bookmarks, Extensions into Brave
7. closed the browser
8. installed 1.49.x
9. relaunched Brave
10. Browsing history, Favorites/Bookmarks, Extensions are retained from Chrome Canary Person 1 import
11. went to Hamburger menu >>Bookmarks >> Import bookmarks and settings
12. confirmed Whale Person 1 is listed in the dropdown menu of Import bookmarks and settings modal
13. selected Whale Person 1 and kept default selections of Browsing history, Favorites/Bookmarks, Extensions
14. completed import

Confirmed successfully imported Browsing history, Favorites/Bookmarks, and Extensions from Whale