Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up to #27649: Additional confirmation to end of support message is not translated #27904

Closed
btlechowski opened this issue Jan 19, 2023 · 5 comments · Fixed by brave/brave-core#16831

Comments

@btlechowski
Copy link

Follow up to #27649

Steps to Reproduce

  1. Use Windows 7/ Windows 8
  2. Run Brave in PL Polish Locale
  3. Check the Don't show again checkmark on obsolete system infobar
  4. Click x on obsolete system infobar
  5. Check the additional dialog

Actual result:

Additional confirmation to end of support message is not translated
image

Expected result:

Additional confirmation to end of support message is translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.47.177 Chromium: 109.0.5414.87 (Official Build) (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Windows 7 x64

cc @rebron @mkarolin @kjozwiak

@rebron
Copy link
Collaborator

rebron commented Jan 20, 2023

We'll cover for the translation for this string for the following languages:
Hindi
French
German
Spanish
Portuguese
Japanese
Dutch
Polish
Russian
Vietnamese
Italian
South Korean
Romanian
Simplified Chinese
Turkish

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 21, 2023
@brave-builds brave-builds added this to the 1.47.x - Release #4 milestone Jan 24, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Jan 24, 2023

Closing as brave/brave-core#16819 was directly merged into 1.47.x. The above will require 1.47.182 or higher for 1.47.x verification 👍

@kjozwiak
Copy link
Member

@btlechowski just pick ~2-3 locales from #27904 (comment) and once you're done with Win 7, I'll pick three other locales via Win 8.1 👍

@btlechowski
Copy link
Author

Verification passed on

Brave 1.47.182 Chromium: 109.0.5414.87 (Official Build) (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Hindi

image

French

image

German

image

Spanish

image

Portuguese

image

Japanese

image

Dutch

image

Polish

image

@kjozwiak
Copy link
Member

kjozwiak commented Jan 25, 2023

Verification PASSED on Win 8.1 x64 using the following build(s):

Brave | 1.47.183 Chromium: 109.0.5414.119 (Official Build) (64-bit)
--- | ---
Revision | 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS | Windows 8.1 (Build 9600.20778)

Russian

Example Example
Screenshot 2023-01-25 at 4 35 43 AM Screenshot 2023-01-25 at 4 35 55 AM

Vietnamese

Example Example
Screenshot 2023-01-25 at 4 49 04 AM Screenshot 2023-01-25 at 4 49 14 AM

Italian

Example Example
Screenshot 2023-01-25 at 5 11 23 AM Screenshot 2023-01-25 at 5 11 36 AM

South Korean

Example Example
Screenshot 2023-01-25 at 5 14 25 AM Screenshot 2023-01-25 at 5 14 35 AM

Romanian

Example Example
Screenshot 2023-01-25 at 5 17 39 AM Screenshot 2023-01-25 at 5 17 50 AM

Simplified Chinese

Example Example
Screenshot 2023-01-25 at 5 20 32 AM Screenshot 2023-01-25 at 5 20 43 AM

Turkish

Example Example
Screenshot 2023-01-25 at 5 22 58 AM Screenshot 2023-01-25 at 5 23 11 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants