Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to send all history to sync #28062

Closed
AlexeyBarabash opened this issue Jan 26, 2023 · 3 comments · Fixed by brave/brave-core#16705
Closed

Add flag to send all history to sync #28062

AlexeyBarabash opened this issue Jan 26, 2023 · 3 comments · Fixed by brave/brave-core#16705
Assignees
@AlexeyBarabash
Labels
feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.50.x - Release

Comments

@AlexeyBarabash
Copy link
Contributor

Related issue: #25650

Chromium limits history sync only to typed url transitions. When user navigates through clicking the link or through the bookmarks - the history visit doesn't get synced.

We need to add the flag, which would allow sync all history. Default value - the same as in Chromium, false.
@AlexeyBarabash AlexeyBarabash added feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 26, 2023
@AlexeyBarabash AlexeyBarabash self-assigned this Jan 26, 2023
@AlexeyBarabash AlexeyBarabash mentioned this issue Jan 26, 2023
Merged
25 tasks
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Jan 26, 2023
@AlexeyBarabash
Send all history to sync server under the flag
ec67e8b 
Fixes brave/brave-browser#28062
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Jan 27, 2023
@AlexeyBarabash
Send all history to sync server under the flag
cc9e88b 
Fixes brave/brave-browser#28062
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Feb 1, 2023
@AlexeyBarabash
Send all history to sync server under the flag
03c7467 
Fixes brave/brave-browser#28062

When send all history is enabled, we send only 20 first visits per url and then each 10th
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Feb 2, 2023
@AlexeyBarabash
Send all history to sync server under the flag
5b4ea20 
Fixes brave/brave-browser#28062

When send all history is enabled, we send only 20 first visits per url and then each 10th.
RELOAD transitions are still ignored, as it happens on the upstream
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Feb 3, 2023
@AlexeyBarabash
Sync all history (#16705)
23a0322 
Send all history to sync server under the flag

Fixes brave/brave-browser#28062

When send all history is enabled, we send only 20 first visits per url and then each 10th.
RELOAD transitions are still ignored, as it happens on the upstream
@AlexeyBarabash AlexeyBarabash added this to the 1.50.x - Nightly milestone Feb 3, 2023
@stephendonner
Copy link

stephendonner commented Mar 20, 2023 •
edited
Loading

Verified PASSED using

Brave 1.50.92 Chromium: 111.0.5563.64 (Official Build) beta (x86_64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 11.7.4 (Build 20G1120)

Steps:

  1. installed 1.50.92
  2. launched Brave
  3. set brave://flags/#brave-sync-send-all-history to Enabled
  4. clicked Relaunch
  5. on desktop1, clicked on the 3-dots menu
  6. clicked on Sync
  7. clicked on Start a New Sync Chain
  8. joined the Sync chain from desktop2
  9. on desktop1, desktop2, and android1, enabled History, under Sync data
  10. on desktop1, loaded brave.com
  11. scrolled down to the footer
  12. clicked on F.A.Q.
  13. chose a question about ads, and clicked it
  14. opened brave://history on desktop2
  15. opened brave://history on android1
  16. confirmed history was synced
  17. on desktop1, opened brave://bookmarks and created an entry for BAT/https://basicattentiontoken.org
  18. clicked on it
  19. visited brave://history on desktop2
  20. visited brave://history on android1

Confirmed all history was synced among the 3 devices

Steps 1-9

desktop1 desktop2 android1
Screen Shot 2023-03-20 at 4 06 04 PM Screenshot 2023-03-20 at 4 05 14 PM Screenshot_20230320-160651

Steps 10-16

desktop1 desktop2 android1
Screen Shot 2023-03-20 at 4 15 31 PM Screenshot 2023-03-20 at 4 14 28 PM Screenshot_20230320-161705

Steps 17-20

desktop1 desktop2 android1
Screen Shot 2023-03-20 at 4 36 03 PM Screenshot 2023-03-20 at 4 35 27 PM Screenshot_20230320-163439

@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 27, 2023 •
edited by GeetaSarvadnya
Loading

Verification PASSED using

Brave | 1.50.106 Chromium: 112.0.5615.39 (Official Build) beta (64-bit)
-- | --
Revision | a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Steps:

  1. installed 1.50.106
  2. launched Brave
  3. set brave://flags/#brave-sync-send-all-history to Enabled
  4. clicked Relaunch
  5. on desktop1, clicked on the 3-dots menu
  6. clicked on Sync
  7. clicked on Start a New Sync Chain
  8. joined the Sync chain from desktop2
  9. on desktop1, desktop2, and android1, enabled History, under Sync data
  10. on desktop1, loaded brave.com
  11. scrolled down to the footer
  12. clicked on F.A.Q.
  13. chose a question about ads, and clicked it
  14. opened brave://history on desktop2
  15. opened brave://history on android1
  16. confirmed history was synced
  17. on desktop1, opened brave://bookmarks and created an entry for BAT/https://basicattentiontoken.org
  18. clicked on it
  19. visited brave://history on desktop2
  20. visited brave://history on android1

Confirmed all history was synced among the 3 devices

desktop 1:

step 5 step 7 step 9 step 12 step 16 step 17
image image image image image image

desktop 2:

step 9 step 16 step 17
image image image

Android:

device sync step 9 step 15 step 20
image image image image

Verification PASSED on

Brave	1.50.108 Chromium: 112.0.5615.39 (Official Build) (64-bit) 
Revision	a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS	Linux

Steps:

  1. installed 1.50.108
  2. launched Brave
  3. set brave://flags/#brave-sync-send-all-history to Enabled
  4. clicked Relaunch
  5. on desktop1, clicked on the 3-dots menu
  6. clicked on Sync
  7. clicked on Start a New Sync Chain
  8. joined the Sync chain from desktop2
  9. on desktop1, desktop2, and android1, enabled History, under Sync data
  10. on desktop1, loaded brave.com
  11. scrolled down to the footer
  12. clicked on F.A.Q.
  13. chose a question about ads, and clicked it
  14. opened brave://history on desktop2
  15. opened brave://history on android1
  16. confirmed history was synced
  17. on desktop1, opened brave://bookmarks and created an entry for BAT/https://basicattentiontoken.org
  18. clicked on it
  19. visited brave://history on desktop2
  20. visited brave://history on android1

Confirmed all history was synced among the 3 devices

desktop 1:

Example Example Example Example
image image image image

desktop 2:

Example Example
image image

Android:

Example Example Example
Screenshot_20230403-145448_Brave Screenshot_20230403-145454_Brave Screenshot_20230403-145439_Brave

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 4, 2023 •
edited
Loading

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.50.108

Steps:

  1. installed 1.50.106
  2. launched Brave
  3. set brave://flags/#brave-sync-send-all-history to Enabled
  4. clicked Relaunch
  5. on Android, clicked on the 3-dots menu
  6. clicked on Sync
  7. clicked on Start a New Sync Chain
  8. joined the Sync chain from desktop2
  9. on Android, desktop1, and android1, enabled History, under Sync data
  10. on Android, loaded brave.com
  11. scrolled down to the footer
  12. clicked on F.A.Q.
  13. chose a question about ads, and clicked it
  14. opened brave://history on desktop1
  15. opened brave://history on desktop2
  16. confirmed history was synced
  17. on desktop1, opened brave://bookmarks and created an entry for BAT/https://basicattentiontoken.org
  18. clicked on it
  19. visited brave://history on desktop1
  20. visited brave://history on desktop2

Confirmed all history was synced among the 3 devices

Android:

Example Example Example Example Example Example Example Example Example Example
Screenshot_20230404-182931_Brave Screenshot_20230404-183539_Brave Screenshot_20230404-183548_Brave Screenshot_20230404-183609_Brave Screenshot_20230404-183614_Brave Screenshot_20230404-183618_Brave Screenshot_20230404-183624_Brave Screenshot_20230404-183629_Brave Screenshot_20230404-183635_Brave Screenshot_20230404-184050_Brave

desktop 1:

Example Example
image image

desktop 2:

Example Example
image image

@LaurenWags LaurenWags mentioned this issue Apr 4, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Apr 6, 2023
Closed
@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Sync - All platforms
Status: Completed
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

Sync all history brave/brave-core
5 participants
@stephendonner @AlexeyBarabash @LaurenWags @GeetaSarvadnya @MadhaviSeelam