Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_signTransaction is using selected network for display #28564

Closed
StephenHeaps opened this issue Feb 16, 2023 · 2 comments
Closed

eth_signTransaction is using selected network for display #28564

StephenHeaps opened this issue Feb 16, 2023 · 2 comments
Assignees
Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include

Comments

@StephenHeaps
Copy link

Description

eth_signTransaction is using the currently selected network, so it may display SOL if Solana network is selected

Steps to Reproduce

  1. Load/run https://github.com/bbondy/eth-manual-tests
  2. Select Solana network in wallet panel
  3. Input to address in field beside eth_signTransaction
  4. Select eth_signTransaction

Actual result:

Screen.Recording.2023-02-16.at.1.47.27.PM.mov

Expected result:

Does not display SOL

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 1.50.41 Chromium: 110.0.5481.100 (Official Build) nightly (arm64)

Version/Channel Information:

Nightly

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@josheleonard josheleonard self-assigned this Feb 16, 2023
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 17, 2023
@jamesmudgett jamesmudgett moved this to In Progress in Web3 Feb 17, 2023
@josheleonard
Copy link

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.57.18 Chromium: 115.0.5790.98 (Official Build) beta (64-bit)
Revision d515871a6c6df7d2843e755c8b7dda9b744f26d6
OS Windows 11 Version 22H2 (Build 22621.1992)
  • Verified steps from issue description
  • Verified eth_signTransaction shows the correct token balance and network name on panel
28564.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

No branches or pull requests

4 participants