Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "social media blocking" setting in brave://settings to brave://settings/shields #28658

Closed
pes10k opened this issue Feb 21, 2023 · 5 comments
Assignees
Labels
design A design change, especially one which needs input from the design team feature/settings OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes

Comments

@pes10k
Copy link
Contributor

pes10k commented Feb 21, 2023

Currently we have toplevel option in brave://settings called "Social media blocking" that has four (soon to be three) toggles.

I'd be nice to move these options somewhere else for a couple of reasons:

  1. to move more of the content filtering options to the same place brave://settings/shields/filters
  2. the formatting of the text label wraps to two lines (the only top level option that does) and so looks awkward
  3. featuring these options as top level options (parallel to "Shields" and "Search engine" etc) is promoting a very niche setting with pretty valueable settings real-estate
@pes10k pes10k added OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 21, 2023
@rebron rebron added feature/settings priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes design A design change, especially one which needs input from the design team labels Feb 21, 2023
@rebron rebron changed the title Move "social media blocking" setting in brave://settings to brave://settings/shields/filters Move "social media blocking" setting in brave://settings to brave://settings/shields Sep 13, 2023
@rebron
Copy link
Collaborator

rebron commented Sep 14, 2023

Closing as dupe of #32956 and fixed in latest nightly, 1.60.x

@rebron rebron closed this as completed Sep 14, 2023
@rebron rebron reopened this Sep 14, 2023
@rebron rebron removed the OS/Desktop label Sep 14, 2023
@rebron
Copy link
Collaborator

rebron commented Sep 14, 2023

Re-opening for Android.

@deeppandya deeppandya self-assigned this Sep 20, 2023
@deeppandya
Copy link

@pes10k what should be the priority of this issue ?

@pes10k
Copy link
Contributor Author

pes10k commented Nov 20, 2023 via email

@ShivanKaul
Copy link
Collaborator

I checked with @deeppandya and the current Settings screen on Android looks fine to me. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/settings OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes
Projects
None yet
Development

No branches or pull requests

5 participants