Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move brave://settings/socialBlocking to brave://settings/shields #32956

Closed
rebron opened this issue Sep 13, 2023 · 1 comment · Fixed by brave/brave-core#20160
Closed

Move brave://settings/socialBlocking to brave://settings/shields #32956

rebron opened this issue Sep 13, 2023 · 1 comment · Fixed by brave/brave-core#20160

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 13, 2023

Description

Move brave://settings/socialBlocking section to brave://settings/shields.
Remove Social media blocking from left navigation.

Expected result:

Screenshot 2023-09-12 at 8 28 49 PM

Current result:

In 1.58.x and 1.59.x
Screenshot 2023-09-12 at 8 29 11 PM
Screenshot 2023-09-12 at 8 29 23 PM

Brave version (brave://version info)

Targeting 1.60.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@simonhong simonhong self-assigned this Sep 14, 2023
simonhong added a commit to brave/brave-core that referenced this issue Sep 14, 2023
fix brave/brave-browser#32990
fix brave/brave-browser#32956
fix brave/brave-browser#32954

Moved social blocking menu as a shields' sub section.
Moved new tab menu as a get started's sub section.
@brave-builds brave-builds added this to the 1.60.x - Nightly milestone Sep 14, 2023
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 9, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Oct 9, 2023

Verified with

Brave | 1.60.81 Chromium: 118.0.5993.54 (Official Build) beta (x86_64)
-- | --
Revision | 1efb3f333eb41cc34af46ca31fb33c30e0afbfae
OS | macOS Version 13.6 (Build 22G120)

Compared 1.58.x to 1.60.x
Confirmed "Social media blocking" is removed from left navigation.
Confirmed brave://settings/socialBlocking section is moved to brave://settings/shields.

  • Note, checked when #brave-google-sign-in-permission is both enabled and disabled on 1.60.x, as this is enabled via griffin 100% on beta (1.60.x) but only enabled 25% on release (1.58.x) at this time.
1.58.137 1.58.137 1.60.81 (flag enabled) 1.60.81 (flag disabled)
1 58 1 58b 1 60 google enabled v griffin 1 60 google disabled

Also confirmed "Social media blocking" setting selections were retained on upgrade:

  1. Created profile with 1.58.x
  2. Changed "Social media blocking" settings
  3. Closed browser
  4. Renamed profile to be for Beta
  5. Relaunched with Beta
  6. Confirmed settings moved to display under brave://settings/shields
  7. Confirmed setting values were as expected (remember, #brave-google-sign-in-permission is enabled 100% on Beta, so the Google setting is not shown on Beta)
  8. Changed the value of #brave-google-sign-in-permission to be "Disabled" and relaunched
  9. Confirmed the Google setting now displays under brave://settings/shields and shows expected value
Step 2 Step 7 Step 9
2 7 9

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants