Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align text on Brave VPN promotion screen #28755

Closed
rebron opened this issue Feb 24, 2023 · 3 comments · Fixed by brave/brave-core#17378
Closed

Align text on Brave VPN promotion screen #28755

rebron opened this issue Feb 24, 2023 · 3 comments · Fixed by brave/brave-core#17378
Assignees
Labels

Comments

@rebron
Copy link
Collaborator

rebron commented Feb 24, 2023

Description

The second line in the promotion text should be aligned with the rest of the text and not the checkmarks.

Steps to Reproduce

  1. Open the Brave VPN panel.
  2. Notice second bulleted item in screenshot in Actual result
  3. Text should be aligned with other text and not the checkmarks.

Actual result:

Screenshot 2023-02-24 at 2 20 05 PM

Expected result:

Text should be aligned.

Screenshot 2023-02-24 at 2 31 42 PM

Reproduces how often:

Easily.

Brave version (brave://version info)

1.49.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron added OS/Desktop feature/vpn polish Nice to have — usually related to front-end/visual tasks priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Feb 24, 2023
@stephendonner stephendonner added the feature/user-interface All UI related label Feb 25, 2023
@stephendonner
Copy link

stephendonner commented Feb 25, 2023

@kjozwiak
Copy link
Member

The above requires 1.49.116 or higher for 1.49.x verification 👍

@stephendonner
Copy link

Verified PASSED using

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Windows 10 Version 22H2 (Build 19045.2673)

Steps:

  1. installed 1.49.118
  2. launched Brave
  3. loaded brave://flags
  4. enabled Brave VPN flag
  5. clicked on Relaunch
  6. clicked on the VPN button

Confirmed the bulleted text all properly wraps

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants