Download indicator shows progress for insecure download, before allowing to download

[MadhaviSeelam]

Description

Found while testing #28562
for insecure download, download indicator shows progress even before clicking Continue download button. It appears to be chromium upstream issue.

Steps to Reproduce

1. installed 1.50.101
2. launched Brave
3. loaded https://www.thinkbroadband.com/download
4. context-clicked on http://ipv4.download.thinkbroadband.com:8080/1GB.zip
5. chose Save Link As...
6. clicked Save
7. clicked download button in the toolbar

Actual result:

Download indicator shows progress even before clicking blocked notification and clicking Continue to download

2023-03-24_09h46_19.mp4

Expected result:

Download should not be progressed for insecure download before clicking Continue to download

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.50.107 Chromium: 112.0.5615.39 (Official Build) beta (64-bit)
-- | --
Revision | a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @simonhong

cc: @brave/qa-team

[stephendonner]

Also good for testing is https://www.leaseweb.com/platform/network just FYI in case it helps 👍

[stephendonner]

example	example	example	example	example

[stephendonner]

Verification PASSED using

Brave	1.52.85 Chromium: 113.0.5672.63 (Official Build) beta (64-bit)
Revision	0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}
OS	Windows 10 Version 22H2 (Build 19045.2913)

Steps:

1. installed 1.52.85
2. launched Brave
3. loaded https://www.leaseweb.com/platform/network
4. context-clicked on a 10,000 mb file
5. chose Save link as...
6. clicked Save in the file picker
7. examined the Downloads button on the browser toolbar
8. clicked on the yellow warning icon
9. clicked on the (blocked) filename
10. clicked on Continue download (also quickly confirmed Delete removed the file)
11. (confirmed dialog closed)
12. clicked again on the (now) download-progress icon

Confirmed the warning icon appears disappears, appropriately, as well as the ability to resume blocked downloads

Dark

warning icon	flyout dialog w/icon	continue download	downloaded resumed

Light

warning icon	flyout dialog w/icon	continue download	downloaded resumed