Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Flash plan for the first release #30

Closed
bbondy opened this issue Dec 5, 2017 · 3 comments
Closed

Make Flash plan for the first release #30

bbondy opened this issue Dec 5, 2017 · 3 comments

Comments

@bbondy
Copy link
Member

bbondy commented Dec 5, 2017

Chrome's Flash deprecation policy is here:
https://www.chromium.org/flash-roadmap

As of C68 we'll have:

Non-Persisted HTML5 by Default (Target: Chrome 68 - July 2018)
Summary
Sites using Flash will require explicit permission to run, every time the user restarts the browser.
Rationale
Require affirmative user choice to run Flash Player content, without that choice persisting across multiple sessions.

For the initial version that is OK.

We can diverge from the Disable by default (Chrome 76+ - July 2019) and Remove Flash completely ( Dec 2020) in separate issues.

@bbondy bbondy added this to the Milestone 3: To be able to market and release 1.0 milestone Dec 5, 2017
cezaraugusto pushed a commit that referenced this issue May 15, 2018
One RegisterProfilePrefs to rule them all
@bbondy bbondy changed the title Make sure Flash disabling is close to parity to browser-laptop Make Flash plan for the first release May 23, 2018
@bbondy
Copy link
Member Author

bbondy commented May 23, 2018

CC @diracdeltas in case there are objections. See above #30 (comment)

@bbondy bbondy closed this as completed May 23, 2018
@bbondy bbondy modified the milestones: Milestone 3: To be able to market and release 1.0, Milestone 2: To offer Installable and updatable builds May 23, 2018
@bbondy bbondy reopened this May 23, 2018
@bbondy
Copy link
Member Author

bbondy commented May 23, 2018

Talked to @diracdeltas and she'd like to match this milestone:
https://www.chromium.org/flash-roadmap#TOC-Flash-Disabled-by-Default-Target:-Chrome-76---July-2019-

So re-opening.

bbondy added a commit to brave/brave-core that referenced this issue May 28, 2018
bbondy added a commit to brave/brave-core that referenced this issue May 31, 2018
@bbondy bbondy modified the milestones: Milestone 2: To offer Installable and updatable builds, Releasable builds Jun 13, 2018
@srirambv
Copy link
Contributor

srirambv commented Sep 20, 2018

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
  • Verified visiting http://homestarrunner.com/ showed Plugin blocked message on URL bar
  • Verified clicking Run flash this time reloads the page
  • Verified Enable Plugin is shown in right click context menu after page reloads, clicking it loads the flash content

Verification PASSED on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Verification passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X
  • Verified visiting http://homestarrunner.com/ showed Plugin blocked message on URL bar
  • Verified clicking Run flash this time reloads the page
  • Verified Enable Plugin is shown in right click context menu after page reloads, clicking it shows prompt, clicking Allow loads the flash content
  • Verified clicking on the 'Click to enable Adobe Flash Player', clicking it shows prompt, clicking Allow loads the flash content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants