-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FBD] Synchronize ephemeral and first party storage cleanup event #30090
Comments
Include all test cases from brave/brave-variations#567 (comment) Additional test casesTest case 1
Test case 2
Test case 3
|
Verification
Verification is passed for all the tests (i.e Test Case 1 - Test Case 7) as below using STR from #30090 (comment). However, Additional testcases were skipped as per the discussion.Test Case 1 - Enabling
|
step 3 | step 5 | step 6 |
---|---|---|
Case 2: After feature being enabled via Griffin - PASSED
- continue from Case 1:
BraveForgetFirstPartyStorage
isn't visible underbrave://version
Forget me when I close this site
toggle doesn't appear viabrave://settings/shields
- closed and restarted Brave
- confirmed
BraveForgetFirstPartyStorage:Enabled
is shown inbrave://version
- opened Shields panel in the nytimes.com tab
- opened brave://settings/shields
- Confirmed
Forget me when I close this site
toggle appears in the Shields panel and isOff
by default - Confirmed
Forget me when I close this site
toggle appears in thebrave://settings/shields
and isOff
by default
step 3 | step 4 | step 5 |
---|---|---|
Dark theme
shields panel | brave://settings/shields |
---|---|
Test Case 2: Enable Forget me when I close this site
setting in the Shields panel per domain - PASSED
Case 1 - Enable Forget me when I close this site
setting in the Shields panel and toggle per site and wait 30s - PASSED
- continued from Case 2 (Test Case 1)
BraveForgetFirstPartyStorage
is shown underbrave://version
Forget me when I close this site
toggle isOff
is shown via the Shields panel for git.luolix.topForget me when I close this site
toggle isOff
is shown viabrave://settings/shields
- visited into https://www.github.com and logged into the account
- visited https://www.nytimes.com and logged into the account
- confirmed password credentials for both github.com & nytimes.com are saved in
brave://settings/passwords
- confirmed
github.com
&nytimes.com
entries are shown inbrave://settings/content/all
- restarted the browser and confirmed that I am still logged into both nytimes & Github
- toggled
Forget me when I close this site
On
for nytimes.com &github.com
in the Shields panel - closed both tabs for the sites (nytimes & Github) and wait for ~30sec
- reopened
brave://settings/content/all
in a new tab - confirmed both
github.com
&nytimes.com
have been completely removed frombrave://settings/content/all
- reloaded both https://github.com & https://www.nytimes.com sites
- confirmed that I have been logged out of both the sites i.e.
github.com
&nytimes.com
- confirmed
nytimes.com
andgit.luolix.top
entries haven't been removed/cleared frombrave://history
- confirmed that passwords are not being removed via
brave://settings/passwords
confirmed nytimes.com & github.com sites are removed from brave://settings/content/all
confirmed that passwords entries are not removed via brave://settings/passwords
confirmed when nytimes.com & github.com sites are reloaded, I am signed out of both the sites
step 1 | step 4 | step 5 | step 7a | step 7b | step 10 | step 12a | step 12b | step 13 | step 14 |
---|---|---|---|---|---|---|---|---|---|
Case 2 - Enable Forget me when I close this site
setting in the Shields panel and reopen a site within 30 secs - PASSED
- new profile
- launched Brave
- relaunched Brave and verified following:
BraveForgetFirstPartyStorage
is shown underbrave://version
Forget me when I close this site
toggle is shown viabrave://settings/shields
- logged into https://www.nytimes.com & github.com and saved password credentials
- confirmed password credentials are saved in
brave://settings/passwords
for both the sites - confirmed
nytimes.com
&github
entries shown inbrave://settings/content/all
- opened the Shields panel for https://www.nytimes.com site and verified
Forget me when I close this site
toggle isOFF
- toggled
On
/enableForget me when I close this site
setting in the Shields panel - closed both sites, nytimes.com & github.com (but not the browser)
- confirmed
nytimes.com
entry is still shown inbrave://settings/content/all
- confirmed password credentials are still shown in
brave://settings/passwords
- re-loaded the `nytimes.com site within ~30s (15s) and confirmed I am still logged into the site
- reloaded github.com site within ~30s (15s) and confirmed I am still logged into the site
- open brave://history in a new tab
- Confirmed when nytimes.com is reloaded within 30 secs,
nytimes.com
entry is still shown inbrave://settings/content/all
- Confirmed password credentials are still shown in
brave://settings/passwords
- Confirmed when nytimes.com site is reloaded, I am still signed in to the site
- Confirmed brave://history is not cleared
step 3a | step 3b | step 5 | step 6 | step 8a | step 8b | step 10 | step 11 | step 12 | step 13 |
---|---|---|---|---|---|---|---|---|---|
Additionally ran through this using different times. Example: within 5s, 10s, 20s confirmed storage wasn't removed as below:
within 20s
---- | ---- | ----
- new profile
- verified with https://nytimes.com
- followed test steps from above and loaded the website within ~20 secs
- confirmed still logged into nytimes.com
- confirmed
brave://settings/all
shows the sitenytimes.com
- confirmed
brave://settings/passwords
shows saved passwords
example | example | example | example |
---|---|---|---|
within 10s
- new profile
- verified with https://bloomberg.com
- followed test steps from above and loaded the website within ~10 secs
- confirmed still logged into bloomberg.com & github.com
- confirmed
brave://settings/all
shows the sitebloomberg.com
& github.com - confirmed
brave://settings/passwords
shows saved passwords - confirmed browsing history is not clearing in
brave://history
example | example | example |
---|---|---|
within 5s
- new profile
- https://microsoft.com/
- followed test steps from above and loaded the website within ~5 secs
- confirmed still logged into nytimes.com
- confirmed
brave://settings/all
shows the sitemicrosoft.com
& - confirmed
brave://settings/passwords
shows saved passwords
example | example | example |
---|---|---|
Continued from above and waited ~30 sec and confirmed the storage has been removed
step 14 | step 15 | step 16 | step 17 |
---|
- logged into both github.com & nytimes.com sites
- enabled
Forget me when I close the site
setting for both the sites in the Shields panel - github.com & nytimes.com are shown in brave://settings/content all
- passwords entries are shown in brave://settings/passwords
- closed both sites nytimes and github and waited ~30s
- verified nytimes.com is removed from
brave://settings/content/all
- verified that passwords entries are not removed via
brave://settings/passwords
- verified that browsing history in
brave://history
hasn't been removed - verified when https://www.nytimes.com/ reloaded, I am signed out of the site
- verified when https://www.github.com/ reloaded, I am signed out of the site
step 1a | step 1b | step 6 | step 7 | step 8 | step 9 | step 10 |
---|---|---|---|---|---|---|
Test Case 3 - Enabling BraveForgetFirstPartyStorage (Permissions) - PASSED
Case 1: Select until I close this site
in the permission prompt for talk.brave.com
while not logged in - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear under brave://settings/shields
- visited https://talk.brave.com/
- keep the default value
until I close this site
permissions in the permission prompt for both Microphone & Camera - clicked
Allow
to give permissions for both Microphone & Camera - clicked on the lock icon via https://talk.brave.com/ and confirmed Microphone & Camera permissions are enabled
- confirmed brave.com entry is shown in brave://settings/content/all
- confirmed when drill down brave.com>>cookies and site Data, local storage data is shown
- toggled
Forget me when I close this site
On
via the shields panel - closed https://talk.brave.com/ tab and waited ~30s
- confirmed
brave.com
is removed inbrave://settings/content/all
- confirmed that both Microphone & Camera are shown default values
Ask (default)
in brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com - confirmed no entries are shown in
Allowed to use your camera
via brave://settings/content/camera & brave://settings/content/microphone
step 1a | step 1b | step 2a | step 2b | step 5 | step 6 | step 7 | step 8 | step 10 | step 11 | step 12a | step 12b |
---|---|---|---|---|---|---|---|---|---|---|---|
Case 2: Select Forever
in the permissions prompt for talk.bravesoftware.com
while logged in - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear underbrave://settings/shields
- logged in to https://talk.bravesoftware.com/ and click
Start Premium call
and join the meeting - selected
Until I close this site
for microphone andForever
for Camera permissions in the permission prompt - clicked
Allow
to give permissions for both Microphone & Camera - clicked on the lock icon via https://talk.bravesoftware.com/ URL and confirmed Microphone & Camera permissions are enabled
- verified site settings for
Camera
andMicrophone
showAllow
via brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com - verified bravesoftware.com entry is shown in
brave://settings/content/all
- verified local storage data is shown when drill down brave.com>>cookies and site Data
- verified
brave://settings/content/camera
showstalk.bravesoftware.com:443
entry - verified
brave://settings/content/microphone
showstalk.bravesoftware.com:443
entry - toggled
Forget me when I close this site
on
via the shields panel for https://talk.bravesoftware.com/ - closed https://talk.bravesoftware.com/ tab including subscription page tab and waited ~30s
- confirmed
bravesoftware.com
is shown with 0 B inbrave://settings/content/all
- confirmed local storage is removed via bravesoftware.com>>cookies and Site Data, which is the pass condition
- confirmed that Microphone shows
Ask (default)
& Camera shown values `Ask in brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com which is expected given the permissions - confirmed entries
https://talk.bravesoftware.com:443
is shown inAllowed to use your camera
via brave://settings/content/camera which is expected given the permissions - confirmed no entries are shown in
Allowed to use your microphone
via brave://settings/content/microphone
step 1 | step 2a | step 2b | step 5 | step 6 | step 7 | step 8 | step 11 | step 13 | step 14 | step 15 | step 16 | step 17 |
---|---|---|---|---|---|---|---|---|---|---|---|---|
Test Case 4 : Enable BraveForgetFirstPartyStorage global value via brave://settings/shields - PASSED
Case 1: Enable Forget me when I close this site
in brave://settings/shields
but leave the setting enabled per site - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear underbrave://settings/shields
- enabled
Forget me when I close this site
viabrave://settings/shields
- visited https://netflix.com/ and ensure that
Forget me when I close this site
is enabled via the shields panel - logged into https://netflix.com
- confirmed password credentials are saved in
brave://settings/passwords
(saved passwords shown only for hbomax) - confirmed netflix.com entries are shown within
brave://settings/content/all
- leave
Forget me when I close this site
for https://netflix.com` via brave shields panel - closed https://www.netflix.com/ tab and wait ~30s
- reopened/reloaded
brave://settings/content/all
tab - confirmed netflix.com entry is removed from
brave://settings/content/all
- confirmed that passwords are not being removed via
brave://settings/passwords
- reopened https://www.netflix.com/
- confirmed I am logged out of the website
- confirmed that
brave://history
hasn't been removed/cleared
step 1 | step 2 | step 3 | step 4 | step 5 | step 6 | step 10 | step 11 | step 13 | step 14 |
---|---|---|---|---|---|---|---|---|---|
Case 2: Enable Forget me when I close this site
in brave://settings/shields
but disable the setting per site - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear and isOff
underbrave://settings/shields
- enabled
Forget me when I close this site
viabrave://settings/shields
- visited https://github.com and https://www.hbomax.com/ and verified that
Forget me when I close this site
is enabled via the shields panel - visited https://https://github.com/ and https://www.hbomax.com and logged into the websites
- confirmed password credentials are saved in
brave://settings/passwords
- confirmed github.com and max.com entries are shown within
brave://settings/content/all
with local storage - disabled
Forget me when I close this site
on https://www.github.com/ via Shields panel and also leave it enabled globally - leave
Forget me when I close this site
settingOn
for https://hbomax.com via Shields panel - closed https://www.gmail.com/ and waited ~30s
- closed https://www.hbomax/ and waited ~30s
- confirmed github.com is NOT removed from
brave://settings/content/all
- confirmed hbomax.com is removed from
brave://settings/content/all
- confirmed passwords are not being removed via brave://settings/passwords
- confirmed that brave://history hasn't been removed/cleared
- reopened https://www.hbomax.com/ and confirmed that I am logged out
- reopened https://github.com/ site and confirmed that I am still logged in
step 1 | step 2 | step 3a | step 3b | step 5 | step 6a | step 6b | step 7 | step 8 | step 11 | step 12 | step 13 | step 14 | step 15 | step 16 |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Test Case 5 - Enable BraveForgetFirstPartyStorage and disable and enable Shields - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear and isOff
in brave://settings/shields
- visited https://joinhoney.com and enabled
Forget me when I close this site
toggle via the Shields panel - log into https://joinhoney.com
- verified joinhoney.com entry in
brave://settings/content/all
and local storage data in brave://settings/cookies/detail?site=www.joinhoney.com - verified that password entry is shown via brave://settings/passwords
- disable Shields in the Shields panel for the site
joinhoney.com
- closed the tab for joinhoney.com and wait for ~30s
- opened
brave://settings/content/all
and confirmed joinhoney.com entry and local storage is removed - confirmed I am logged out of joinhoney.com and Shields is still disabled
- open https://joinhoney.com and re-enable shields on the Shields panel
- closed https://joinhoney.com/ and wait ~30s
- confirmed https://joinhoney.com is removed from brave://settings/content/all and local storage in brave://settings/cookies/detail?site=www.joinhoney.com
- confirmed that brave://history hasn't been removed/cleared
- confirmed that passwords are not being removed via brave://settings/passwords
step 1a | step 2 | step 4a | step 4b | step 5 | Step 6 | step 8a | step 8b | step 9 | step 10 | step 12a | step 12b | step 13 |
---|---|---|---|---|---|---|---|---|---|---|---|---|
Test Case 6 - Enable BraveForgetFirstPartyStorage via brave://settings/shields
but Forget me when I close this site
not enabled in the Shields panel in Guest window - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear and isOff
in brave://settings/shields
- enabled
Forget me when I close this site
viabrave://settings/shields
- click hamburger menu >> open guest window
- visited https://github.com, https://walmart.com, https://amazon.com sites in the guest window
Confirmed Forget me when I close this site
isn't enabled in the Shields panel
step 1a | step 1b | step 2 | step 3 | github | walmart | amazon |
---|---|---|---|---|---|---|
Test Case 7 - Enable Forget me when I close this site
via Shields panel in Private window - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear and isOff
inbrave://settings/shields
- click hamburger menu >> Private window
- logged into https://brave.sp.backtrace.io/login in the Private window
- close the https://brave.sp.backtrace.io tab (not the browser) and relaunch
- verified I am still logged in to https://brave.sp.backtrace.io site
- toggled
On
Forget me when I close this site
setting in the Shields panel - closed the https://brave.sp.backtrace.io tab and waited for ~30 secs and reopen the site
- confirmed I am logged out of https://brave.sp.backtrace.io site
step 1a | step 1b | step 2 | step 3 | step 6 | step 8 |
---|---|---|---|---|---|
Additional test cases - Below testcases are skipped as per the discussion.
Testcase 1 - Enable Ephemeral Storage via brave://flags - Skipped
Shared steps:
- new profile
- opened https://dev-pages.brave.software/storage/ephemeral-storage.html in a new tab
- opened
brave://flags
in a new tab and enabled#brave-ephemeral-storage
Case 1: Leave the default Cross-site cookies blocked
in the Shields panel
Step 1: Initial Case
- click Start test` on the https://dev-pages.brave.software/storage/ephemeral-storage.html
- confirmed results matched to the expected outcome on Step 1: Initial Case
Step 2: Remote Page, Same Session
- continued from Step 1 from test page
- clicked the link in the Step 2
Open up the version of this page on the other origin
- clicked
Read values
on other site - confirmed results matched to expected outcome in Step 2: Remote Page, Same Session except for Nested frame -
N/A
(N/A is valid. Site needs update to show empty)
Step 3: Remote Page, New Session
- keep the existing session (continued from Step 2)
- opened a new browser session via Brave Beta icon context menu in the taskbar
- navigated to https://dev-pages.brave.software/storage/ephemeral-storage.html in a new tab
- copy test URL and paste it in a new tab
- clicked
Read values
on the other site - confirmed results matched to expected outcome in Step 3: Remote Page, New Session except for Nested frame which shows N/A (N/A is valid. Site needs update to show empty)
Step 4: This Page, Same Session Case
-Failed
- completed Step1 & Step 2 (Same session which is a initial session)
- completed Step 3 in a new session and close the session
- return to existing session (initial session)
- navigate to Step 4 in the testpage and clicked the link
Open up the version of this page on the other origin
to open in a new tab - clicked
Read values
on the other site
Actual Results: all of the columns show success except for Nested 1p which showsN/A
Step 5: This Page, Different Session
- continued from Step 4 from test page
- click
Copy to clipboard
and paste on a new tab - confirmed results matched to expected outcome in Step 5: This Page, Different Session except for Nested frame which shows
N/A
(N/A is valid. Site needs update to show empty)
Step 6: New Page, Reset Session Case
- Close all instances and launch Brave immediately
-
complete Step 1, Step 2, Step 4 (close Step 2 tab first), Step 5 from the test page
-
close all instances but do not close Brave
-
paste below URL in a new tab
-
clicked
Read values
on the other site
-
- Actual Results: Expected results didn't match to Step 4:
- Close all instances and waited after 30 sec
- complete Step 1, Step 2, Step 4 (close Step 2 tab first), Step 5 from the test page
- close all instances but do not close Brave
- waited for 30 sec
- copy test URL and paste it in a new tab
- https://dev-pages.brave.software/storage/ephemeral-storage.html?storage-test=https%3A%2F%2Fdev-pages.bravesoftware.com%2Fstorage%2Fephemeral-storage.html%3A%3A0.5805674000129508&ephemeral-storage-setting=ON&cookie-blocking-setting=BLOCK_THIRD_PARTY
- clicked
Read values
on the other site
- Actual Results: Expected results didn't match to Step 6
- Close all instances and launch Brave immediately
step 1 | step 2 | step 3a | step 3b | step 3c |
---|---|---|---|---|
step 4 (exp.results) | step 4 (act.results) | step 5 (exp.results) | step 5 (act.results) |
---|---|---|---|
Step 6 (within 30 sec - expected results (Step4)) | Step 6 (within 30 sec - actual results (Step6)) |
---|---|
step 6 exp.results (wait for 30 secs) | step 6 (wait for 30 secs) |
---|---|
Case 2: Block all cookies
in the Shields panel - Skipped
Pre-requisite:
- Select
Block all cookies
setting the Shields panel &Forget by default
toggleOff
- Select
Cookies blocked
option in the test page
Step 1: Initial Case
- click Start test` on the https://dev-pages.brave.software/storage/ephemeral-storage.html
- confirmed results matched to the expected outcome on Step 1: Initial Case
Step 2: Remote Page, Same Session
- continued from Step 1 from test page
- clicked the link in the Step 2
Open up the version of this page on the other origin
- clicked
Read values
on other site - confirmed results matched to expected outcome in Step 2: Remote Page, Same Session except for Nested frame -
N/A
(N/A is valid. Site needs update to show empty)
Step 3: Remote Page, New Session
- keep the existing session (continued from Step 2)
- opened a new browser session via Brave Beta icon context menu in the taskbar
- navigated to https://dev-pages.brave.software/storage/ephemeral-storage.html in a new tab
- copy test URL and paste it in a new tab
- clicked
Read values
on the other site - confirmed results matched to expected outcome in Step 3: Remote Page, New Session except for Nested frame which shows N/A (N/A is valid. Site needs update to show empty)
Step 4: This Page, Same Session Case
-Failed
- completed Step1 & Step 2 (Same session which is a initial session)
- completed Step 3 in a new session and close the session
- return to existing session (initial session)
- navigate to Step 4 in the testpage and clicked the link
Open up the version of this page on the other origin
to open in a new tab - clicked
Read values
on the other site
Actual Results: all of the columns show success except for Nested 1p which showsN/A
Step 5: This Page, Different Session
- continued from Step 4 from test page
- click
Copy to clipboard
and paste on a new tab - confirmed results matched to expected outcome in Step 5: This Page, Different Session except for Nested frame which shows
N/A
(N/A is valid. Site needs update to show empty)
Step 6: New Page, Reset Session Case
- Close all instances and launch Brave immediately
- complete Step 1, Step 2, Step 4 (close Step 2 tab first), Step 5 from the test page
- close all instances but do not close Brave
- paste below URL in a new tab
- https://dev-pages.brave.software/storage/ephemeral-storage.html?storage-test=https%3A%2F%2Fdev-pages.bravesoftware.com%2Fstorage%2Fephemeral-storage.html%3A%3A0.5805674000129508&ephemeral-storage-setting=ON&cookie-blocking-setting=BLOCK_THIRD_PARTY
- clicked
Read values
on the other site
- Actual Results: Expected results didn't match to Step 4:
- Close all instances and waited after 30 sec
- complete Step 1, Step 2, Step 4 (close Step 2 tab first), Step 5 from the test page
- close all instances but do not close Brave
- waited for 30 sec
- copy test URL and paste it in a new tab
- https://dev-pages.brave.software/storage/ephemeral-storage.html?storage-test=https%3A%2F%2Fdev-pages.bravesoftware.com%2Fstorage%2Fephemeral-storage.html%3A%3A0.5805674000129508&ephemeral-storage-setting=ON&cookie-blocking-setting=BLOCK_THIRD_PARTY
- clicked
Read values
on the other site
- Actual Results: Expected results didn't match to Step 6
- Close all instances and launch Brave immediately
Step 1 | Step 2 | Step 3(exp.results) | Step 3 (act.results) | step 4 (exp.results) | step 4( act.results) |
---|---|---|---|---|---|
Step 5 (exp.results) | Step 5 (act.results) | Step 6 (exp.30 sec) | Step 6 (act.30 sec) |
---|---|---|---|
Case 3: Allow all cookies
in the Shields panel - Skipped
Test case 2 - PASSED
- new profile
- launched Brave
- loaded
usatoday.com
- clicked on the
Shields
icon - toggled
Forget me when I close this site
toOn
- toggled
Shields
toOff
for this site - closed the
usatoday.com
tab - waited 30 seconds
- opened a new tab with
usatoday.com
and verified Shields stillOff
- opened
brave://settings/content/all
- clicked through for
usatoday.com
- confirmed cookies + localstorage data was intact
step 5 | step 6 | step 9 | step 10 | step 10a |
---|---|---|---|---|
Test case 3 - PASSED
- new profile
- launched Brave
- shut down and relaunched Brave
- opened
https://permission.site/
- clicked on
Notification
- confirmed the dropdown read
Until I close this site
- clicked
Allow
- confirmed it read/set
Notification
(green in screenshot) - closed the site
- waited 30 seconds
- reopened
https://permissions.site
- confirmed
Notification
was reset` - clicked again on
Notification
- confirmed dropdown listed
Until I close this site
(again)
example | example | example | example | example |
---|---|---|---|---|
Verification
|
step 3 | step 5 | step 6 |
---|---|---|
Case 2: After feature is enabled via Griffin - PASSED
(continued from Case 1
above)
- closed and restarted Brave
- confirmed
BraveForgetFirstPartyStorage:Enabled
is shown inbrave://version
- opened Shields panel on
abcnews.com
- opened
brave://settings/shields
- Confirmed
Forget me when I close this site
toggle appears in the Shields panel and is toggled toOff
by default - Confirmed
Forget me when I close this site
toggle appears inbrave://settings/shields
and isOff
by default
step 2 | step 3 | step 4 |
---|---|---|
Testcase 2: Enable Forget me when I close this site
setting in the Shields panel per domain - PASSED
Case 1: Enable Forget me when I close this site
setting in the Shields panel and toggle per site and wait 30s - PASSED
- continued from Case 2 (Test Case 1)
BraveForgetFirstPartyStorage
is shown underbrave://version
Forget me when I close this site
toggle isOff
is shown via the Shields panel for git.luolix.topForget me when I close this site
toggle isOff
is shown viabrave://settings/shields
- visited into https://www.github.com and logged into the account
- visited https://www.nytimes.com and logged into the account
- confirmed password credentials for both github.com & nytimes.com are saved in
brave://settings/passwords
- confirmed
github.com
&nytimes.com
entries are shown inbrave://settings/content/all
- restarted the browser and confirmed that I am still logged into both nytimes & Github
- toggled
Forget me when I close this site
On
for nytimes.com &github.com
in the Shields panel - closed both tabs for the sites (nytimes & Github) and wait for ~30sec
- reopened
brave://settings/content/all
in a new tab - confirmed both
github.com
&nytimes.com
have been completely removed frombrave://settings/content/all
- reloaded both https://github.com & https://www.nytimes.com sites
- confirmed that I have been logged out of both the sites i.e.
github.com
&nytimes.com
- confirmed
nytimes.com
andgit.luolix.top
entries haven't been removed/cleared frombrave://history
- confirmed that passwords are not being removed via
brave://settings/passwords
confirmed nytimes.com & github.com sites are removed from brave://settings/content/all
confirmed that passwords entries are not removed via brave://settings/passwords
confirmed when nytimes.com & github.com sites are reopened, I am signed out of both sites
step 1 | step 4 | step 5 | step 7a | step 7b | step 10 | step 12a | step 12b | step 13 | step 14 |
---|---|---|---|---|---|---|---|---|---|
Case 2 - Enable Forget me when I close this site
setting in the Shields panel and reopen a site within 30 sec. - PASSED
- new profile
- launched Brave
- relaunched Brave and verified following:
BraveForgetFirstPartyStorage
is shown underbrave://version
Forget me when I close this site
toggle is shown viabrave://settings/shields
- logged into https://www.nytimes.com & github.com and saved password credentials
- confirmed password credentials are saved in
brave://settings/passwords
for both the sites - confirmed
nytimes.com
&github
entries shown inbrave://settings/content/all
- opened the Shields panel for https://www.nytimes.com site and verified
Forget me when I close this site
toggle isOFF
- toggled
On
/enableForget me when I close this site
setting in the Shields panel - closed both sites, nytimes.com & github.com (but not the browser)
- confirmed
nytimes.com
entry is still shown inbrave://settings/content/all
- confirmed password credentials are still shown in
brave://settings/passwords
- re-loaded the `nytimes.com site within ~30s (15s) and confirmed I am still logged into the site
- reloaded github.com site within ~30s (15s) and confirmed I am still logged into the site
- open
brave://history
in a new tab
- Confirmed when nytimes.com is reloaded within 30 secs,
nytimes.com
entry is still shown inbrave://settings/content/all
- Confirmed password credentials are still shown in
brave://settings/passwords
- Confirmed when nytimes.com site is reloaded, I am still signed in to the site
- Confirmed
brave://history
is not cleared
step 3a | step 3b | step 5 | step 6 | step 8a | step 8b | step 10 | step 11 | step 12 | step 13 | step 14 |
---|---|---|---|---|---|---|---|---|---|---|
Test Case 3 - Enabling BraveForgetFirstPartyStorage (Permissions) - PASSED
Case 1: Select until I close this site
in the permission prompt for talk.brave.com
while not logged in - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear under brave://settings/shields
- visited https://talk.brave.com/
- keep the default value
until I close this site
permissions in the permission prompt for both Microphone & Camera - clicked
Allow
to give permissions for both Microphone & Camera - clicked on the lock icon via https://talk.brave.com/ and confirmed Microphone & Camera permissions are enabled
- confirmed brave.com entry is shown in
brave://settings/content/all
- confirmed when drill down brave.com>>cookies and site Data, local storage data is shown
- toggled
Forget me when I close this site
On
via the shields panel - closed https://talk.brave.com/ tab and waited ~30s
- confirmed
brave.com
is removed inbrave://settings/content/all
- confirmed that both Microphone & Camera are shown default values
Ask (default)
in brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com - confirmed no entries are shown in
Allowed to use your camera
viabrave://settings/content/camera
&brave://settings/content/microphone
step 1a | step 1b | step 2a | step 2b | step 5 | step 6 | step 7 | step 8 | step 10 | step 11 | step 12a | step 12b |
---|---|---|---|---|---|---|---|---|---|---|---|
Case 2: Select Forever
in the permissions prompt for talk.brave.com
while logged in - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear underbrave://settings/shields
- logged in to https://talk.bravesoftware.com/ and click
Start Premium call
and join the meeting - selected
until I close this site
for microphone andForever
for Camera permissions in the permission prompt - clicked
Allow
to give permissions for both Microphone & Camera - clicked on the lock icon via https://talk.brave.com/ URL and confirmed Microphone & Camera permissions are enabled
- verified site settings for
Camera
andMicrophone
showAllow
viabrave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.brave.com
- verified bravesoftware.com entry is shown in
brave://settings/content/all
- verified local storage data is shown when drill down brave.com>>cookies and site Data
- verified
brave://settings/content/camera
showstalk.brave.com:443
entry - verified
brave://settings/content/microphone
showstalk.brave.com:443
entry - toggled
Forget me when I close this site
on
via the shields panel for https://talk.brave.com/ - closed https://talk.brave.com/ tab including subscription page tab and waited ~30s
- confirmed
brave.com
is shown with 0 B inbrave://settings/content/all
- confirmed local storage is removed via brave.com>>cookies and Site Data, which is the pass condition
- confirmed that Microphone shows
Ask (default)
& Camera shown values `Ask in brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.brave.com which is expected given the permissions - confirmed entry
https://talk.brave.com:443
is shown inAllowed to use your camera
viabrave://settings/content/camera
which is expected given the permissions - confirmed no entries are shown in
Allowed to use your microphone
viabrave://settings/content/microphone
step 1 | step 2a | step 2b | step 5 | step 6 | step 7 | step 8 | step 11 | step 13 | step 14 | step 15 | step 16 | step 17 |
---|---|---|---|---|---|---|---|---|---|---|---|---|
Test Case 4 : Enable BraveForgetFirstPartyStorage global value via brave://settings/shields - PASSED
Case 1: Enable Forget me when I close this site
in brave://settings/shields
but leave the setting enabled per site - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear underbrave://settings/shields
- enabled
Forget me when I close this site
viabrave://settings/shields
- visited www.hulu.com and ensure that
Forget me when I close this site
is enabled via the shields panel - logged into www.hulu.com
- confirmed password credentials are saved in
brave://settings/passwords
- confirmed www.hulu.com entries are shown within
brave://settings/content/all
- leave
Forget me when I close this site
for https://netflix.com` via brave shields panel - closed www.hulu.com tab and wait ~30s
- reopened/reloaded
brave://settings/content/all
tab - confirmed www.hulu.com entry is removed from
brave://settings/content/all
- confirmed that passwords are not being removed via
brave://settings/passwords
- reopened www.hulu.com
- confirmed I am logged out of the website
- confirmed that
brave://history
hasn't been removed/cleared
step 1 | step 2 | step 3 | step 4 | step 5 | step 6 | step 10 | step 11 | step 13 | step 14 |
---|---|---|---|---|---|---|---|---|---|
Case 2: Enable Forget me when I close this site
in brave://settings/shields
but disable the setting per site - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear and isOff
underbrave://settings/shields
- enabled
Forget me when I close this site
viabrave://settings/shields
- visited https://github.com and https://www.hbomax.com/ and verified that
Forget me when I close this site
is enabled via the shields panel - visited https://https://github.com/ and https://www.hbomax.com and logged into the websites
- confirmed password credentials are saved in
brave://settings/passwords
- confirmed github.com and max.com entries are shown within
brave://settings/content/all
with local storage - disabled
Forget me when I close this site
on https://www.github.com/ via Shields panel and also leave it enabled globally - leave
Forget me when I close this site
settingOn
for https://hbomax.com via Shields panel - closed https://www.gmail.com/ and waited ~30s
- closed https://www.hbomax/ and waited ~30s
- confirmed github.com is NOT removed from
brave://settings/content/all
- confirmed hbomax.com is removed from
brave://settings/content/all
- confirmed that
brave://history
hasn't been removed/cleared - confirmed passwords are not being removed via
brave://settings/passwords
- reopened
https://www.hbomax.com/
and confirmed that I am logged out - reopened
https://github.com/
and confirmed that I am still logged in
step 1 | step 2 | step 3a | step 3b | step 5 | step 6a | step 6b | step 7 | step 8 | step 11 | step 12 | step 13 | step 14 | step 15 | step 16 |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Test Case 5 - Enable BraveForgetFirstPartyStorage and disable and enable Shields - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear and isOff
inbrave://settings/shields
- visited att.com and enabled
Forget me when I close this site
toggle via the Shields panel - log into att.com
- verified att.com entry in
brave://settings/content/all
and local storage data inbrave://settings/cookies/detail?site=www.att.com
- verified that password entry is shown via
brave://settings/passwords
- disable Shields in the Shields panel for the site
att.com
- closed the tab for att.com and wait for ~30s
- opened
brave://settings/content/all
and confirmed att.com entry and local storage is removed - confirmed I am logged out of att.com and Shields is still disabled
- opened att.com and re-enabled Shields on the Shields panel
- closed att.com and waited ~30s
- confirmed att.com is removed from
brave://settings/content/all
and local storage in `brave://settings/cookies/detail?site=www.att.com - confirmed that
brave://history
hasn't been removed/cleared - confirmed that passwords are not being removed via
brave://settings/passwords
step 1a | step 2 | step 4a | step 4b | step 5 | Step 6 | step 8a | step 8b | step 9 | step 10 | step 12a | step 12b | step 13 | step 14 |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Test Case 6 - Enable BraveForgetFirstPartyStorage via brave://settings/shields
but not enabled in the Shields panel in Guest window - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear and isOff
in brave://settings/shields
- enabled
Forget me when I close this site
viabrave://settings/shields
- click hamburger menu >>
Open Guest window
- visited https://github.com, https://walmart.com, https://amazon.com sites in the guest window
Confirmed Forget me when I close this site
isn't enabled in the Shields panel
step 1a | step 1b | step 2 | github | walmart | amazon |
---|---|---|---|---|---|
Test Case 7 - Enable BraveForgetFirstPartyStorage
via Shields panel in Private window - PASSED
- new profile (followed STR from Test Case 1 Case 2)
BraveForgetFirstPartyStorage
is visible underbrave://version
Forget me when I close this site
toggle appear and isOff
inbrave://settings/shields
- clicked hamburger menu >> Private window
- logged into brave.sp.backtrace.io in the Private window
- closed the brave.sp.backtrace.io tab (not the browser) and relaunched
- verified I am still logged in to brave.sp.backtrace.io
- toggled
On
Forget me when I close this site
setting in the Shields panel - closed the brave.sp.backtrace.io tab and waited for ~30 secs and reopen the site
- confirmed I am logged out of brave.sp.backtrace.io
step 1a | step 1b | step 3 | step 6 | step 8 |
---|---|---|---|---|
Tests from #30090 (comment) ("Additional test cases"
)
NOTE: details in https://bravesoftware.slack.com/archives/C7VLGSR55/p1689815943379709
Test case 1 - SKIPPED/PASSED
- installed
1.57.18
- launched Brave
- shut down Brave
- relaunched
- confirmed
BraveForgetFirstPartyStorage:Enabled
Griffin study enrollment viabrave://version
- confirmed
Forget me when I close this site
toggle appears onbrave://settings/shields
- loaded
https://dev-pages.brave.software/storage/ephemeral-storage.html
- followed the page's instructions for steps 1-6
Expected:
Remote Frame
should read Success
Actual:
Remote Frame
reads empty
(continuing below)
- open a (blank) new-tab page
- close the original
https://dev-pages.brave.software/storage/ephemeral-storage.html
tab - wait 30 seconds
- open
https://dev-pages.brave.software/storage/ephemeral-storage.html
in the tab from step 9 - click
Read values
Confirmed:
N/A
in tealNested 1P Frame
column is expected, per @goodov 👍- others?
Beta 1.57.18
(Chromium: 115.0.5790.98
)
brave://version |
brave://settings/shields |
---|---|
Actual results
Step 1 |
Step 2 |
Step 3 |
Step 4 |
Step 5 |
Step 6 |
---|---|---|---|---|---|
Reference results
Ref, Step 1 |
Ref, Step 2 |
Ref, Step 3 |
Ref, Step 4 |
Ref, Step 5 |
Ref, Step 6 |
---|---|---|---|---|---|
Release 1.56.14
(Chromium: 115.0.5790.114
)
brave://version |
brave://settings/shields |
---|---|
Step 1 |
Step 2 |
Step 3 |
Step 4 |
Step 5 |
Step 6 |
---|---|---|---|---|---|
Test case 2 - PASSED
- installed
1.57.18
- launched Brave
- loaded
cnn.com
- clicked on the
Shields
icon - toggled
Forget me when I close this site
toOn
- toggled
Shields
toOff
for this site - closed the
cnn.com
tab - waited 30 seconds
- opened a new tab with
cnn.com
- opened
brave://settings/content/all
- clicked through for
cnn.com
- confirmed cookies + localstorage data was intact
example | example | example | example | example | example | example |
---|---|---|---|---|---|---|
Test case 3 - PASSED
- installed
1.57.18
- launched Brave
- shut down and relaunched Brave
- opened
https://permission.site/
- clicked on
Location
- confirmed the dropdown read
Until I close this site
- clicked
Allow
- confirmed it read/set
Location
(green in screenshot) - closed the site
- waited 30 seconds
- reopened
https://permissions.site
- confirmed
Location
was reset` - clicked again on
Location
- confirmed dropdown listed
Until I close this site
(again)
example | example | example | example | example |
---|---|---|---|---|
Removing |
Per discussion with @rebron @pes10k @MadhaviSeelam @stephendonner @LaurenWags today, QA is going to skip tests that are associated with test pages (such as https://dev-pages.brave.software/storage/ephemeral-storage.html) as noted in #30090 (comment). @pes10k noted via https://bravesoftware.slack.com/archives/C7VLGSR55/p1690918874502599?thread_ts=1689815943.379709&cid=C7VLGSR55 that this unintentionally overloads this test page and FBD + Ephemeral Storage should have their own specific (and likely separate) test page(s). When @goodov returns from PTO, @pes10k has graciously offered to sync up so that this can be sorted out (thank you!). Once FBD + Ephemeral Storage tests are in place, QA can then verify, although this likely will not be in time for the initial 1.57.x release. During today's call risk for skipping these tests was deemed minimal so the group was comfortable delaying this testing until later. |
Verified with
Verified test plan from #30090 (comment). Part 1 - Cases from brave/brave-variations#567 (comment) - PASSED Test Case 1 - Enabling `BraveForgetFirstPartyStorage` feature via Griffin - PASSEDScenario 1 - Before feature being enabled via Griffin - PASSED
Scenario 2: After feature being enabled via Griffin - PASSED
Dark theme
Test Case 2: Enable `Forget me when I close this site` setting in the Shields panel per domain - PASSEDScenario 1 - Enable
confirmed economist.com & github.com sites are removed from
|
step 1 | step 4 | step 5 | step 7a | step 7b | step 10 | step 11 | step 14a | step 14b |
---|---|---|---|---|---|---|---|---|
Scenario 2 - Enable Forget me when I close this site
setting in the Shields panel and reopen a site within 30 secs - PASSED
- new profile
- launched Brave
- relaunched Brave to pull griffin
- logged into ravelry.com and saved password credentials
- confirmed password credentials are saved in
brave://settings/passwords
- confirmed
ravelry
entry shown inbrave://settings/content/all
- opened the Shields panel for https://www.ravelry.com site and verified
Forget me when I close this site
toggle isOFF
- toggled
On
/enableForget me when I close this site
setting in the Shields panel - closed site ravelry.com (but not the browser)
- confirmed
ravelry.com
entry is still shown inbrave://settings/content/all
- confirmed password credentials are still shown in
brave://settings/passwords
- confirmed ravelry.com still shown in brave://history
- reopened the ravelry.com site within ~30s (15s) and confirmed I am still logged into the site
- reopened ravelry.com site within ~30s (15s) and confirmed I am still logged into the site
Additionally spot checked this using different times. Example: within 5s, 10s, 20s confirmed storage wasn't removed.
Also ran the below case as part of this check:
- followed test steps from above and loaded the website within ~20 secs
- confirmed still logged into ravelry.com
- confirmed
brave://settings/all
shows the site ravelry.com - confirmed
brave://settings/passwords
shows saved passwords - confirmed browsing history is not clearing in
brave://history
- closed ravelry.com
- waited 30s
- confirmed
brave://settings/all
does not show ravelry.com - confirmed
brave://settings/passwords
shows saved passwords - confirmed browsing history is not clearing in
brave://history
Test Case 3 - Enabling BraveForgetFirstPartyStorage (Permissions) - PASSED
Scenario 1: Select until I close this site
in the permission prompt for talk.brave.com
while not logged in - PASSED
(note, camera parts were skipped, couldn't get Linux VM to recognize my external webcam)
- new profile, close and relaunch to pull griffin
- visited https://talk.brave.com/
- keep the default value
until I close this site
permissions in the permission prompt for both Microphone & Camera - clicked
Allow
to give permissions for both Microphone & Camera - clicked on the lock icon via https://talk.brave.com/ and confirmed Microphone & Camera permissions are enabled
- confirmed brave.com entry is shown in brave://settings/content/all
- confirmed when drill down brave.com>>cookies and site Data, local storage data is shown
- toggled
Forget me when I close this site
On
via the shields panel - closed https://talk.brave.com/ tab and waited ~30s
- confirmed
brave.com
is removed inbrave://settings/content/all
- confirmed that both Microphone & Camera are shown default values
Ask (default)
in brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com - confirmed no entries are shown in
Allowed to use your camera
via brave://settings/content/camera & brave://settings/content/microphone
Scenario 2: Select Forever
in the permissions prompt for talk.bravesoftware.com
while logged in - PASSED
(note, skipped camera parts, couldn't get Linux VM to recognize my external webcam)
- new profile close and relaunch to pull griffin
- logged in to https://talk.bravesoftware.com/ and click
Start Premium call
and join the meeting - selected
Forever
for microphone andUntil I close this site
for Camera permissions in the permission prompt - clicked
Allow
to give permissions for both Microphone & Camera - clicked on the lock icon via https://talk.bravesoftware.com/ URL and confirmed Microphone & Camera permissions are enabled
- verified site settings for
Camera
andMicrophone
showAllow
via brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com - verified brave.com entry is shown in
brave://settings/content/all
- verified local storage data is shown when drill down brave.com>>cookies and site Data
- verified
brave://settings/content/camera
showstalk.bravesoftware.com:443
entry - verified
brave://settings/content/microphone
showstalk.bravesoftware.com:443
entry - toggled
Forget me when I close this site
on
via the shields panel for https://talk.bravesoftware.com/ - closed https://talk.bravesoftware.com/ tab including subscription page tab and waited ~30s
- confirmed
brave.com
is shown with 0 B inbrave://settings/content/all
- confirmed local storage is removed via brave.com>>cookies and Site Data, which is the pass condition
- confirmed that Microphone shows
Allow
& Camera shown values `Ask in brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com which is expected given the permissions - confirmed entries
https://talk.bravesoftware.com:443
is shown inAllowed to use your microphone
via brave://settings/content/microphone which is expected given the permissions - confirmed no entries are shown in
Allowed to use your microphone
via brave://settings/content/camera
Test Case 4 : Enable BraveForgetFirstPartyStorage global value via brave://settings/shields - PASSED
Scenario 1: Enable Forget me when I close this site
in brave://settings/shields
but leave the setting enabled per site - PASSED
- new profile and relaunched to pull griffin
- enabled
Forget me when I close this site
viabrave://settings/shields
- visited https://netflix.com/ and ensure that
Forget me when I close this site
is enabled via the shields panel - logged into https://netflix.com
- confirmed password credentials are saved in
brave://settings/passwords
- confirmed netflix.com entries are shown within
brave://settings/content/all
- leave
Forget me when I close this site
for https://netflix.com` via brave shields panel - closed https://www.netflix.com/ tab and wait ~30s
- reopened/reloaded
brave://settings/content/all
tab - confirmed netflix.com entry is removed from
brave://settings/content/all
- confirmed that passwords are not being removed via
brave://settings/passwords
- reopened https://www.netflix.com/
- confirmed I am logged out of the website
- confirmed that
brave://history
hasn't been removed/cleared
Scenario 2: Enable Forget me when I close this site
in brave://settings/shields
but disable the setting per site - InProgress
- new profile and relaunched to pull griffin
- enabled
Forget me when I close this site
viabrave://settings/shields
- visited https://github.com and https://www.hbomax.com/ and verified that
Forget me when I close this site
is enabled via the shields panel - visited https://https://github.com/ and https://www.hbomax.com and logged into the websites
- confirmed password credentials are saved in
brave://settings/passwords
- confirmed github.com and max.com entries are shown within
brave://settings/content/all
with local storage - disabled
Forget me when I close this site
on https://www.github.com/ via Shields panel and also leave it enabled globally - leave
Forget me when I close this site
settingOn
for https://hbomax.com via Shields panel - closed https://www.gmail.com/ and waited ~30s
- closed https://www.hbomax/ and waited ~30s
- confirmed github.com is NOT removed from
brave://settings/content/all
- confirmed hbomax.com is removed from
brave://settings/content/all
- confirmed passwords are not being removed via brave://settings/passwords
- confirmed that brave://history hasn't been removed/cleared
- reopened https://www.hbomax.com/ and confirmed that I am logged out
- reopened https://github.com/ site and confirmed that I am still logged in
Test Case 5 - Enable BraveForgetFirstPartyStorage and disable and enable Shields - PASSED
- new profile close and relaunch to pull griffin
- visited https://ravelry.com and enabled
Forget me when I close this site
toggle via the Shields panel - log into https://ravelry.com
- verified ravelry.com entry in
brave://settings/content/all
and local storage data in brave://settings/cookies/detail?site=www.ravelry.com - verified that password entry is shown via brave://settings/passwords
- disable Shields in the Shields panel for the site
ravelry.com
- closed the tab for ravelry.com and wait for ~30s
- opened
brave://settings/content/all
and confirmed ravelry.com entry and local storage is not removed - confirmed I am not logged out of ravelry.com and Shields is still disabled
- open https://ravelry.com and re-enable shields on the Shields panel
- closed https://ravelry.com/ and wait ~30s
- confirmed https://ravelry.com is removed from brave://settings/content/all and local storage in brave://settings/cookies/detail?site=www.ravelry.com
- confirmed that brave://history hasn't been removed/cleared
- confirmed that passwords are not being removed via brave://settings/passwords
Test Case 6 - Enable BraveForgetFirstPartyStorage via `brave://settings/shields` but `Forget me when I close this site` not enabled in the Shields panel in Guest window - PASSED
- new profile close and relaunch to pull griffin
- enabled
Forget me when I close this site
viabrave://settings/shields
- click hamburger menu >> open guest window
- visited https://walmart.com in the guest window
Confirmed Forget me when I close this site
isn't enabled in the Shields panel
Step 1 | Step 2 | Step 4 |
---|---|---|
Test Case 7 - Enable `Forget me when I close this site` via Shields panel in Private window - PASSED
- new profile close and relaunch to pull griffin
- click hamburger menu >> Private window
- logged into https://brave.sp.backtrace.io/login in the Private window
- close the https://brave.sp.backtrace.io tab (not the browser) and relaunch
- verified I am still logged in to https://brave.sp.backtrace.io site
- toggled
On
Forget me when I close this site
setting in the Shields panel - closed the https://brave.sp.backtrace.io tab and waited for ~30 secs and reopen the site
- confirmed I am logged out of https://brave.sp.backtrace.io site
Part 2 - "Additional Cases" as listed in #30090 (comment) - 2 PASSED, 1 SKIPPED
Test Case 1 - SKIPPED, see note
Skipped as per #30090 (comment)
Test Case 2 - PASSED
- Enable "Forget by default" for a website. (I used economist.com)
- Logged in, did not save password
- Disable shields on the website.
- Close the website, wait 30 seconds.
- Checked brave://settings/content/all and confirmed data was still displayed there
- Reopened site in a new tab.
- Expect "Forget by default" was not executed, i.e. cookies, local storage and other DOM storage data is intact.
- Confirmed still logged in
Test case 3 - PASSED
- Open https://permission.site/
- Trigger any permission, choose permission lifetime "until I close the site". (I used "Location")
- Close the website, wait 30 seconds, reopen it.
- Expect permission is reset.
Verified for
|
Modify ES cleanup event to trigger after 30 seconds the website is closed as discussed in the "Forget first party by default" PR: brave/brave-core#16470 (comment)
This will allow us to perform cleanup for all parts (permissions, ephemeral storage, first party storage) at the same time.
Related #26465
The text was updated successfully, but these errors were encountered: