-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new Rewards onboarding ("giftbox") #30308
Comments
Test Plan Existing profile with Rewards enabled
New profile
Also, verify any links that show on any of the slides. Existing pre-rewards 2.5 profile with Rewards not yet enabled
|
Verification PASSED on
Existing userExisting user_non connected state
Existing user_connected state
New userOnboarding via NTP_Light theme and Dark theme
Onboarding via brave://rewards_Light and Dark theme
Onboarding via a Site_Light and Dark theme
Onboarding via a Inline tip_Light and Dark theme
Existing pre-rewards 2.5 profile with Rewards enabledInstall 1.45.100 (no geo declare version) and enable rewrads and upgrade the profile to 1.57.x
Rewards TourRewards tour_click on "How does it work?" via NTP
Rewards tour_click on "How does Brave Rewards work" via Woohoo! You’re all set slide
Rewards tour_click on "Done" via Woohoo! You’re all set slide
Rewards tour_click on "How does it work?" via BR panel
Rewards tour_click on "Learn more" via brave://rewards page
|
@mkarolin Need few clarifications on the rewards onboarding tour.
cc: @Miyayes @LaurenWags |
@GeetaSarvadnya On 1) Regarding content on brave.com/rewards-tour, you can skip checking that. You can just make sure it loads properly and nothing obvious is wrong :) The actual text / images are being slightly edited. |
The brave.com/rewards-tour should only appear after the user is done onboarding (presses "Done", or presses "How does it work?" on the last slide of onboarding). If it opens twice, that is not expected cc: @mkarolin. However, if you navigated to brave.com/rewards-tour manually yourself, and then also went through onboarding, then it's expected that it opens another new tab with brave.com/rewards-tour, even if you already had a tab open with brave.com/rewards-tour (since there is no detection based on which tabs you already have open). |
@GeetaSarvadnya regarding 2, what @Miyayes said, if you already have the tour tab opened (manually or from a previous test run) we don't check if there's one already open and we'll open a new one if you go through the onboarding and click Done or "How does it work?" link again. Regarding 3, I didn't word it correctly. It's pre-rewards 2.5 profile where you joined rewards already, but haven't declared the locale. |
Verified with
Existing userExisting user_non connected state - PASSED
Existing user_connected state - PASSED
Existing grandfathered_unverified state - PASSED
New userOnboarding via NTP_Light theme and Dark theme - PASSED
Onboarding via brave://rewards_Light and Dark theme - PASSED
Onboarding via a Site_Light and Dark theme - PASSED
Onboarding via a Inline tip_Light and Dark theme - PASSED
Existing pre-rewards 2.5 profile with Rewards enabledInstall 1.45.100 (no geo declare version) and enable rewards and upgrade the profile to 1.57.x - PASSED
Rewards TourPer #30308 (comment), just spot checked the tour itself and did not compare to Figma. Generally confirmed able to navigate through the tour page, |
@brave/qa-team we should run through the following reduced cases on Linux (from #30308 (comment)): Existing user
New user
Can generally skip checking Rewards Tour per #30308 (comment) |
Description
Designs: https://www.figma.com/file/VIkvO8TBQXVBnvKn4w8iYu/BR-onboarding?type=design&node-id=0-1
Tasks
The text was updated successfully, but these errors were encountered: