Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Estimated Earnings indicator 2.0 #30351

Closed
5 tasks done
Miyayes opened this issue May 16, 2023 · 4 comments · Fixed by brave/brave-core#18587
Closed
5 tasks done

Implement Estimated Earnings indicator 2.0 #30351

Miyayes opened this issue May 16, 2023 · 4 comments · Fixed by brave/brave-core#18587
Assignees
@zenparsing
Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.57.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented May 16, 2023 •
edited
Loading

Description

Tasks
Beta Give feedback

@Miyayes for spec.
@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 18, 2023
@Miyayes Miyayes mentioned this issue May 19, 2023
Closed
This was referenced May 22, 2023
Closed
Merged
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone May 25, 2023
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 12, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 12, 2023 •
edited
Loading

Verification PASSED on

Brave | 1.57.6 Chromium: 115.0.5790.75 (Official Build) beta (64-bit)
-- | --
Revision | 3433e4d513e8454ba0243deea3d53693661dc0c3-refs/branch-heads/5790@{#1430}
OS | Windows 10 Version 22H2 (Build 19045.3208)

Existing users

Grandfathered unconnected state_view regular ads_PASSED
  1. Clean profile 1.47.119 beta build
  2. Enable rewards
  3. Confirmed that the estimated earnings is 0.000 BAT

1.47.119

Example Example Example Example
image image image image
  1. Upgrade the profile to 1.57.x
  2. Estimated earning is displayed as -- Learn more
  3. View an Ad (ad notification count is 1 but the estimated earnings is still -- Learn more
  4. Connect a custodian
  5. The estimated earnings range is displayed as 0.040 - 0.050 BAT as expected

1.57.6

Example Example Example Example Example Example
image image image image image image
Grandfathered connected state_view regular ads_PASSED
  1. Clean profile 1.47.119 beta build
  2. Enable rewards and connect a custodian
  3. Confirmed that the estimated earnings is 0.000 BAT

1.47.119

Example Example Example Example
image (1) image image (2) image (3)
  1. Upgrade the profile to 1.57.x
  2. Confirmed that the estimated earnings is 0.000 BAT
  3. View a regular ad
  4. Confirmed that the estimated earnings range is displayed as 0.008 - 0.010 BAT as expected
  5. The lower bound is multiplied by 0.8x

1.57.6

Example Example Example Example
image image image image
Connected state_view regular ads and then upgrade_PASSED
  1. Install 1.53.100 beta build
  2. Enable rewards and connect a uphold custodian
  3. View couple of ads (I have viewed 3 ads )
  4. Confirmed that the estimated earnings 0.030 BAT is displayed on the brave://rewrads, BR panel and NTP widget

1.53.100

Brave://rewards BR panel NTP
image image image
  1. Upgrade the profile to 1.57.x beta build
  2. Confirmed that the ads estimated earning 0.030 BAT in converted into estimated earning range of 0.024 - 0.030 BAT
  3. I have got one more ad when I upgrade the profile
  4. So total no of ads viewed is 4
  5. Confirmed that the Estimated earning range is displayed as 0.032 - 0.040 BAT in the brave://rewrads, BR panel and NTP
  6. Confirmed that the lower bound is multiplied by 0.8x for each ad (i.e 4 ads * 0.08 = 0.032)

1.57.x

Brave://rewards BR panel NTP no of ads viewed
image image image image
  1. Confirmed that few ads are redeemed/cashed in with the server (3 ads are redeemed with server in my case)
  2. Close the browser
  3. Advanvce the sys clock to begining of the next month (before payout date), I have set it to 3rd Aug
  4. Relaunch the browser
  5. Confirmed that the estimated earning range is shown correctly in the payout pending message
Brave://rewards BR panel NTP
image image image
Connected state_view regular ads +NTPSI's and then upgrade_PASSED
  1. Install 1.53.100 beta build
  2. Enable rewards in production env, select Cayman Island from the country dropdown
  3. View a NTPSI
  4. Connect to production uphold account
  5. View 2nd NTP SI
  6. View a regular ad
  7. Total no of ads viewed are 3 (2 NTPSI + 1 regular ad)
  8. Confirmed that the estimated earnings 0.020 BAT is displayed on the brave://rewrads, BR panel and NTP widget

1.53.100

Brave://rewards BR panel NTP ad_typs from DB
image image image image
  1. Upgrade the profile to 1.57.x
  2. I have got a regular ad after the upgrade to 1.57.x
  3. Total no of ads viewed are 4 (2 NTP SI + 2 Regular ads)
  4. Estimated earnings range is 0.028 - 0.045 BAT as expected

1.57.x

Brave://rewards BR panel NTP ad_typs from DB
image image image image
Connected state_view NTPSI's and then upgrade_PASSED
  1. Install 1.53.100 beta build
  2. Enable rewards in production env, select Cayman Island from the country dropdown
  3. View a NTPSI
  4. Connect to production uphold account
  5. Upgrade the profile to 1.57.x (sceenshots not taken for 1.57.x)
  6. Confirmed that the estimated earnings range is shown as expected 0.000 - 0.005 BAT
  7. Lower bound is 0.000 BAT which is expected as 0.8x is not multiplied for the NTPSI ad
  8. Max bound is 0.005 BAT is as expected
Brave://rewards BR panel NTP
image image (1) image (2)

New users

Case 1: Verify default estimated earnings value_PASSED
  1. Clean profile 1.57.x
  2. Enable rewards and connect a custodian
  3. Verify the default Estimated earnings value
  4. Confirmed that the Estimated earnings value is 0.000 BAT in the brave://rewrads, BR panel and NTP
Brave://rewards BR panel NTP
image image image
Case 2: Verify the estimated earnings range when a regular or default ad is viewed_PASSED
  1. Clean profile 1.57.x
  2. Enable rewards and connect a custodian
  3. View a Ad
  4. Verify the Estimated earning on the UI
  5. Confirmed that the Estimated earning range is 0.008 - 0.010 BAT in the brave://rewrads, BR panel and NTP
  6. Confirm that the lower bound is multiplied by 0.8x hence the lower bound value is 0.008
Brave://rewards BR panel NTP
image (2) image image (4)
Case 3: Verify the estimated earnings range when two regular ads are viewed_PASSED
  1. Clean profile 1.57.x
  2. Enable rewards and connect a custodian
  3. View two Ads
  4. Verify the Estimated earning on the UI
  5. Confirmed that the Estimated earning range is 0.016 - 0.020 BAT in the brave://rewrads, BR panel and NTP
  6. Confirm that the lower bound is multiplied by 0.8x for each ad
Brave://rewards BR panel NTP
image image image
Case 4: Verify the estimated earnings range in the payout pending status message_PASSED
  1. Clean profile 1.57.x
  2. Enable rewards and connect a custodian
  3. View a Ad
  4. Confirmed that ad is successfully redeemed with the server
  5. Close the browser
  6. Set the sys date to begining of the next month but before the payout date (8th Aug is payout date for IN, the payout date varies for different regions), I have set the sys date to 4th Aug in my case
  7. Confirmed that the Estimated earning range is 0.008 - 0.010 BAT is shown in the payout pending status message in the brave://rewrads, BR panel and NTP
Brave://rewards BR panel NTP
image image (1) image (2)
Case 5: Verify the estimated earnings range in the payout processing status message_PASSED
  1. Continuation of case 3
  2. Confirmed that both ads are redeemed/cashed in with the server for the July month
  3. Close the browser
  4. Advance the system date to 9th Aug (day after the payout date)
  5. Have a Charles Proxy rules set up to return "processing"
  6. Relaunch the browser
  7. Confirmed that the Estimated earning range is 0.016 - 0.020 BAT is shown in the payout processing status message in the brave://rewrads, BR panel and NTP
Brave://rewards BR panel NTP
image image image
Case 6: Verify estimated earnings range when a NTPSI is viewed_PASSED
  1. Clean profile 1.57.x
  2. Enable reward in the production environmnet, select Cayman island from the country dropdown
  3. View a NTP SI
  4. Connect Cayman island production uphold account (account details are taken from 1Password)
  5. Confirmed that the estimated earnings range 0.000 - 0.005 BAT shown in the brave://rewrads, BR panel and NTP
  6. Confirmed that the lower bound is NOT multiplied by 0.8x for NTPSI view
  7. Confirmed that max bound value = lower bound + NTPSI earning (i.e 0.000 + 0.005)
Brave://rewards BR panel NTP
image image image (2)
Case 7: Verify estimated earnings range when two NTPSI's viewed_PASSED
  1. Clean profile 1.57.x
  2. Enable reward in the production environmnet, select Cayman island from the country dropdown
  3. View a NTP SI
  4. Connect Cayman island production uphold account (account details are taken from 1Password)
  5. Confirmed that estimated earnings range 0.000 - 0.005 BAT shown in the brave://rewrads, BR panel and NTP
  6. View 2nd NTP SI (Note: you may need to advanceset the sys clock ahead by one day to view 2nd NTPSI, currently there is only one NTPSI is configured in prod env)
  7. Confirmed that estimated earnings range 0.000 - 0.010 BAT shown in the brave://rewrads, BR panel and NTP
  8. Confirmed that the lower bound is NOT multiplied by 0.8x for NTPSI view
  9. Confirmed that max bound value = lower bound + NTPSI earning (i.e 0.000 + 0.010)
Brave://rewards BR panel NTP ad_type in DB
image (3) image (4) image (5) image (6)
Case 8: Verify estimated earnings range when NTPSI + regular ad is viewed_PASSED
  1. Continuation of case 7
  2. View a regular Ad
  3. Confirmed that the lower bound is multiplied by 0.8x for the regular ad notification
  4. Confirmed that the lower bound is NOT multiplied by 0.8x for the NTPSI view
  5. Confirmed that NTP SI and Regular ad view earnings are combined in the max bound value hence the max bound value is 0.020 BAT (0.005 +0.005 + 0.01 = 0.020 BAT)
  6. Confired that the estimated earning range 0.008 - 0.020 BAT is shown in the brave://rewrads, BR panel and NTP
Brave://rewards BR panel NTP ad_type in DB
image image (1) image (2) image (3)

UI checks

Confirmed that the estimated earnings range indicator is shown correctly in brave://rewards, BR panel and NTP

Light theme

brave://rewards BR panel NTP
image image image

Dark theme

brave://rewards BR panel NTP
image image image

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jul 20, 2023
Closed
@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 20, 2023
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 21, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Jul 21, 2023 •
edited
Loading

Verified with

Brave | 1.57.18 Chromium: 115.0.5790.98 (Official Build) beta (x86_64)
-- | --
Revision | d515871a6c6df7d2843e755c8b7dda9b744f26d6
OS | macOS Version 13.4.1 (a) (Build 22F770820b)

Existing users

Grandfathered unconnected state_view regular ads - PASSED
  1. Clean profile 1.56.11 (current release version)
  2. Enable rewards and be in grandfathered unverified state
  3. View an ad (ad notification count is 1 but the estimated earnings is still -- Learn more)
  4. Confirmed that the estimated earnings is -- Learn more

1.56.11

Example Example Example Example
1 2 3 4
  1. Upgrade the profile to 1.57.x
  2. Estimated earning is displayed as -- Learn more
  3. View an Ad (ad notification count is increased by 1 but the estimated earnings is still -- Learn more)

1.57.18

Example Example Example Example
5 6 7 8
  1. Connect a custodian
  2. The estimated earnings range is displayed as 0.248 - 0.310 BAT
  3. The max bound value is displayed as expected 0.310 BAT
  4. The lower bound is 0.248 BAT as expected
Example Example
Screenshot 2023-07-24 at 10 12 49 AM Screenshot 2023-07-24 at 10 12 59 AM
Grandfathered connected state_view regular ads - PASSED
  1. Clean profile 1.56.11 (current release version)
  2. Enable rewards and connect a custodian
  3. Confirmed that the estimated earnings is 0.000 BAT

1.56.11

Example Example Example Example
1 2 3 4
  1. Upgrade the profile to 1.57.x
  2. Confirmed that the estimated earnings is 0.000 BAT

1.57.18

Example Example Example Example
5 6 7 8
  1. View a regular ad
  2. Confirmed that the estimated earnings range is displayed as 0.008 - 0.010 BAT as expected
  3. The lower bound is multiplied by 0.8x

1.57.18

Example Example Example Example Example
1 2 3 4 5
Connected state_view regular ads and then upgrade - PASSED
  1. Install 1.56.11 build
  2. Enable rewards and connect a uphold custodian
  3. View couple of ads (I have viewed 2 ads )
  4. Confirmed that the estimated earnings 0.31 BAT is displayed on the brave://rewrads, BR panel and NTP widget

1.56.x

Brave://rewards BR panel NTP
1 2 3
  1. Upgrade the profile to 1.57.x beta build
  2. Confirmed that the ads estimated earning 0.310 BAT in converted into estimated earning range of 0.248 - 0.310 BAT
Brave://rewards BR panel NTP
1 2 3
  1. I have got one more ad when I upgrade the profile
  2. So total no of ads viewed is 3
  3. Confirmed that the Estimated earning range is displayed as 0.368 - 0.460 BAT in the brave://rewards, BR panel and NTP
  4. Confirmed that the lower bound is multiplied by 0.8x for each ad (i.e 4 ads * 0.8 = 0.460)

1.57.x

Brave://rewards BR panel NTP no of ads viewed
1 2 3 4
  1. Confirmed that few ads are redeemed/cashed in with the server (3 ads are redeemed with server in my case)
  2. Close the browser
  3. Advance the sys clock to beginning of the next month (before payout date), I have set it to 3rd Aug
  4. Relaunch the browser
  5. Confirmed that the estimated earning range is shown correctly in the payout pending message
Brave://rewards BR panel NTP
1 2 3
Connected state_view regular ads +NTPSI's and then upgrade - PASSED
  1. Install 1.56.11 build
  2. Enable rewards in production env, select Cayman Island from the country dropdown
  3. View a NTPSI
  4. Connect to production uphold account
  5. View 2nd NTP SI
  6. View a regular ad
  7. Total no of ads viewed are 3 (2 NTPSI + 1 regular ad)
  8. Confirmed that the estimated earnings 0.035 BAT is displayed on the brave://rewards, BR panel and NTP widget

1.56.11

brave://rewards Ad history BR panel NTP ad_types from DB
1 2 3 4 5
  1. Upgrade the profile to 1.57.x
  2. I have got a regular ad after the upgrade to 1.57.x
  3. Total no of ads viewed are 4 (2 NTP SI + 2 Regular ads)
  4. Estimated earnings range is 0.040 - 0.060 BAT as expected, lower bound is properly calculated

1.57.x

brave://rewards Ad history BR panel NTP ad_types from DB
6 7 8 9 10
Connected state_view NTPSI's and then upgrade - PASSED
  1. Install 1.56.11 build
  2. Enable rewards in production env, select Cayman Island from the country dropdown
  3. View a NTPSI
  4. Connect to production uphold account
brave://rewards Ad history BR panel NTP ad_types from DB
1 2 3 4 5
  1. Upgrade the profile to 1.57.x
  2. Confirmed that the estimated earnings range is shown as expected 0.000 - 0.005 BAT
  3. Lower bound is 0.000 BAT which is expected as 0.8x is not multiplied for the NTPSI ad
  4. Max bound is 0.005 BAT is as expected
brave://rewards Ad history BR panel NTP ad_types from DB
1 2 3 4 5

New users

Case 1: Verify default estimated earnings value - PASSED
  1. Clean profile 1.57.x
  2. Enable rewards and connect a custodian
  3. Verify the default Estimated earnings value
  4. Confirmed that the Estimated earnings value is 0.000 BAT in the brave://rewards, BR panel and NTP
Brave://rewards BR panel NTP
1 2 3
Case 2: Verify the estimated earnings range when a regular or default ad is viewed - PASSED
  1. Clean profile 1.57.x
  2. Enable rewards and connect a custodian
  3. View a Ad
  4. Verify the Estimated earning on the UI
  5. Confirmed that the Estimated earning range is 0.008 - 0.010 BAT in the brave://rewrads, BR panel and NTP
  6. Confirm that the lower bound is multiplied by 0.8x hence the lower bound value is 0.008
Brave://rewards BR panel NTP
1 2 3
Case 3: Verify the estimated earnings range when two regular ads are viewed - PASSED
  1. Clean profile 1.57.x
  2. Enable rewards and connect a custodian
  3. View two Ads
  4. Verify the Estimated earning on the UI
  5. Confirmed that the Estimated earning range is 0.048 - 0.060 BAT in the brave://rewrads, BR panel and NTP
  6. Confirm that the lower bound is multiplied by 0.8x for each ad
Brave://rewards BR panel NTP
1 2 3
Case 4: Verify the estimated earnings range in the payout pending status message - PASSED
  1. Clean profile 1.57.x
  2. Enable rewards and connect a custodian
  3. View at least one Ad
  4. Confirmed that at least one ad is successfully redeemed with the server
  5. Close the browser
  6. Set the sys date to beginning of the next month but before the payout date (7th Aug is payout date for US, the payout date varies for different regions), I have set the sys date to 4th Aug in my case
  7. Confirmed that the Estimated earning range is 0.048 - 0.060 BAT is shown in the payout pending status message in the brave://rewrads, BR panel and NTP
Brave://rewards BR panel NTP
1 2 3
Case 5: Verify the estimated earnings range in the payout processing status message - PASSED
  1. Continuation of case 3
  2. Confirmed that both ads are redeemed/cashed in with the server for the July month
  3. Close the browser
  4. Advance the system date to 9th Aug (day after the payout date)
  5. Have a Charles Proxy rules set up to return "processing"
  6. Relaunch the browser
  7. Confirmed that the Estimated earning range is 0.048 - 0.060 BAT is shown in the payout processing status message in the brave://rewrads, BR panel and NTP
Brave://rewards BR panel NTP
1 2 3
Case 6: Verify estimated earnings range when a NTPSI is viewed - PASSED
  1. Clean profile 1.57.x
  2. Enable reward in the production environment, select Cayman island from the country dropdown
  3. View a NTP SI
  4. Connect Cayman island production uphold account (account details are taken from 1Password)
  5. Confirmed that the estimated earnings range 0.000 - 0.005 BAT shown in the brave://rewards, BR panel and NTP
  6. Confirmed that the lower bound is NOT multiplied by 0.8x for NTPSI view
  7. Confirmed that max bound value = lower bound + NTPSI earning (i.e 0.000 + 0.005)
Brave://rewards BR panel NTP
1 2 3
Case 7: Verify estimated earnings range when two NTPSI's viewed - PASSED
  1. Clean profile 1.57.x
  2. Enable reward in the production environment, select Cayman island from the country dropdown
  3. View a NTP SI
  4. Connect Cayman island production uphold account (account details are taken from 1Password)
  5. Confirmed that estimated earnings range 0.000 - 0.005 BAT shown in the brave://rewrads, BR panel and NTP
  6. View 2nd NTP SI (Note: you may need to advance/set the sys clock ahead by one day to view 2nd NTPSI, currently there is only one NTPSI is configured in prod env)
  7. Confirmed that estimated earnings range 0.000 - 0.010 BAT shown in the brave://rewards, BR panel and NTP
  8. Confirmed that the lower bound is NOT multiplied by 0.8x for NTPSI view
  9. Confirmed that max bound value = lower bound + NTPSI earning (i.e 0.000 + 0.010)
Brave://rewards BR panel NTP ad_type in DB
1 2 3 4
Case 8: Verify estimated earnings range when NTPSI + regular ad is viewed - PASSED
  1. Continuation of case 7
  2. View a regular Ad
  3. Confirmed that the lower bound is multiplied by 0.8x for the regular ad notification
  4. Confirmed that the lower bound is NOT multiplied by 0.8x for the NTPSI view
  5. Confirmed that NTP SI and Regular ad view earnings are combined in the max bound value hence the max bound value is 0.020 BAT (0.005 +0.005 + 0.025 = 0.035 BAT)
  6. Confirmed that the estimated earning range 0.020 - 0.035 BAT is shown in the brave://rewrads, BR panel and NTP
Brave://rewards Ad History BR panel NTP ad_type in DB
1 2 3 4 5

@LaurenWags LaurenWags added QA/Blocked QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Blocked labels Jul 25, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Jul 25, 2023 •
edited
Loading

@brave/qa-team we should run the following cases for Linux (from #30351 (comment)):

Existing users

  • Grandfathered unconnected state_view regular ads
  • Connected state_view regular ads +NTPSI's and then upgrade
  • Connected state_view NTPSI's and then upgrade

New users

  • Case 1: Verify default estimated earnings value
  • Case 3: Verify the estimated earnings range when two regular ads are viewed
  • Case 7: Verify estimated earnings range when two NTPSI's viewed
  • Case 8: Verify estimated earnings range when NTPSI + regular ad is viewed

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 31, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Jul 31, 2023 •
edited
Loading

Verified with

Brave	1.57.32 Chromium: 115.0.5790.114 (Official Build) beta (64-bit) 
Revision	bf9c67d9dafde9e2cc2219abd8ddfe738f316b3c
OS	Linux

Existing users

Grandfathered unconnected state_view regular ads - PASSED
  1. Clean profile 1.56.14 (current release version)
  2. Enable rewards and be in grandfathered unverified state
  3. View an ad (ad notification count is 1 but the estimated earnings is still -- Learn more)
  4. Confirmed that the estimated earnings is -- Learn more

1.56.14

Example Example Example Example
Screenshot 2023-07-31 at 11 04 38 AM Screenshot 2023-07-31 at 11 04 45 AM Screenshot 2023-07-31 at 11 04 52 AM Screenshot 2023-07-31 at 11 04 58 AM
  1. Upgrade the profile to 1.57.x
  2. Estimated earning is displayed as -- Learn more
  3. View an Ad (ad notification count is increased by 1 but the estimated earnings is still -- Learn more)

1.57.32

Example Example Example Example
Screenshot 2023-07-31 at 11 13 52 AM Screenshot 2023-07-31 at 11 14 00 AM Screenshot 2023-07-31 at 11 14 13 AM Screenshot 2023-07-31 at 11 14 20 AM
  1. Connect a custodian
  2. The estimated earnings range is displayed as 0.016 - 0.020 BAT
  3. The max bound value is displayed as expected 0.020 BAT
  4. The lower bound is 0.016 BAT as expected
Example Example
Screenshot 2023-07-31 at 11 17 14 AM Screenshot 2023-07-31 at 11 18 07 AM
Connected state_view regular ads +NTPSI's and then upgrade - PASSED
  1. Install 1.56.14 build
  2. Enable rewards in production env, select Cayman Island from the country dropdown
  3. View a NTPSI
  4. Connect to production uphold account
  5. View 2nd NTP SI
  6. View a regular ad
  7. Total no of ads viewed are 3 (2 NTPSI + 1 regular ad)
  8. Confirmed that the estimated earnings 0.035 BAT is displayed on the brave://rewards, BR panel and NTP widget

1.56.14

brave://rewards Ad history BR panel NTP ad_types from DB
Screenshot 2023-07-31 at 11 29 21 AM Screenshot 2023-07-31 at 11 29 34 AM Screenshot 2023-07-31 at 11 29 42 AM Screenshot 2023-07-31 at 11 29 54 AM Screenshot 2023-07-31 at 11 31 02 AM
  1. Upgrade the profile to 1.57.x
  2. I have got a regular ad after the upgrade to 1.57.x
  3. Total no of ads viewed are 4 (2 NTP SI + 2 Regular ads)
  4. Estimated earnings range is 0.040 - 0.060 BAT as expected, lower bound is properly calculated

1.57.x

brave://rewards Ad history BR panel NTP ad_types from DB
Screenshot 2023-07-31 at 11 34 22 AM Screenshot 2023-07-31 at 11 34 31 AM Screenshot 2023-07-31 at 11 34 40 AM Screenshot 2023-07-31 at 11 34 50 AM Screenshot 2023-07-31 at 11 35 23 AM
Connected state_view NTPSI's and then upgrade - PASSED
  1. Install 1.56.14 build
  2. Enable rewards in production env, select Cayman Island from the country dropdown
  3. View a NTPSI
  4. Connect to production uphold account
brave://rewards Ad history BR panel NTP ad_types from DB
Screenshot 2023-07-31 at 11 51 37 AM Screenshot 2023-07-31 at 11 51 44 AM Screenshot 2023-07-31 at 11 51 54 AM Screenshot 2023-07-31 at 11 52 03 AM Screenshot 2023-07-31 at 11 52 34 AM
  1. Upgrade the profile to 1.57.x
  2. Confirmed that the estimated earnings range is shown as expected 0.000 - 0.005 BAT
  3. Lower bound is 0.000 BAT which is expected as 0.8x is not multiplied for the NTPSI ad
  4. Max bound is 0.005 BAT is as expected
brave://rewards Ad history BR panel NTP ad_types from DB
Screenshot 2023-07-31 at 11 54 05 AM Screenshot 2023-07-31 at 11 54 12 AM Screenshot 2023-07-31 at 11 54 25 AM Screenshot 2023-07-31 at 11 54 33 AM Screenshot 2023-07-31 at 11 54 57 AM

New users

Case 1: Verify default estimated earnings value - PASSED
  1. Clean profile 1.57.x
  2. Enable rewards and connect a custodian
  3. Verify the default Estimated earnings value
  4. Confirmed that the Estimated earnings value is 0.000 BAT in the brave://rewards, BR panel and NTP
Brave://rewards BR panel NTP
Screenshot 2023-07-31 at 2 02 58 PM Screenshot 2023-07-31 at 2 03 08 PM Screenshot 2023-07-31 at 2 03 15 PM
Case 3: Verify the estimated earnings range when two regular ads are viewed - PASSED
  1. Clean profile 1.57.x
  2. Enable rewards and connect a custodian
  3. View two Ads
  4. Verify the Estimated earning on the UI
  5. Confirmed that the Estimated earning range is 0.048 - 0.060 BAT in the brave://rewrads, BR panel and NTP
  6. Confirm that the lower bound is multiplied by 0.8x for each ad
Brave://rewards BR panel NTP
Screenshot 2023-07-31 at 2 15 12 PM Screenshot 2023-07-31 at 2 15 21 PM Screenshot 2023-07-31 at 2 15 29 PM
Case 7: Verify estimated earnings range when two NTPSI's viewed - PASSED
  1. Clean profile 1.57.x
  2. Enable reward in the production environment, select Cayman island from the country dropdown
  3. View a NTP SI
  4. Connect Cayman island production uphold account (account details are taken from 1Password)
  5. Confirmed that estimated earnings range 0.000 - 0.005 BAT shown in the brave://rewrads, BR panel and NTP
  6. View 2nd NTP SI (Note: you may need to advance/set the sys clock ahead by one day to view 2nd NTPSI, currently there is only one NTPSI is configured in prod env)
  7. Confirmed that estimated earnings range 0.000 - 0.010 BAT shown in the brave://rewards, BR panel and NTP
  8. Confirmed that the lower bound is NOT multiplied by 0.8x for NTPSI view
  9. Confirmed that max bound value = lower bound + NTPSI earning (i.e 0.000 + 0.010)
Brave://rewards BR panel NTP ad_type in DB
Screenshot 2023-07-31 at 2 34 01 PM Screenshot 2023-07-31 at 2 34 08 PM Screenshot 2023-07-31 at 2 34 16 PM Screenshot 2023-07-31 at 2 34 39 PM
Case 8: Verify estimated earnings range when NTPSI + regular ad is viewed - PASSED
  1. Continuation of case 7
  2. View a regular Ad
  3. Confirmed that the lower bound is multiplied by 0.8x for the regular ad notification
  4. Confirmed that the lower bound is NOT multiplied by 0.8x for the NTPSI views
  5. Confirmed that NTP SI and Regular ad view earnings are combined in the max bound value hence the max bound value is 0.020 BAT (0.005 +0.005 + 0.01 = 0.020 BAT)
  6. Confirmed that the estimated earning range 0.008 - 0.020 BAT is shown in the brave://rewrads, BR panel and NTP
Brave://rewards Ad History BR panel NTP ad_type in DB
Screenshot 2023-07-31 at 2 37 23 PM Screenshot 2023-07-31 at 2 37 42 PM Screenshot 2023-07-31 at 2 37 52 PM Screenshot 2023-07-31 at 2 41 07 PM Screenshot 2023-07-31 at 2 41 39 PM

@LaurenWags LaurenWags added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 31, 2023
@LaurenWags LaurenWags mentioned this issue Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

Show range for estimated Rewards earnings brave/brave-core
5 participants
@zenparsing @Miyayes @LaurenWags @GeetaSarvadnya @brave-builds