Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Sidebar to the right by default #30397

Closed
srirambv opened this issue May 17, 2023 · 3 comments · Fixed by brave/brave-core#18559
Closed

Enable Sidebar to the right by default #30397

srirambv opened this issue May 17, 2023 · 3 comments · Fixed by brave/brave-core#18559
Assignees

Comments

@srirambv
Copy link
Contributor

srirambv commented May 17, 2023

Description

Enable Sidebar to the right by default for all new users. (This is a separate from work already done of moving sidebar to the right when users turn on vertical tabs).

Steps to Reproduce

Beta/Nightly

  1. Launch a new Beta build or nightly build
  2. Side bar is set to show on left by default
  3. Enable vertical tabs
  4. Sidebar is moved to the right without a clue

Release

  1. Launch release build
  2. Side bar is set to disabled by default
  3. Enable side bar or click on the reading list button on the URL
  4. Enable vertical tabs
  5. Sidebar is moved to the right without a clue

Actual result:

Side bar is moved to the right side of the window when vertical tabs are enabled

Expected result:

On Release when user enabled sidebar show it on the right by default. On Beta/Nightly have the side bar on right by default

Reproduces how often:

Easy

Brave version (brave://version info)

All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @rebron @sangwoo108 @simonhong @aguscruiz

@stephendonner
Copy link

stephendonner commented May 17, 2023

Should 2. Side bar is set to show on right by default read 2. Side bar is set to show on left by default in the beta/nightly steps?

@srirambv
Copy link
Contributor Author

Yup updated the step

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 19, 2023
simonhong added a commit to brave/brave-core that referenced this issue May 20, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 22, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.53.67 Chromium: 114.0.5735.53 (Official Build) beta (x86_64)
Revision c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS macOS Version 11.7.7 (Build 20G1345)

Steps:

  1. installed 1.53.67
  2. launched Brave
  3. checked which side sidebar defaulted to
  4. also checked pref value in brave://settings/appearance

Confirmed sidebar defaulted to the right

default brave://settings/appearance
Screen Shot 2023-05-26 at 5 28 58 PM Screen Shot 2023-05-26 at 5 29 17 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants