Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sending f1 to typed f4 addresses #30401

Closed
cypt4 opened this issue May 17, 2023 · 2 comments · Fixed by brave/brave-core#18511
Closed

Support sending f1 to typed f4 addresses #30401

cypt4 opened this issue May 17, 2023 · 2 comments · Fixed by brave/brave-core#18511
Assignees
@cypt4
Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/include
Milestone
1.57.x - Release

Comments

@cypt4
Copy link

cypt4 commented May 17, 2023 •
edited
Loading

Root ticket : #30400

f4 addresses represents FEVM addresses in the FVM namespace.
To send funds from FVM address to the FEVM address we should translate FEVM address to f410 namespace address (using https://gist.github.com/Stebalien/fd29d46eb24bcb72fe781cf5a09e7aa7 protocol) and then use common FVM methods like MPool.Push/EstimateGas but providing 3844450837(InvokeContract) to the "Method" field in Lotus requests.

Sec review https://github.com/brave/security/issues/1290
@cypt4 cypt4 self-assigned this May 17, 2023
@cypt4 cypt4 added this to Web3 May 17, 2023
@cypt4 cypt4 mentioned this issue May 17, 2023
Merged
25 tasks
@cypt4 cypt4 mentioned this issue May 17, 2023
Open
cypt4 added a commit to brave/brave-core that referenced this issue May 17, 2023
@cypt4
Support sending f1 to typed f4 addresses
d021833 
Resolves brave/brave-browser#30401
cypt4 added a commit to brave/brave-core that referenced this issue May 23, 2023
@cypt4
Support sending f1 to typed f4 addresses
638a29f 
Resolves brave/brave-browser#30401
@HEagle18 HEagle18 added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 9, 2023
@HEagle18 HEagle18 moved this to Backlog in Web3 Jun 9, 2023
cypt4 added a commit to brave/brave-core that referenced this issue Jun 14, 2023
@cypt4
Support sending f1 to typed f4 addresses
c8d2a94 
Resolves brave/brave-browser#30401
cypt4 added a commit to brave/brave-core that referenced this issue Jul 7, 2023
@cypt4
Support sending f1 to typed f4 addresses
89a6629 
Resolves brave/brave-browser#30401
bridiver pushed a commit to brave/brave-core that referenced this issue Jul 13, 2023
@cypt4 @bridiver
Support sending f1 to typed f4 addresses
b959a6f 
Resolves brave/brave-browser#30401
cypt4 added a commit to brave/brave-core that referenced this issue Jul 14, 2023
@cypt4 @bridiver
Support sending f1 to typed f4 addresses (#18511)
1213656 
* Support sending f1 to typed f4 addresses
Resolves brave/brave-browser#30401

* Migrate to rust static

* Build fix

* Review fix

* remove unused crates and update *.toml

* bump fvm_shared to 3.3.0 to match filecoin Cargo.toml

* add missing BUILD.gn update for multihash

* fix multihash aliased deps

---------

Co-authored-by: bridiver <34129+bridiver@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Jul 14, 2023
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 14, 2023
cypt4 added a commit to brave/brave-core that referenced this issue Aug 10, 2023
@cypt4 @bridiver
Support sending f1 to typed f4 addresses (#18511)
ad235d2 
* Support sending f1 to typed f4 addresses
Resolves brave/brave-browser#30401

* Migrate to rust static

* Build fix

* Review fix

* remove unused crates and update *.toml

* bump fvm_shared to 3.3.0 to match filecoin Cargo.toml

* add missing BUILD.gn update for multihash

* fix multihash aliased deps

---------

Co-authored-by: bridiver <34129+bridiver@users.noreply.github.com>
@kjozwiak kjozwiak mentioned this issue Aug 11, 2023
Merged
7 tasks
kjozwiak pushed a commit to brave/brave-core that referenced this issue Aug 11, 2023
@cypt4 @bridiver
FEVM integration + CID verification fix(uplift to 1.57.x) (#19622)
b9b8821 
* Support sending f1 to typed f4 addresses (#18511)

* Support sending f1 to typed f4 addresses
Resolves brave/brave-browser#30401

* Migrate to rust static

* Build fix

* Review fix

* remove unused crates and update *.toml

* bump fvm_shared to 3.3.0 to match filecoin Cargo.toml

* add missing BUILD.gn update for multihash

* fix multihash aliased deps

---------

Co-authored-by: bridiver <34129+bridiver@users.noreply.github.com>

* Include FEVM addresses when sender is f1 (#19330)

* Include FEVM addresses when sender is f1
Resolves brave/brave-browser#30403

* Validate IPFS Cid using Rust CID lib (#19451)

* Validate IPFS Cid using Rust CID lib
Resolves brave/brave-browser#31145

* Cleanup

---------

Co-authored-by: bridiver <34129+bridiver@users.noreply.github.com>
@kjozwiak
Copy link
Member

The above requires 1.57.45 or higher for 1.57.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.57.45 Chromium: 116.0.5845.82 (Official Build) (64-bit)
Revision c43241b101a636729252df90d1a1a7b72f2a9f94
OS Linux
  • Verified steps from brave/brave-core#18511
  • Verified converting ETH to f40 address and doing a send transactions succeeds
  • Verified correct block explorer correctly is opened
  • Verified account has the transaction in the history
30401.mp4

@LaurenWags LaurenWags mentioned this issue Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/wallet/filecoin feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

Support sending f1 to typed f4 addresses brave/brave-core
5 participants
@kjozwiak @HEagle18 @srirambv @brave-builds @cypt4