Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove query trackers from Hive email newsletters #30731

Closed
fmarier opened this issue May 31, 2023 · 4 comments · Fixed by brave/brave-core#18723
Closed

Remove query trackers from Hive email newsletters #30731

fmarier opened this issue May 31, 2023 · 4 comments · Fixed by brave/brave-core#18723
Assignees
Labels

Comments

@fmarier
Copy link
Member

fmarier commented May 31, 2023

https://www.hive.co/ is an email marketing platform that appears to insert unique h_sid and h_slt query parameters.

Sample unsubscribe link: https://app.hive.co/email/elt/?h_sid=3d...22d0&hash=20...2&next=https%3A%2F%2Fapp.hive.co%2Femail%2Funsubscribe%2Ftour%2F%3Ftour_id%3D130179%26user_id%3D33...9%26hash%3Db72...d6%26utm_source%3Dhive%26utm_medium%3Demail%26utm_campaign%3Dhive_email_id_196293_pizza-city-fest

I confirmed that neither h_sid nor h_slt are necessary for unsubscribing from a list.

Also this contains a sample link that can be debounced: https://app.hive.co/email/elt/?h_sid=3d...22d0&hash=20..2&next=https%3A//www.hive.co/%3Ftid%3Dfteremail%26utm_source%3Dhive%26utm_medium%3Demail%26utm_campaign%3Dhive_email_id_196293_pizza-city-fest

@fmarier fmarier added priority/P4 Planned work. We expect to get to it "soon". OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels May 31, 2023
@fmarier fmarier self-assigned this May 31, 2023
ryanbr added a commit to brave/adblock-lists that referenced this issue May 31, 2023
ryanbr added a commit to brave/adblock-lists that referenced this issue May 31, 2023
@fmarier
Copy link
Member Author

fmarier commented Jun 1, 2023

I couldn't find any documentation about what the parameters represent in their documentation. However, it seems likely that h_sid stands for subscribed ID, likely a unique ID for a user.

The h_slt param is base64-encoded and contains the following JSON information:

{"hash":"7026...78b","hive_user_id":33...89}

and so it contains a unique user ID that we should remove.

@fmarier
Copy link
Member Author

fmarier commented Jun 1, 2023

@LaurenWags
Copy link
Member

LaurenWags commented Jul 14, 2023

Verified with

Brave | 1.57.10 Chromium: 115.0.5790.75 (Official Build) beta (x86_64)
-- | --
Revision | 6fbe50fcb5cd24cd6bd0fe48aee3a108eb21441e
OS | macOS Version 13.4.1 (a) (Build 22F770820b)

Verified test plan from brave/brave-core#18723 (comment).

Step 1 Step 2 Step 3 Step 4
1 2 3 4

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 18, 2023
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 2, 2023
@hffvld
Copy link
Contributor

hffvld commented Aug 2, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 UPB4.230623.007 release-keys]
Brave build: 1.57.33
Chromium: 115.0.5790.114 (Official Build) beta (64-bit) 
Revision: 86b4ea1d70ce73c4468d84cc8277f1f9de14b8bc

STEPS:
Followed the steps from this test plan

ACTUAL RESULTS:


1 2
1 2
3 4
3 4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 2, 2023
lyubomyr-shaydariv added a commit to lyubomyr-shaydariv/uu-webext that referenced this issue Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment