-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subsequent delta updates on Windows fail #30748
Comments
Verification
Verified as following for 1.54.43 -->1.54.48-->1.53.53 Run following Pre-requisites:
Actual Results:
Scenario 2:
Actual Results:
|
@mherrmann I am not seeing delta updates. Can you check the |
@MadhaviSeelam the steps you documented are really clear to understand. Thank you! When you invoke Let me explain why. Brave's update mechanism on Windows works as follows: It asks the update server for a new version. If there is a new version, then the server returns the URL to a If the Now to tie this back to I hope this helps clarify the context? |
Verification
Verified upgrade check with Run following Pre-requisites:
Actual Results:
|
Thank you @MadhaviSeelam. I followed your steps on two Windows 10 machines but (unfortunately?) the problem did not appear for me. Does the problem also appear for you on Windows 10? And - ignoring the log files for now - do you see the correct version in |
@mherrmann - I have verified twice on Win 10 following steps from above. Here are the actual results:
|
@MadhaviSeelam let's ignore the log files for now please. By "successfully updated via brave://settings/help", do you mean that you had internet access and updated from a previous Brave version by opening that page? What I want to know please is if, after running |
Verification
Win 11 x64 - Machine-wide install -
|
Step 1 | Step 6-7 | Step 9 | Step 10 | Step 12 | Step 13 | Step 14 | Step 15 |
---|---|---|---|---|---|---|---|
Win 11 x64 -Per- User Install - PASSED
- Install Brave 1.57.27 using it's offline installer, BraveBrowserStandaloneBetaSetup.exe
- Do not accept the UAC prompt and install without administrator privileges to perform Per-user installation.
- Close Brave and disconnect from internet so Brave doesn't accidentally get updated.
- Open a Windows command prompt (without Administrator privileges)
- Download the delta installer to go from Brave 1.57.27 to 1.57.33
- Open Windows command prompt (without Administrator privileges)
- Execute the delta installer in the same command prompt for beta. For example by typing:
- C:\Users\mseel\Downloads\brave_installer-delta-x64.exe --chrome-beta - Start Brave (without internet)
- Verified Brave updated to 1.57.33 via
brave://setting/help
- Repeat steps 5 - 7 for the delta installer to go from Brave 1.57.33 to 1.57.35
- Start Brave (without internet)
- Verified brave updated to 1.57.35 via
brave://settings/help
- Verified correct logs shown in C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log
- Verified correct installed versions shown in C:\Users\mseel\AppData\Local\Temp\chromium_installer.log
- Verified on-demand updates are successful after connecting to Internet via brave://settings/help
Confirmed:
- Brave is updated to
1.57.33
&1.57.35
and verified viabrave://version
C:\Users\...\AppData\Local\Temp\chromium_installer.log
shows correct Brave versions and no errors shownC:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log
shows correct logs.- On-demand updates were successful via
brave://settings/help
Step 1 | Step 6-7 | Step 9 | Step 10 | Step 12 | Step 13 | Step 14 | Step 15 |
---|---|---|---|---|---|---|---|
@mherrmann so the update is successful without connecting to internet which was verified via brave://version. However, when I checked via brave://settings/help, got an error |
@MadhaviSeelam yes, |
@GeetaSarvadnya This issue is passed on Win 11 x64 and I am yet verify in Win arm64. When you get a chance, please test this issue on Win 10. |
Verification PASSED on
Win x64 - Machine wide Install -
|
step 1 | step 6-7 | step 9 | step 10 | step11 | step 13 | step 14 | step 15 | step 16 | step 17 |
---|---|---|---|---|---|---|---|---|---|
Win x64 - Per-user Install - PASSED
Verified with public beta releases 1.57.27 --> 1.57.33 --> 1.57.35
- Run
Brave Manager
and make sure all the brave instances from your computer is uninstalled - Go to local profile folder directory and make sure
Update
folder is deleted to make sure there is no updater running in your computer - Open the
Registry Editor
without admin rights - Navigate to
Computer\HKEY_CURRENT_USER\SOFTWARE\BraveSoftware\Update\
- Make sure there are no
Clients
andClientstates
underUpdate
folder in the path Computer\HKEY_CURRENT_USER\SOFTWARE\BraveSoftware\Update\ - Download [BraveBrowserStandaloneBetaSetupx64.exe] https://github.com/brave/brave-browser/releases/download/v1.57.27/BraveBrowserStandaloneBetaSetupx64.exe
- Download the delta installer to go from Brave 1.57.27 to 1.57.33
- Download delta installer to go from Brave 1.57.33 to 1.57.35
- Install Brave
1.57.27
using it's offline installer, [BraveBrowserStandaloneBetaSetupx64.exe] https://github.com/brave/brave-browser/releases/download/v1.57.27/BraveBrowserStandaloneBetaSetupx64.exe - Do not accept the UAC prompt and install without administrator privileges to perform Per-user installation.
- Make sure the intended version is installed
- Close Brave and disconnect from internet so Brave doesn't accidentally get updated.
- Execute the delta installer in the same command prompt for beta. For example by typing:
C:\Users\mseel\Downloads\brave_installer-delta-x64.exe --chrome-beta
- Start Brave (without internet)
- Make sure brave is updated from
1.57.27
to1.57.33
via brave://setting/help and update check is failed as the internet is off that is expected - Verified the new updated version via brave://version
- Close the brave
- Repeat the step 13 and 14 [Important: Please make sure to move the download file for
1.57.33
delta installer to other folder after running step 15, if you just execute the step 13 without moving1.5.33
installer it may run the1.57.33
delta installer again, so please make sure you are running the correct version1.57.35
in the step 18 ] - Open brave://setting/help
- Make sure brave is updated from
1.57.33
to1.57.35
via brave://setting/help and update check is failed as the internet is off that is expected - Verified the new updated version via brave://version
- Verify the logs in C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log
- Verify
brave_installer-delta-x64.exe
in C:\Users\mseel\AppData\Local\Temp\chromium_installer.log - Connected to internet and make sure on demand updates is happening correctly via
brave://settings/help
- Check the registry and make sure correct client version is shown
Actual Results:
- Updates are happening from
1.5.27
->1.57.33
->1.5.35
.......\AppData\Local\Temp\chromium_installer.log
shows the correct logsC:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log
shows the correct logs- After connecting internet, on demand updates is happening correctly via
brave://settings/help
step 5 | step 11 | step 13 | step 15 | step 16 | step 18 | step 20 | step 21 | step 22 | step 23 | step 24 | step 25 | step 25 (1) |
---|---|---|---|---|---|---|---|---|---|---|---|---|
Verification
Win arm64 - Machine wide Install -
|
step 1 | step 6-7 | step 9 | step10 | step 12 | step 13 | step 14 | step 15 |
---|---|---|---|---|---|---|---|
Win arm64 - Per-user Install - PASSED
Verified with public beta releases 1.57.27 --> 1.57.33 --> 1.57.35
- Install Brave 1.57.27 using it's offline installer, [BraveBrowserStandaloneBetaSetupArm64.exe] https://github.com/brave/brave-browser/releases/download/v1.57.27/BraveBrowserStandaloneBetaSetupArm64.exe
- Do not accept the UAC prompt and install without without administrator privileges to perform Per-user installation.
- Close Brave and disconnect from internet so Brave doesn't accidentally get updated.
- Open a Windows command prompt (without Administrator privileges)
- Download the delta installer to go from Brave 1.57.27 to 1.57.33
- Execute the delta installer in the same command prompt for beta. For example by typing:
- C:\Users\mseel\Downloads\brave_installer-delta-arm64.exe --chrome-beta - Start Brave (without internet)
- Verified the new updated version,
1.57.33
, via brave://version - Repeat steps 5 - 7 for the delta installer to go from Brave 1.57.33 to 1.57.35
- Start Brave (without internet)
- Verified the new updated version,
1.57.35
, via brave://version - Verified correct logs via C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log
- Verified correct Brave versions show via
C:\Users\mseel\AppData\Local\Temp\chromium_installer.log
- Verified on-demand updates after connecting to Internet via brave://settings/help
Confirmed:
- Brave is updated to 1.57.33 & 1.57.35 and verified via brave://version
- C:\Users....\AppData\Local\Temp\chromium_installer.log shows correct Brave versions and no errors shown
- C:\ProgramData\BraveSoftware\Update\Log\BraveUpdate.log shows correct logs.
- On-demand updates shows errors via brave://settings/help
step 1 | step 6 | step 9 | step10 | step 12 | step 13 | step 14 | step 15 |
---|---|---|---|---|---|---|---|
@mherrmann Delta updates are failing for Win 11 x64 -Per- User Install - Failed - #30748 (comment) (Please see actual results) |
@MadhaviSeelam thank you for checking this. I need to aplogise: The instructions were not correct for per-user installations. For per-user installations, we want to use a normal command prompt, not an Administrator command prompt, and we should not set |
@MadhaviSeelam I have done testing on Windows 10 x64, please add the QA pass label once you're done with the per-user installations testing on windows 11. Thanks! |
@mherrmann: Followed your modified test steps for Per-user install on both Win 11 x64 & Win arm64.
Verified with public beta releases 1.57.27 --> 1.57.33 --> 1.57.35.
Additionally |
Thank you @MadhaviSeelam. Do you see the correct versions in |
@mherrmann Yes. I see correct versions. (Verified logs in |
@MadhaviSeelam great, thanks. As long as the correct version is shown in |
@mherrmann sounds good. QA passing this issue. |
This issue behaves exactly like #29469, except the reason now is different.
The present reason is that after a normal installation,
setup.exe
in Brave's installation directory is code signed. But delta updates put a non-signed version ofsetup.exe
into the installation directory. When the next delta update runs, it expects the code signed file. It sees a "different" file and falls back to the full update.The text was updated successfully, but these errors were encountered: