White theme in a dark theme

[Kitanit]

On Linux Mint 21.1 Cinnamon, after the latest stable update (Brave: 1.52.117 Chromium: 114.0.5735.90), when I reopen the browser if the dark theme is turned on, the white one is turned on even if the dark one is in the settings, it is fixed by turning on the white one and turning back the dark one

simplescreenrecorder-2023-06-02_10.23.19.mp4

[kraizelburg]

This is only temporary until you close and open the browser again. It is a known bug in latest linux version.

[pedrof04]

Same problem here on Linux Mint 21.1 Mate.

[salvaft]

Same problem. Linux Mint 21.1 xfce

This is only temporary until you close and open the browser again. It is a known bug in latest linux version.
After I reopen the browser the light version is set again...

[zquestz]

Confirmed on Arch with Cinnamon. Would be great to see this fixed.

[Misza13]

Same here on Manjaro, package brave-browser 1.52.117-2.
Switching to light then dark fixes it until the next restart of the browser.

When I use GTK theme instead of classic, then most of the UI stays dark, but icons on the new tab page have white backgrounds after restart and some pages (like YouTube) load in light mode. Again, switch to light, then dark fixes until restart.

[Pieter-Visscher]

issue is also present on Debian 12.

[solo-dante]

Same problem here on Linux Mint 21.1 Mate.

+1

[charanravi-online]

Issue is reproduced on Ubuntu 22.04.2 LTS as well.

[DustyGanteng]

Same problem here on Linux Mint 21.1 Mate.

+1
workaround: gsettings set org.gnome.desktop.interface color-scheme prefer-dark

[solo-dante]

gsettings set org.gnome.desktop.interface color-scheme prefer-dark

Thanks @DustyGanteng that worked.

[Terraminator]

same thing for me. Thank you @DustyGanteng. worked for me! (Linux Mint 21.1 Vera)

[pedrof04]

Thank you very much @DustyGanteng , worked on Linux Mint 21.1 Mate.

[AuracleTech]

Linux Mint XFCE 21.1 64bit x86_64

EDIT : gsettings set org.gnome.desktop.interface color-scheme prefer-dark someone else said fixed my issue (for now at least?)

[Brave-Matt]

@rebron @fallaciousreasoning can we have someone take a look at this? Likely an easy fix and good for quality of life for Linux users.

[rebron]

@Kitanit Are you seeing this in Chrome as well or is this specific to Brave? We want to see if this is an upstream issue.

[Kitanit]

@Kitanit Are you seeing this in Chrome as well or is this specific to Brave? We want to see if this is an upstream issue.

Sorry I don't use Chrome

[zsolaj]

It also ignores the "Show tab search button" switch. It fixes itself once the setting gets enabled and disabled again, but only until the next browser start.
The issue started at the same time as the issue in the title, so I guess they're linked.
(Linux Mint 21.1 Cinnamon, kernel 5.15.0-73, Brave version 1.52.122 /did this on the previous stable release, too/)

[simonhong]

Same on Fedora 38 with i3

Version 1.52.117 Chromium: 114.0.5735.90 (Official Build) (64-bit)

Thanks @Cakez0r . Did you set light theme as your os system theme?

[simonhong]

Can I have some more help for testing?
I made test nightly build(brave-browser-nightly_1.54.61_amd64.deb and brave-browser-nightly-1.54.61-1.x86_64.rpm) with my draft PR.
Unfortunately, my machine doesnt' have this issue so can't verify this test build could fix or not.
It would be really great help if anyone can install this build and test whether this issue is resolved or not. Thanks all :)

[digitalextremist]

@simonhong I am testing this on a fresh install of Linux Mint 21.1 shortly.

[digitalextremist]

The issue is resolved in the nightly build you posted @simonhong. Nice work!

Confirmed fix is working on a fresh OS & package install manifesting the issue!

Any one else reproduce the success, or are there still failing cases outside Linux Mint 21.1?

[simonhong]

The issue is resolved in the nightly build you posted @simonhong. Confirmed on a fresh install manifesting the issue!

Nice work! Any one else reproduce the success, or are there still failing cases outside Linux Mint 21.1?

@digitalextremist Thank you for all the help, it is much appreciated! 👍🏼

[digitalextremist]

It seems there is another confirmation with Linux 21.0 ( not 21.1 )

https://community.brave.com/t/dark-mode-resests-after-browser-is-closed/489864/50

[digitalextremist]

Seems there are two threads of testers with @simonhong here on GitHub but another glowing response, solving the issue on another Linux 21.1 system.

[simonhong]

Seems there are two threads of testers with @simonhong here on GitHub but another glowing response, solving the issue on another Linux 21.1 system.

@digitalextremist Many thanks!!!

[Cakez0r]

Works for me also in your test build. Thank you!

[simonhong]

Works for me also in your test build. Thank you!

@Cakez0r Thanks for your help! Current nightly channel includes this fix :)

[felipeabou]

I had this issue and your fix worked for me. I'm using Linux Mint 21.1.

Thank you very much, @simonhong !!!

[kjozwiak]

The above requires 1.53.107 or higher for 1.53.x verification 👍

[LaurenWags]

Verified with Ubuntu 20.04.6 LTS:

Brave	1.53.107 Chromium: 115.0.5790.40 (Official Build) (64-bit) 
Revision	071c9ddea889c3c7887daf4eac13fed72d4fff62-refs/branch-heads/5790@{#979}
OS	Linux

Reproduced issue as described in #30766 (comment):

Example	Example

Verified that theming is working as expected on Linux using the STR/Cases outlined via brave/brave-core#18922 (comment) as per the following:

Ensured that Brave is always using the correct theming when switching the OS theme. Examples of cases:

• ensured that Brave uses Dark theme when set even though the OS theme is set as Light
• ensured that Brave uses Light theme when set even though the OS theme is set as Dark
• ensured that restarting multiple times didn't cause Brave to use the incorrect theme.

Example	Example

Also ensured that Use GTK was working correctly. When Use GTK, ensured that OS elements match the current theme but the theme shouldn't be changed within Brave as per brave/brave-core#18922 (comment).

Example	Example

[TzourCode]

Same problem here on Linux Mint 21.1 Mate.

+1 workaround: gsettings set org.gnome.desktop.interface color-scheme prefer-dark

Thanks mate worked for me to!!! @DustyGanteng 💪

Linux Mint 21.1 Cinnamon