Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Beta label for Sync #3079

Closed
rebron opened this issue Jan 24, 2019 · 2 comments · Fixed by brave/brave-core#1441
Closed

add Beta label for Sync #3079

rebron opened this issue Jan 24, 2019 · 2 comments · Fixed by brave/brave-core#1441
Assignees
@rossmoody
Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@rebron
Copy link
Collaborator

rebron commented Jan 24, 2019 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#1441

Description

Add Beta label for Sync on initial setup screen and main page.

Expected result:

screen shot 2019-01-24 at 8 07 21 am

Sync (beta) Setup

and:
Sync (beta)
screen shot 2019-01-24 at 8 07 45 am
@rebron rebron added this to the 0.59.x - Release milestone Jan 24, 2019
@rebron
Copy link
Collaborator Author

rebron commented Jan 24, 2019

cc: @cezaraugusto

bsclifton pushed a commit to brave/brave-core that referenced this issue Jan 24, 2019
Update title for Sync to include (beta)
5d4e4fd 
Fixes brave/brave-browser#3079
@bsclifton bsclifton mentioned this issue Jan 24, 2019
Merged
18 tasks
@anthonypkeane anthonypkeane mentioned this issue Jan 24, 2019
Closed
@rossmoody rossmoody mentioned this issue Jan 24, 2019
Merged
This was referenced Jan 24, 2019
Merged
Merged
This was referenced Jan 25, 2019
Closed
Closed
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 25, 2019 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.59.29 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Windows 10

image

image

Verified passed with

Brave 0.59.30 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Mac OS X

screen shot 2019-01-25 at 2 44 08 pm

screen shot 2019-01-25 at 2 46 58 pm

Verification PASSED on Mint 19.1 x64 VM using the following build:

Brave 0.59.30 Chromium: 72.0.3626.71 (Official Build) (64-bit)
Revision f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS Linux

screen shot 2019-01-28 at 12 31 05 am

screen shot 2019-01-28 at 12 34 51 am

@rebron rebron mentioned this issue Mar 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossmoody rossmoody

Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Update title for Sync to include (beta) brave/brave-core
6 participants
@kjozwiak @bsclifton @rebron @LaurenWags @rossmoody @GeetaSarvadnya