Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to resize sidebar panels #30808

Closed
simonhong opened this issue Jun 5, 2023 · 4 comments · Fixed by brave/brave-core#18983
Closed

Add ability to resize sidebar panels #30808

simonhong opened this issue Jun 5, 2023 · 4 comments · Fixed by brave/brave-core#18983
Assignees
@simonhong
Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.57.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Jun 5, 2023 •
edited
Loading

  1. Resize side panel by grabbing side panel border on both sided sidebar position.
  2. Re-launch and check previously resized width is persisted when side panel is opened.
  3. Check resize works properly after resizing browser window, vertical tab width.
  4. Check sidebar doesn't occupy whole content page when window width gets narrower
  5. Launch multiple windows(including private or tor) and open any side panel
  6. Resize side panel from one window and check all other windows' side panel should be resized together
@simonhong simonhong self-assigned this Jun 5, 2023
@simonhong simonhong added QA/Yes and removed QA/No labels Jun 7, 2023
@simonhong simonhong mentioned this issue Jun 21, 2023
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Jun 22, 2023
@simonhong
Added resize handle to side panel
4f23826 
fix brave/brave-browser#30808

SidePanelResizeHandle's ResizeArea detects resize event and
BraveSidePanel updates preferred width with resized offset.
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jun 22, 2023
simonhong added a commit to brave/brave-core that referenced this issue Jun 23, 2023
@simonhong
Fixed UaF bug from BraveSidePanelResizeWidget
d74b34b 
f/u PR for #18983
issue: brave/brave-browser#30808

It seems contents container could be destroyed first before this widget.
Stop observing when observed view is in-destroying.
@simonhong simonhong mentioned this issue Jun 23, 2023
Merged
25 tasks
@brave-builds brave-builds mentioned this issue Jun 27, 2023
Merged
7 tasks
@simonhong simonhong mentioned this issue Jun 27, 2023
Closed
7 tasks
@LaurenWags
Copy link
Member

The above requires 1.57.7 or higher for 1.57.x verification 👍

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.57.8 Chromium: 115.0.5790.75 (Official Build) beta (64-bit)
-- | --
Revision | 77bffd419b7e89d7e666c9695e7fa0d1d0367a99
OS | Windows 11 Version 22H2 (Build 22621.1992)
  1. Installed 1.57.8
  2. launched Brave
  3. clicked on sidebar toolbar button
  4. resized side panel by grabbing side panel border
  5. closed and relaunched Brave.
  6. clicked sidebar toolbar button again
  7. confirmed the resized side panel persisted.
  8. enable vertical tabs
  9. confirmed able to resize both vertical tab panel and side panel
  10. verified sidebar doesn't occupy whole content page
  11. opened original window, Private window & new Private window with Tor
  12. confirmed all three reflected original window width of the side panel
  13. resized Private window and confirmed original window, new window & new Private window with Tor reflects the resized width of the side panel
step 3 step 4 step 7 step 9 new window private window Tor window step 13a step 13b
image image image image image image image image image

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 18, 2023
@stephendonner
Copy link

stephendonner commented Jul 18, 2023 •
edited
Loading

Verification PASSED using

Brave 1.57.16 Chromium: 115.0.5790.98 (Official Build) beta (x86_64)
Revision d6c8a44fbe78ae6ee53d838307b4d17bec8de940
OS macOS Version 11.7.8 (Build 20G1351)

Steps:

  1. installed 1.57.16
  2. launched Brave
  3. clicked on sidebar toolbar button
  4. resized side panel by grabbing side panel border
  5. closed and relaunched Brave.
  6. clicked sidebar toolbar button again
  7. confirmed the resized side panel persisted.
  8. enable vertical tabs
  9. confirmed able to resize both vertical tab panel and side panel
  10. verified sidebar doesn't occupy whole content page
  11. opened original window, Private window & new Private window with Tor
  12. confirmed all three reflected original window width of the side panel
  13. resized Private window and confirmed original window, new window & new Private window with Tor reflects the resized width of the side panel
step 3 step 4 step 7 step 9 new window private window Tor window step 13a step 13b step 13c
Screen Shot 2023-07-18 at 11 08 03 AM Screen Shot 2023-07-18 at 11 08 48 AM Screen Shot 2023-07-18 at 11 09 12 AM Screen Shot 2023-07-18 at 11 12 34 AM Screen Shot 2023-07-18 at 11 15 43 AM Screen Shot 2023-07-18 at 11 15 59 AM Screen Shot 2023-07-18 at 11 16 29 AM Screen Shot 2023-07-18 at 11 18 58 AM Screen Shot 2023-07-18 at 11 19 04 AM Screen Shot 2023-07-18 at 11 19 10 AM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 18, 2023
@simonhong simonhong mentioned this issue Jul 19, 2023
Closed
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 3, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 4, 2023 •
edited
Loading

Verification PASSED on

Brave	1.57.33 Chromium: 115.0.5790.114 (Official Build) beta (64-bit) 
Revision	86b4ea1d70ce73c4468d84cc8277f1f9de14b8bc
OS	Linux

Steps:

  1. installed 1.57.x
  2. launched Brave
  3. clicked on sidebar toolbar button
  4. resized side panel by grabbing side panel border
  5. closed and relaunched Brave.
  6. clicked sidebar toolbar button again
  7. confirmed the resized side panel persisted.
  8. enable vertical tabs
  9. confirmed able to resize both vertical tab panel and side panel
  10. verified sidebar doesn't occupy whole content page
  11. opened original window, Private window & new Private window with Tor
  12. confirmed all three reflected original window width of the side panel
  13. resized Private window and confirmed original window, new window & new Private window with Tor reflects the resized width of the side panel
step 3 step 4 step 7 step 9 new window private window Tor window step 13a step 13b step 13c
image image image image image image image image image image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 4, 2023
@rebron rebron changed the title Make sidebar panel resizable Add ability to resize sidebar panels Aug 8, 2023
@LaurenWags LaurenWags mentioned this issue Aug 11, 2023
Closed
@rebron rebron mentioned this issue Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

Added resize handle to side panel brave/brave-core
6 participants
@stephendonner @simonhong @LaurenWags @GeetaSarvadnya @brave-builds @MadhaviSeelam