Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Improve search suggestions option to brave://settings/search #30878

Closed
Tracked by #29517
simonhong opened this issue Jun 7, 2023 · 1 comment · Fixed by brave/brave-core#18783
Closed
Tracked by #29517

Comments

@simonhong
Copy link
Member

simonhong commented Jun 7, 2023

Description

Move Improve search suggestions options from brave://settings/privacy to below the Normal Window search engine setting in brave://settings/search

Steps to Reproduce

  1. Load brave://settings/search and check Improve search suggestions option is visible
  2. Load brave://settings/privacy and check Improve search suggestions option is hidden

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jul 4, 2023

Verification PASSED using

Brave | 1.54.90 Chromium: 115.0.5790.56 (Official Build) beta (64-bit)
-- | --
Revision | ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS | Windows 11 Version 22H2 (Build 22621.1848)

Case 1: Default Improve search suggestions setting OFF

  1. Install 1.54.90
  2. launch Brave
  3. open brave://settings/search in a new tab
  4. open brave://settings/privacy in a new tab
  5. entered a search term (shoes) in the omnibox

Confirmed Improve search suggestions setting is visible and toggled Off as a default in brave://settings/search
Confirmed Improve search suggestions settings is not shown in brave://settings/privacy
Confirmed no search suggestions shown as expected

brave://settings/search brave://settings/privacy search
image image image

Case 2: Enabled Improve search suggestions setting 'ON`

  1. continue from Case 1
    • Improve search suggestions setting is visible and toggled Off as a default in brave://settings/search
  2. toggle On in brave://settings/search tab
  3. entered a search term (shoes) in the omnibox

Confirmed search suggestions shown as expected

step 2 step 3
image image

Case 3: Upgrade

(Improve search suggestions toggle is Off)

  1. Install 1.52.129
  2. launch Brave
  3. open brave://settings/privacy
  4. verified Improve search suggestions toggle is Off
  5. close the browser
  6. rename the profile Brave-Browser-Beta
  7. launch Brave with 1.54.90
  8. opened brave://settings/search
  9. opened brave://settings/privacy

Confirmed Improve search suggestions settings is not shown in brave://settings/privacy
Confirmed Improve search suggestions setting is visible and toggled Off as a default in brave://settings/search

step 4 step 8 step 9
image image image

(Improve search suggestions toggle is On)

  1. new profile
  2. launch Brave
  3. open brave://settings/privacy
  4. verified Improve search suggestions toggle is On
  5. close the browser
  6. rename the profile Brave-Browser-Beta
  7. launch Brave with 1.54.90
  8. opened brave://settings/search
  9. opened brave://settings/privacy

Confirmed Improve search suggestions settings is not shown in brave://settings/privacy
Confirmed Improve search suggestions setting is visible and retained the On settings in brave://settings/search

step 4 step 8 step 9
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment