Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VPN Toolbar button style #30930

Closed
simonhong opened this issue Jun 9, 2023 · 5 comments · Fixed by brave/brave-core#18840
Closed

Update VPN Toolbar button style #30930

simonhong opened this issue Jun 9, 2023 · 5 comments · Fixed by brave/brave-core#18840

Comments

@simonhong
Copy link
Member

simonhong commented Jun 9, 2023

F/u issue for #30410

image

Internal only design link - https://www.figma.com/file/qtMYwoj3JWJO5xzwLt6j2f/Desktop-VPN?type=design&node-id=1822-19229&t=vH3fd5mYS94U7WlK-0

@stephendonner
Copy link

stephendonner commented Jul 1, 2023

Verification PASSED using

Brave | 1.54.85 Chromium: 115.0.5790.56 (Official Build) beta (x86_64)
-- | --
Revision | ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS | macOS Version 11.7.8 (Build 20G1351)

Shared Steps:

  1. installed 1.54.85
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. purchased, configured, and connected to Brave VPN

Default State

. VPN Off VPN On Error
Green Screen Shot 2023-07-01 at 11 00 55 PM Screen Shot 2023-07-01 at 10 32 25 PM Screen Shot 2023-07-02 at 11 39 46 PM
Red Screen Shot 2023-07-01 at 9 56 35 PM Screen Shot 2023-07-01 at 10 31 27 PM Screen Shot 2023-07-02 at 11 39 01 PM
Light Screen Shot 2023-07-01 at 9 50 17 PM Screen Shot 2023-07-01 at 10 51 34 PM Screen Shot 2023-07-02 at 11 38 29 PM
Dark Screen Shot 2023-07-01 at 9 51 51 PM Screen Shot 2023-07-01 at 10 51 14 PM Screen Shot 2023-07-02 at 11 37 50 PM

Hover/Active state

. VPN Off VPN On Error
Green Screen Shot 2023-07-02 at 2 36 39 PM Screen Shot 2023-07-02 at 2 42 31 PM Screen Shot 2023-07-02 at 11 47 30 PM
Red Screen Shot 2023-07-02 at 2 51 26 PM Screen Shot 2023-07-02 at 2 50 15 PM Screen Shot 2023-07-02 at 11 48 23 PM
Light Screen Shot 2023-07-02 at 2 53 46 PM Screen Shot 2023-07-02 at 2 54 09 PM Screen Shot 2023-07-02 at 11 49 39 PM
Dark Screen Shot 2023-07-02 at 2 55 49 PM Screen Shot 2023-07-02 at 2 55 32 PM Screen Shot 2023-07-02 at 11 49 20 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 3, 2023
@stephendonner
Copy link

stephendonner commented Jul 3, 2023

For the record (since this will also be verified on Windows), the Figma link (https://www.figma.com/file/qtMYwoj3JWJO5xzwLt6j2f/Desktop-VPN?type=design&node-id=1822-19229&t=vH3fd5mYS94U7WlK-0) shows toolbar-mockup treatments for both Private Window and Private Window with Tor

Screen Shot 2023-07-03 at 12 07 19 AM

But the VPN button doesn't appear in those window types.

cc @aguscruiz

@aguscruiz
Copy link

Shouldn't it appear anyways? Curious as to why

@stephendonner
Copy link

Shouldn't it appear anyways? Curious as to why

From @bsclifton in https://bravesoftware.slack.com/archives/CC5SA8CCB/p1677299268356949, "SKU SDK calls won't work in a private context"

@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 2, 2023

Verification PASSED using

Brave | 1.57.33 Chromium: 115.0.5790.114 (Official Build) beta (64-bit)
-- | --
Revision | 86b4ea1d70ce73c4468d84cc8277f1f9de14b8bc
OS | Windows 11 Version 22H2 (Build 22621.1992)

Shared Steps:

  1. installed 1.57.33
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. purchased, configured, and connected to Brave VPN

Default State

. VPN Off VPN On Error
Green image image image
Red image image image
Light image image image
Dark image image image

Hover/Active state

. VPN Off VPN On Error
Green image image image
Red image image image
Light image image image
Dark image image image

Note: As noted by @stephendonner, VPN is not available via Private window & Tor Window (thus, Figma designs doesn't match to these two windows)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment