Reset NTP Sponsored Image counter every 24 hours

[petemill]

Description

Currently:
After startup, we show a sponsored image on the NTP on the 2nd view and then every 4 views.

New functionality:
We should reset this count every 24 hours, after which we show a sponsored image on the NTP on the 2nd view and then every 4 views.

[btlechowski]

Issue is blocked on #33571.

[btlechowski]

Verified with

Brave	1.60.102 Chromium: 118.0.5993.96 (Official Build) beta (64-bit)
Revision	3598a9fc6b7752181feb25caa131bc386d6d054c
OS	Linux

opted out - with reset

Steps:

1. Clean profile
2. Run Brave with:

BraveNTPBrandedWallpaper:initial_count_to_branded_wallpaper/1/count_to_branded_wallpaper/5/reset_counter_after/1m

3. Open NTP
4. Open NTP -> 1st NTP SI is shown
5. Wait more than 1 minute
6. Open NTP
7. Open NTP -> 2nd NTP SI is shown

1st NTP SI on 2nd NTP:

2nd NTP SI on 4th NTP:

opted out - no reset

Steps:

1. Clean profile
2. Run Brave with:

BraveNTPBrandedWallpaper:initial_count_to_branded_wallpaper/1/count_to_branded_wallpaper/2/reset_counter_after/5m

3. Open NTP
4. Open NTP -> 1st NTP SI is shown
5. Open NTP
6. Open NTP
7. Open NTP -> 2nd NTP SI is shown

1st NTP SI on 2nd NTP:

2nd NTP SI on 5th NTP:

opted in - with reset

Steps:

1. Clean profile
2. Run Brave with:

BraveNTPBrandedWallpaper:initial_count_to_branded_wallpaper/1/count_to_branded_wallpaper/5/reset_counter_after/1m

3. Enable rewards
4. Make sure tokens are refilled
5. Open NTP
6. Open NTP -> 1st NTP SI is shown
7. Wait more than 1 minute
8. Open NTP
9. Open NTP -> 2nd NTP SI is shown

1st NTP SI on 2nd NTP:

2nd NTP SI on 4th NTP:

opted in - no reset

Steps:

1. Clean profile
2. Run Brave with:

BraveNTPBrandedWallpaper:initial_count_to_branded_wallpaper/1/count_to_branded_wallpaper/2/reset_counter_after/5m

1. Open NTP
2. Open NTP -> 1st NTP SI is shown
3. Wait more than 1 minute
4. Open NTP
5. Open NTP -> 2nd NTP SI is shown

1st NTP SI on 2nd NTP:

2nd NTP SI on 5th NTP:

[hffvld]

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 U1B2.230922.010 release-keys]
Brave build: 1.60.109
Chromium: 119.0.6045.59 (Official Build) (64-bit) 
Revision: fc399c7c433510eb03c2b35281bf8935804b99de

Filled follow-up issue #34022, plus existing issue #33837 is still opened

Opted out from Rewards - FAILED

STEPS:

1. Clean profile > Launch Brave
2. Land on the 1st NTP
3. Open 2nd NTP > Verify that the 1st NTP SI is opened on the 2nd NTP
4. Open 3 more NTP > Verify that the 2nd NTP SI is opened on the 3rd NTP thereafter
5. Open more NTP > Verify that each next NTP Si is shown on the 3rd NTP thereafter
6. Close and relaunch Brave > Repeat steps 2 - 5 > Verify the same
7. Now open NTP so you land on NTP SI > Keep Brave opened
8. Go to device settings and update the system date to 24 hours from now
9. Return to Brave > Open 2 NTP > Verify if NTP SI is shown on the 2nd NTP

ACTUAL RESULTS:

• Verified that the 1st NTP SI is opened on the 2nd NTP
• Verified that the 2nd each next NTP SI is opened on the 3rd NTP thereafter
• Verified that the count reset after Brave closed and relaunched
• Verified that we should reset the NTP SI count every 24 hours, after which we must show a sponsored image on the NTP on the 2nd view and then every 3 views

---

No reset

2023-10-31_11-05-03.mp4

After reset

2023-10-31_13-19-08.mp4

Opted in to Rewards - FAILED

STEPS:

1. Clean profile > Launch Brave
2. Enable Rewards
3. Close and relaunch Brave
4. Land on the 1st NTP
5. Open 2nd NTP > Verify that the 1st NTP SI is opened on the 2nd NTP
6. Open 3 more NTP > Verify that the 2nd NTP SI is opened on the 3rd NTP thereafter
7. Open more NTP > Verify that each next NTP Si is shown on the 3rd NTP thereafter
8. Close and relaunch Brave > Repeat steps 4 - 7 > Verify the same

ACTUAL RESULTS:

• Verified that the 1st NTP SI is opened on the 2nd NTP
• Verified that the 2nd each next NTP SI is opened on the 3rd NTP thereafter
• Verified that the count reset after Brave closed and relaunched

---

2023-10-31_11-09-13.mp4