Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NTP SI kCountsResetTimeDelay configurable via griffin/feature #33571

Closed
btlechowski opened this issue Oct 11, 2023 · 3 comments · Fixed by brave/brave-core#20628
Closed

Comments

@btlechowski
Copy link

This blocks testing of #31551

kCountsResetTimeDelay was introduced via brave/brave-core#19823

Brave version (brave://version info)

Brave 1.60.87 Chromium: 118.0.5993.70 (Official Build) beta (64-bit)
Revision 854c1e600054dfca6842cebaf729f100f4b0f066
OS Linux

cc @tmancey @aseren @petemill

@btlechowski btlechowski changed the title Make kCountsResetTimeDelay configurable via griffin/feature Make NTP SI kCountsResetTimeDelay configurable via griffin/feature Oct 11, 2023
@LaurenWags
Copy link
Member

Discussing this one with @btlechowski as it relates to testing #31551.

From my understanding #31551 requires us to keep the browser open for 24hours. This really isn't feasible for us as we can't be stuck on testing a particular issue for that long. Making this value configurable will help and allow us to test easier. As far as I know, changing the clock while the browser is open will not yield the results that we need.

@petemill if our understanding is incorrect here, please let us know.

cc @kjozwiak @rebron

@kjozwiak
Copy link
Member

The above requires 1.60.102 or higher for 1.60.x verification. @btlechowski feel free to change the QA/Yes flag if needed as the above is basically needed to run through #31551 easier rather than waiting the ~24hrs. I'm not sure if you want to add any verification notes within this one.

@btlechowski
Copy link
Author

Verified with

Brave 1.60.102 Chromium: 118.0.5993.96 (Official Build) beta (64-bit)
Revision 3598a9fc6b7752181feb25caa131bc386d6d054c
OS Linux

opted out

Verified the initial time is reset after 1 minute
Flags used:

BraveNTPBrandedWallpaper:initial_count_to_branded_wallpaper/1/count_to_branded_wallpaper/5/reset_counter_after/1m

1st NTP SI on 2nd NTP:
image

2nd NTP SI on 4th NTP:
image

opted in

Flags used:

BraveNTPBrandedWallpaper:initial_count_to_branded_wallpaper/1/count_to_branded_wallpaper/5/reset_counter_after/1m

1st NTP SI on 2nd NTP:
image

2nd NTP SI on 4th NTP:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants