Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weight is not implemented correctly #3163

Closed
NejcZdovc opened this issue Jan 30, 2019 · 1 comment · Fixed by brave/brave-core#1510
Closed

Weight is not implemented correctly #3163

NejcZdovc opened this issue Jan 30, 2019 · 1 comment · Fixed by brave/brave-core#1510
Assignees
@NejcZdovc
Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.59.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

In normalizer we are not correctly calculating weights.

JS implementation: https://github.com/brave/browser-laptop/blob/master/app/browser/api/ledger.js#L597

C++ implementation: https://github.com/brave/brave-core/blob/a30b7755df1bf4b9646a836e14fc3c65c903f5ce/vendor/bat-native-ledger/src/bat_publishers.cc#L554
@NejcZdovc NejcZdovc added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jan 30, 2019
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 30, 2019
@NejcZdovc NejcZdovc self-assigned this Jan 30, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 30, 2019
@NejcZdovc
Fixes weights in normalize process
7e8fc5d 
Resolves brave/brave-browser#3163
@NejcZdovc NejcZdovc mentioned this issue Jan 30, 2019
Merged
18 tasks
This was referenced Jan 30, 2019
Merged
Merged
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.61.x - Dev Jan 30, 2019
@NejcZdovc NejcZdovc mentioned this issue Jan 30, 2019
Merged
@LaurenWags
Copy link
Member

LaurenWags commented Jan 30, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 0.59.33 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Mac OS X
  • Verified test plan from Fixes weights in normalize process brave-core#1510
  • Verified when a profile from 0.58.21 is updated to 0.59.33 and a new site is visited, the a-c table correctly displayed (no sites lost, % values are accurate, weights in publisher_info_db are accurate)

Verification passed on

Brave 0.59.33 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Windows 7

Used test plan from brave/brave-core#1510

Verification passed on

Brave 0.59.33 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Windows 10
  • Verified test plan from Fixes weights in normalize process brave-core#1510
  • Verified when a profile from 0.58.21 is updated to 0.59.33 and a new site is visited, the a-c table correctly displayed (no sites lost, % values are accurate, weights in publisher_info_db are accurate)

Verification passed on

Brave 0.59.33 Chromium: 72.0.3626.81 (Official Build) (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Linux

Used test plan from brave/brave-core#1510

This was referenced Jan 31, 2019
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fixes weights in normalize process brave/brave-core
4 participants
@kjozwiak @NejcZdovc @LaurenWags @btlechowski